blob: a00a05b519656393d6bb898916491e6832bc1e5b (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
|
# frozen_string_literal: true
require 'spec_helper'
module Pronto
describe ESLintNpm do
let(:eslint) { ESLintNpm.new(patches) }
let(:patches) { [] }
describe '#run' do
subject(:run) { eslint.run }
context 'patches are nil' do
let(:patches) { nil }
it 'returns an empty array' do
expect(run).to eql([])
end
end
context 'no patches' do
let(:patches) { [] }
it 'returns an empty array' do
expect(run).to eql([])
end
end
context 'patches with a one and a four warnings' do
include_context 'test repo'
let(:patches) { repo.diff('master') }
it 'returns correct number of errors' do
expect(run.count).to eql(5)
end
it 'has correct first message' do
expect(run.first.msg).to eql("'foo' is not defined.")
end
context(
'with files to lint config that never matches',
config: { 'files_to_lint' => 'will never match' }
) do
it 'returns zero errors' do
expect(run.count).to eql(0)
end
end
context(
'with files to lint config that matches only .js',
config: { 'files_to_lint' => '\.js$' }
) do
it 'returns correct amount of errors' do
expect(run.count).to eql(2)
end
end
context(
'with different eslint executable',
config: { 'eslint_executable' => './custom_eslint.sh' }
) do
it 'calls the custom eslint eslint_executable' do
expect { run }.to raise_error(JSON::ParserError, /custom eslint called/)
end
end
end
context 'repo with ignored and not ignored file, each with three warnings' do
include_context 'eslintignore repo'
let(:patches) { repo.diff('master') }
it 'returns correct number of errors' do
expect(run.count).to eql(3)
end
it 'has correct first message' do
expect(run.first.msg).to eql("'HelloWorld' is defined but never used.")
end
end
end
describe '#files_to_lint' do
subject(:files_to_lint) { eslint.files_to_lint }
it 'matches .js by default' do
expect(files_to_lint).to match('my_js.js')
end
it 'matches .es6 by default' do
expect(files_to_lint).to match('my_js.es6')
end
end
describe '#eslint_executable' do
subject(:eslint_executable) { eslint.eslint_executable }
it 'is `eslint` by default' do
expect(eslint_executable).to eql('eslint')
end
context(
'with different eslint executable config',
config: { 'eslint_executable' => 'custom_eslint' }
) do
it 'is correct' do
eslint.read_config
expect(eslint_executable).to eql('custom_eslint')
end
end
end
describe '#eslint_command_line' do
subject(:eslint_command_line) { eslint.send(:eslint_command_line, path) }
let(:path) { '/some/path.rb' }
it 'adds json output flag' do
expect(eslint_command_line).to include('-f json')
end
it 'adds path' do
expect(eslint_command_line).to include(path)
end
it 'starts with eslint executable' do
expect(eslint_command_line).to start_with(eslint.eslint_executable)
end
context 'with path that should be escaped' do
let(:path) { '/must be/$escaped' }
it 'escapes the path correctly' do
expect(eslint_command_line).to include('/must\\ be/\\$escaped')
end
it 'does not include unescaped path' do
expect(eslint_command_line).not_to include(path)
end
end
end
end
end
|
