From 3a4992633ee62d5edfbb484d9c6bcb3cf158489d Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Mon, 31 Jul 2023 14:34:36 +0200 Subject: Migrate server to ESM Sorry for the very big commit that may lead to git log issues and merge conflicts, but it's a major step forward: * Server can be faster at startup because imports() are async and we can easily lazy import big modules * Angular doesn't seem to support ES import (with .js extension), so we had to correctly organize peertube into a monorepo: * Use yarn workspace feature * Use typescript reference projects for dependencies * Shared projects have been moved into "packages", each one is now a node module (with a dedicated package.json/tsconfig.json) * server/tools have been moved into apps/ and is now a dedicated app bundled and published on NPM so users don't have to build peertube cli tools manually * server/tests have been moved into packages/ so we don't compile them every time we want to run the server * Use isolatedModule option: * Had to move from const enum to const (https://www.typescriptlang.org/docs/handbook/enums.html#objects-vs-enums) * Had to explictely specify "type" imports when used in decorators * Prefer tsx (that uses esbuild under the hood) instead of ts-node to load typescript files (tests with mocha or scripts): * To reduce test complexity as esbuild doesn't support decorator metadata, we only test server files that do not import server models * We still build tests files into js files for a faster CI * Remove unmaintained peertube CLI import script * Removed some barrels to speed up execution (less imports) --- server/tests/helpers/validator.ts | 32 -------------------------------- 1 file changed, 32 deletions(-) delete mode 100644 server/tests/helpers/validator.ts (limited to 'server/tests/helpers/validator.ts') diff --git a/server/tests/helpers/validator.ts b/server/tests/helpers/validator.ts deleted file mode 100644 index f40a3aaae..000000000 --- a/server/tests/helpers/validator.ts +++ /dev/null @@ -1,32 +0,0 @@ -/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */ - -import { expect } from 'chai' -import { isPluginStableOrUnstableVersionValid, isPluginStableVersionValid } from '@server/helpers/custom-validators/plugins' - -describe('Validators', function () { - - it('Should correctly check stable plugin versions', async function () { - expect(isPluginStableVersionValid('3.4.0')).to.be.true - expect(isPluginStableVersionValid('0.4.0')).to.be.true - expect(isPluginStableVersionValid('0.1.0')).to.be.true - - expect(isPluginStableVersionValid('0.1.0-beta-1')).to.be.false - expect(isPluginStableVersionValid('hello')).to.be.false - expect(isPluginStableVersionValid('0.x.a')).to.be.false - }) - - it('Should correctly check unstable plugin versions', async function () { - expect(isPluginStableOrUnstableVersionValid('3.4.0')).to.be.true - expect(isPluginStableOrUnstableVersionValid('0.4.0')).to.be.true - expect(isPluginStableOrUnstableVersionValid('0.1.0')).to.be.true - - expect(isPluginStableOrUnstableVersionValid('0.1.0-beta.1')).to.be.true - expect(isPluginStableOrUnstableVersionValid('0.1.0-alpha.45')).to.be.true - expect(isPluginStableOrUnstableVersionValid('0.1.0-rc.45')).to.be.true - - expect(isPluginStableOrUnstableVersionValid('hello')).to.be.false - expect(isPluginStableOrUnstableVersionValid('0.x.a')).to.be.false - expect(isPluginStableOrUnstableVersionValid('0.1.0-rc-45')).to.be.false - expect(isPluginStableOrUnstableVersionValid('0.1.0-rc.45d')).to.be.false - }) -}) -- cgit v1.2.3