From 3a4992633ee62d5edfbb484d9c6bcb3cf158489d Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Mon, 31 Jul 2023 14:34:36 +0200 Subject: Migrate server to ESM Sorry for the very big commit that may lead to git log issues and merge conflicts, but it's a major step forward: * Server can be faster at startup because imports() are async and we can easily lazy import big modules * Angular doesn't seem to support ES import (with .js extension), so we had to correctly organize peertube into a monorepo: * Use yarn workspace feature * Use typescript reference projects for dependencies * Shared projects have been moved into "packages", each one is now a node module (with a dedicated package.json/tsconfig.json) * server/tools have been moved into apps/ and is now a dedicated app bundled and published on NPM so users don't have to build peertube cli tools manually * server/tests have been moved into packages/ so we don't compile them every time we want to run the server * Use isolatedModule option: * Had to move from const enum to const (https://www.typescriptlang.org/docs/handbook/enums.html#objects-vs-enums) * Had to explictely specify "type" imports when used in decorators * Prefer tsx (that uses esbuild under the hood) instead of ts-node to load typescript files (tests with mocha or scripts): * To reduce test complexity as esbuild doesn't support decorator metadata, we only test server files that do not import server models * We still build tests files into js files for a faster CI * Remove unmaintained peertube CLI import script * Removed some barrels to speed up execution (less imports) --- server/tests/api/check-params/transcoding.ts | 112 --------------------------- 1 file changed, 112 deletions(-) delete mode 100644 server/tests/api/check-params/transcoding.ts (limited to 'server/tests/api/check-params/transcoding.ts') diff --git a/server/tests/api/check-params/transcoding.ts b/server/tests/api/check-params/transcoding.ts deleted file mode 100644 index d5899e11b..000000000 --- a/server/tests/api/check-params/transcoding.ts +++ /dev/null @@ -1,112 +0,0 @@ -/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */ - -import { HttpStatusCode, UserRole } from '@shared/models' -import { - cleanupTests, - createMultipleServers, - doubleFollow, - PeerTubeServer, - setAccessTokensToServers, - waitJobs -} from '@shared/server-commands' - -describe('Test transcoding API validators', function () { - let servers: PeerTubeServer[] - - let userToken: string - let moderatorToken: string - - let remoteId: string - let validId: string - - // --------------------------------------------------------------- - - before(async function () { - this.timeout(120000) - - servers = await createMultipleServers(2) - await setAccessTokensToServers(servers) - - await doubleFollow(servers[0], servers[1]) - - userToken = await servers[0].users.generateUserAndToken('user', UserRole.USER) - moderatorToken = await servers[0].users.generateUserAndToken('moderator', UserRole.MODERATOR) - - { - const { uuid } = await servers[1].videos.quickUpload({ name: 'remote video' }) - remoteId = uuid - } - - { - const { uuid } = await servers[0].videos.quickUpload({ name: 'both 1' }) - validId = uuid - } - - await waitJobs(servers) - - await servers[0].config.enableTranscoding() - }) - - it('Should not run transcoding of a unknown video', async function () { - await servers[0].videos.runTranscoding({ videoId: 404, transcodingType: 'hls', expectedStatus: HttpStatusCode.NOT_FOUND_404 }) - await servers[0].videos.runTranscoding({ videoId: 404, transcodingType: 'web-video', expectedStatus: HttpStatusCode.NOT_FOUND_404 }) - }) - - it('Should not run transcoding of a remote video', async function () { - const expectedStatus = HttpStatusCode.BAD_REQUEST_400 - - await servers[0].videos.runTranscoding({ videoId: remoteId, transcodingType: 'hls', expectedStatus }) - await servers[0].videos.runTranscoding({ videoId: remoteId, transcodingType: 'web-video', expectedStatus }) - }) - - it('Should not run transcoding by a non admin user', async function () { - const expectedStatus = HttpStatusCode.FORBIDDEN_403 - - await servers[0].videos.runTranscoding({ videoId: validId, transcodingType: 'hls', token: userToken, expectedStatus }) - await servers[0].videos.runTranscoding({ videoId: validId, transcodingType: 'web-video', token: moderatorToken, expectedStatus }) - }) - - it('Should not run transcoding without transcoding type', async function () { - await servers[0].videos.runTranscoding({ videoId: validId, transcodingType: undefined, expectedStatus: HttpStatusCode.BAD_REQUEST_400 }) - }) - - it('Should not run transcoding with an incorrect transcoding type', async function () { - const expectedStatus = HttpStatusCode.BAD_REQUEST_400 - - await servers[0].videos.runTranscoding({ videoId: validId, transcodingType: 'toto' as any, expectedStatus }) - }) - - it('Should not run transcoding if the instance disabled it', async function () { - const expectedStatus = HttpStatusCode.BAD_REQUEST_400 - - await servers[0].config.disableTranscoding() - - await servers[0].videos.runTranscoding({ videoId: validId, transcodingType: 'hls', expectedStatus }) - await servers[0].videos.runTranscoding({ videoId: validId, transcodingType: 'web-video', expectedStatus }) - }) - - it('Should run transcoding', async function () { - this.timeout(120_000) - - await servers[0].config.enableTranscoding() - - await servers[0].videos.runTranscoding({ videoId: validId, transcodingType: 'hls' }) - await waitJobs(servers) - - await servers[0].videos.runTranscoding({ videoId: validId, transcodingType: 'web-video', forceTranscoding: true }) - await waitJobs(servers) - }) - - it('Should not run transcoding on a video that is already being transcoded if forceTranscoding is not set', async function () { - await servers[0].videos.runTranscoding({ videoId: validId, transcodingType: 'web-video' }) - - const expectedStatus = HttpStatusCode.CONFLICT_409 - await servers[0].videos.runTranscoding({ videoId: validId, transcodingType: 'web-video', expectedStatus }) - - await servers[0].videos.runTranscoding({ videoId: validId, transcodingType: 'web-video', forceTranscoding: true }) - }) - - after(async function () { - await cleanupTests(servers) - }) -}) -- cgit v1.2.3