From 970ceac0a6bf4990b8924738591df4949491ec9b Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Thu, 1 Aug 2019 10:15:28 +0200 Subject: Fix multiple server tests --- server/models/account/account-video-rate.ts | 36 +++++++++++++++++++++++++++++ server/models/video/video-comment.ts | 19 ++++++++++++++- server/models/video/video-share.ts | 29 +++++++++++++++-------- 3 files changed, 74 insertions(+), 10 deletions(-) (limited to 'server/models') diff --git a/server/models/account/account-video-rate.ts b/server/models/account/account-video-rate.ts index 85af9e378..d5c214ecb 100644 --- a/server/models/account/account-video-rate.ts +++ b/server/models/account/account-video-rate.ts @@ -89,6 +89,25 @@ export class AccountVideoRateModel extends Model { return AccountVideoRateModel.findOne(options) } + static loadByAccountAndVideoOrUrl (accountId: number, videoId: number, url: string, transaction?: Transaction) { + const options: FindOptions = { + where: { + [ Op.or]: [ + { + accountId, + videoId + }, + { + url + } + ] + } + } + if (transaction) options.transaction = transaction + + return AccountVideoRateModel.findOne(options) + } + static listByAccountForApi (options: { start: number, count: number, @@ -202,6 +221,23 @@ export class AccountVideoRateModel extends Model { videoId, type }, + include: [ + { + model: AccountModel.unscoped(), + required: true, + include: [ + { + model: ActorModel.unscoped(), + required: true, + where: { + serverId: { + [Op.ne]: null + } + } + } + ] + } + ], transaction: t } diff --git a/server/models/video/video-comment.ts b/server/models/video/video-comment.ts index 536b6cb3e..28e5818cd 100644 --- a/server/models/video/video-comment.ts +++ b/server/models/video/video-comment.ts @@ -472,7 +472,24 @@ export class VideoCommentModel extends Model { [Op.lt]: beforeUpdatedAt }, videoId - } + }, + include: [ + { + required: true, + model: AccountModel.unscoped(), + include: [ + { + required: true, + model: ActorModel.unscoped(), + where: { + serverId: { + [Op.ne]: null + } + } + } + ] + } + ] } return VideoCommentModel.destroy(query) diff --git a/server/models/video/video-share.ts b/server/models/video/video-share.ts index fda2d7cea..3bab3c027 100644 --- a/server/models/video/video-share.ts +++ b/server/models/video/video-share.ts @@ -1,4 +1,3 @@ -import * as Sequelize from 'sequelize' import * as Bluebird from 'bluebird' import { AllowNull, BelongsTo, Column, CreatedAt, DataType, ForeignKey, Is, Model, Scopes, Table, UpdatedAt } from 'sequelize-typescript' import { isActivityPubUrlValid } from '../../helpers/custom-validators/activitypub/misc' @@ -8,6 +7,7 @@ import { ActorModel } from '../activitypub/actor' import { throwIfNotValid } from '../utils' import { VideoModel } from './video' import { VideoChannelModel } from './video-channel' +import { Op, Transaction } from 'sequelize' enum ScopeNames { FULL = 'FULL', @@ -88,7 +88,7 @@ export class VideoShareModel extends Model { }) Video: VideoModel - static load (actorId: number, videoId: number, t?: Sequelize.Transaction) { + static load (actorId: number, videoId: number, t?: Transaction) { return VideoShareModel.scope(ScopeNames.WITH_ACTOR).findOne({ where: { actorId, @@ -98,7 +98,7 @@ export class VideoShareModel extends Model { }) } - static loadByUrl (url: string, t: Sequelize.Transaction) { + static loadByUrl (url: string, t: Transaction) { return VideoShareModel.scope(ScopeNames.FULL).findOne({ where: { url @@ -107,7 +107,7 @@ export class VideoShareModel extends Model { }) } - static loadActorsByShare (videoId: number, t: Sequelize.Transaction) { + static loadActorsByShare (videoId: number, t: Transaction) { const query = { where: { videoId @@ -125,7 +125,7 @@ export class VideoShareModel extends Model { .then(res => res.map(r => r.Actor)) } - static loadActorsWhoSharedVideosOf (actorOwnerId: number, t: Sequelize.Transaction): Bluebird { + static loadActorsWhoSharedVideosOf (actorOwnerId: number, t: Transaction): Bluebird { const query = { attributes: [], include: [ @@ -163,7 +163,7 @@ export class VideoShareModel extends Model { .then(res => res.map(r => r.Actor)) } - static loadActorsByVideoChannel (videoChannelId: number, t: Sequelize.Transaction): Bluebird { + static loadActorsByVideoChannel (videoChannelId: number, t: Transaction): Bluebird { const query = { attributes: [], include: [ @@ -188,7 +188,7 @@ export class VideoShareModel extends Model { .then(res => res.map(r => r.Actor)) } - static listAndCountByVideoId (videoId: number, start: number, count: number, t?: Sequelize.Transaction) { + static listAndCountByVideoId (videoId: number, start: number, count: number, t?: Transaction) { const query = { offset: start, limit: count, @@ -205,10 +205,21 @@ export class VideoShareModel extends Model { const query = { where: { updatedAt: { - [Sequelize.Op.lt]: beforeUpdatedAt + [Op.lt]: beforeUpdatedAt }, videoId - } + }, + include: [ + { + model: ActorModel.unscoped(), + required: true, + where: { + serverId: { + [ Op.ne ]: null + } + } + } + ] } return VideoShareModel.destroy(query) -- cgit v1.2.3