From 3a4992633ee62d5edfbb484d9c6bcb3cf158489d Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Mon, 31 Jul 2023 14:34:36 +0200 Subject: Migrate server to ESM Sorry for the very big commit that may lead to git log issues and merge conflicts, but it's a major step forward: * Server can be faster at startup because imports() are async and we can easily lazy import big modules * Angular doesn't seem to support ES import (with .js extension), so we had to correctly organize peertube into a monorepo: * Use yarn workspace feature * Use typescript reference projects for dependencies * Shared projects have been moved into "packages", each one is now a node module (with a dedicated package.json/tsconfig.json) * server/tools have been moved into apps/ and is now a dedicated app bundled and published on NPM so users don't have to build peertube cli tools manually * server/tests have been moved into packages/ so we don't compile them every time we want to run the server * Use isolatedModule option: * Had to move from const enum to const (https://www.typescriptlang.org/docs/handbook/enums.html#objects-vs-enums) * Had to explictely specify "type" imports when used in decorators * Prefer tsx (that uses esbuild under the hood) instead of ts-node to load typescript files (tests with mocha or scripts): * To reduce test complexity as esbuild doesn't support decorator metadata, we only test server files that do not import server models * We still build tests files into js files for a faster CI * Remove unmaintained peertube CLI import script * Removed some barrels to speed up execution (less imports) --- .../abstract-vod-transcoding-job-handler.ts | 66 ---------------------- 1 file changed, 66 deletions(-) delete mode 100644 server/lib/runners/job-handlers/abstract-vod-transcoding-job-handler.ts (limited to 'server/lib/runners/job-handlers/abstract-vod-transcoding-job-handler.ts') diff --git a/server/lib/runners/job-handlers/abstract-vod-transcoding-job-handler.ts b/server/lib/runners/job-handlers/abstract-vod-transcoding-job-handler.ts deleted file mode 100644 index f425828d9..000000000 --- a/server/lib/runners/job-handlers/abstract-vod-transcoding-job-handler.ts +++ /dev/null @@ -1,66 +0,0 @@ - -import { retryTransactionWrapper } from '@server/helpers/database-utils' -import { logger } from '@server/helpers/logger' -import { moveToFailedTranscodingState, moveToNextState } from '@server/lib/video-state' -import { VideoJobInfoModel } from '@server/models/video/video-job-info' -import { MRunnerJob } from '@server/types/models/runners' -import { RunnerJobState, RunnerJobSuccessPayload, RunnerJobUpdatePayload, RunnerJobVODPrivatePayload } from '@shared/models' -import { AbstractJobHandler } from './abstract-job-handler' -import { loadTranscodingRunnerVideo } from './shared' - -// eslint-disable-next-line max-len -export abstract class AbstractVODTranscodingJobHandler extends AbstractJobHandler { - - protected isAbortSupported () { - return true - } - - protected specificUpdate (_options: { - runnerJob: MRunnerJob - }) { - // empty - } - - protected specificAbort (_options: { - runnerJob: MRunnerJob - }) { - // empty - } - - protected async specificError (options: { - runnerJob: MRunnerJob - nextState: RunnerJobState - }) { - if (options.nextState !== RunnerJobState.ERRORED) return - - const video = await loadTranscodingRunnerVideo(options.runnerJob, this.lTags) - if (!video) return - - await moveToFailedTranscodingState(video) - - await VideoJobInfoModel.decrease(video.uuid, 'pendingTranscode') - } - - protected async specificCancel (options: { - runnerJob: MRunnerJob - }) { - const { runnerJob } = options - - const video = await loadTranscodingRunnerVideo(options.runnerJob, this.lTags) - if (!video) return - - const pending = await VideoJobInfoModel.decrease(video.uuid, 'pendingTranscode') - - logger.debug(`Pending transcode decreased to ${pending} after cancel`, this.lTags(video.uuid)) - - if (pending === 0) { - logger.info( - `All transcoding jobs of ${video.uuid} have been processed or canceled, moving it to its next state`, - this.lTags(video.uuid) - ) - - const privatePayload = runnerJob.privatePayload as RunnerJobVODPrivatePayload - await retryTransactionWrapper(moveToNextState, { video, isNewVideo: privatePayload.isNewVideo }) - } - } -} -- cgit v1.2.3