From 0a6658fdcbd779ada8f3758048c326e997902d5a Mon Sep 17 00:00:00 2001
From: Chocobozzz <florian.bigard@gmail.com>
Date: Tue, 11 Jul 2017 16:01:56 +0200
Subject: Use global uuid instead of remoteId for videos

---
 server/helpers/custom-validators/remote/videos.ts | 12 ++++++------
 server/helpers/custom-validators/videos.ts        | 14 ++++++++++----
 2 files changed, 16 insertions(+), 10 deletions(-)

(limited to 'server/helpers')

diff --git a/server/helpers/custom-validators/remote/videos.ts b/server/helpers/custom-validators/remote/videos.ts
index 1df7316aa..e14673cb3 100644
--- a/server/helpers/custom-validators/remote/videos.ts
+++ b/server/helpers/custom-validators/remote/videos.ts
@@ -9,7 +9,7 @@ import { isArray } from '../misc'
 import {
   isVideoAuthorValid,
   isVideoThumbnailDataValid,
-  isVideoRemoteIdValid,
+  isVideoUUIDValid,
   isVideoAbuseReasonValid,
   isVideoAbuseReporterUsernameValid,
   isVideoViewsValid,
@@ -50,11 +50,11 @@ function isEachRemoteRequestVideosValid (requests: any[]) {
       ) ||
       (
         isRequestTypeRemoveValid(request.type) &&
-        isVideoRemoteIdValid(video.remoteId)
+        isVideoUUIDValid(video.uuid)
       ) ||
       (
         isRequestTypeReportAbuseValid(request.type) &&
-        isVideoRemoteIdValid(request.data.videoRemoteId) &&
+        isVideoUUIDValid(request.data.videoUUID) &&
         isVideoAbuseReasonValid(request.data.reportReason) &&
         isVideoAbuseReporterUsernameValid(request.data.reporterUsername)
       )
@@ -69,7 +69,7 @@ function isEachRemoteRequestVideosQaduValid (requests: any[]) {
       if (!video) return false
 
       return (
-        isVideoRemoteIdValid(video.remoteId) &&
+        isVideoUUIDValid(video.uuid) &&
         (has(video, 'views') === false || isVideoViewsValid(video.views)) &&
         (has(video, 'likes') === false || isVideoLikesValid(video.likes)) &&
         (has(video, 'dislikes') === false || isVideoDislikesValid(video.dislikes))
@@ -85,7 +85,7 @@ function isEachRemoteRequestVideosEventsValid (requests: any[]) {
       if (!eventData) return false
 
       return (
-        isVideoRemoteIdValid(eventData.remoteId) &&
+        isVideoUUIDValid(eventData.uuid) &&
         values(REQUEST_VIDEO_EVENT_TYPES).indexOf(eventData.eventType) !== -1 &&
         isVideoEventCountValid(eventData.count)
       )
@@ -124,7 +124,7 @@ function isCommonVideoAttributesValid (video: any) {
          isVideoInfoHashValid(video.infoHash) &&
          isVideoNameValid(video.name) &&
          isVideoTagsValid(video.tags) &&
-         isVideoRemoteIdValid(video.remoteId) &&
+         isVideoUUIDValid(video.uuid) &&
          isVideoExtnameValid(video.extname) &&
          isVideoViewsValid(video.views) &&
          isVideoLikesValid(video.likes) &&
diff --git a/server/helpers/custom-validators/videos.ts b/server/helpers/custom-validators/videos.ts
index 72d226e81..e335b09d1 100644
--- a/server/helpers/custom-validators/videos.ts
+++ b/server/helpers/custom-validators/videos.ts
@@ -17,6 +17,10 @@ const VIDEOS_CONSTRAINTS_FIELDS = CONSTRAINTS_FIELDS.VIDEOS
 const VIDEO_ABUSES_CONSTRAINTS_FIELDS = CONSTRAINTS_FIELDS.VIDEO_ABUSES
 const VIDEO_EVENTS_CONSTRAINTS_FIELDS = CONSTRAINTS_FIELDS.VIDEO_EVENTS
 
+function isVideoIdOrUUIDValid (value: string) {
+  return validator.isInt(value) || isVideoUUIDValid(value)
+}
+
 function isVideoAuthorValid (value: string) {
   return isUserUsernameValid(value)
 }
@@ -77,8 +81,8 @@ function isVideoThumbnailDataValid (value: string) {
   return exists(value) && validator.isByteLength(value, VIDEOS_CONSTRAINTS_FIELDS.THUMBNAIL_DATA)
 }
 
-function isVideoRemoteIdValid (value: string) {
-  return exists(value) && validator.isUUID(value, 4)
+function isVideoUUIDValid (value: string) {
+  return exists(value) && validator.isUUID('' + value, 4)
 }
 
 function isVideoAbuseReasonValid (value: string) {
@@ -127,6 +131,7 @@ function isVideoFile (value: string, files: { [ fieldname: string ]: Express.Mul
 // ---------------------------------------------------------------------------
 
 export {
+  isVideoIdOrUUIDValid,
   isVideoAuthorValid,
   isVideoDateValid,
   isVideoCategoryValid,
@@ -141,7 +146,7 @@ export {
   isVideoThumbnailValid,
   isVideoThumbnailDataValid,
   isVideoExtnameValid,
-  isVideoRemoteIdValid,
+  isVideoUUIDValid,
   isVideoAbuseReasonValid,
   isVideoAbuseReporterUsernameValid,
   isVideoFile,
@@ -155,6 +160,7 @@ export {
 declare global {
   namespace ExpressValidator {
     export interface Validator {
+      isVideoIdOrUUIDValid,
       isVideoAuthorValid,
       isVideoDateValid,
       isVideoCategoryValid,
@@ -169,7 +175,7 @@ declare global {
       isVideoThumbnailValid,
       isVideoThumbnailDataValid,
       isVideoExtnameValid,
-      isVideoRemoteIdValid,
+      isVideoUUIDValid,
       isVideoAbuseReasonValid,
       isVideoAbuseReporterUsernameValid,
       isVideoFile,
-- 
cgit v1.2.3