From d95d15598847c7f020aa056e7e6e0c02d2bbf732 Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Wed, 1 Jul 2020 16:05:30 +0200 Subject: Use 3 tables to represent abuses --- server/helpers/middlewares/abuses.ts | 38 ++++++++++++++++++++++++++++++ server/helpers/middlewares/index.ts | 2 +- server/helpers/middlewares/video-abuses.ts | 32 ------------------------- 3 files changed, 39 insertions(+), 33 deletions(-) create mode 100644 server/helpers/middlewares/abuses.ts delete mode 100644 server/helpers/middlewares/video-abuses.ts (limited to 'server/helpers/middlewares') diff --git a/server/helpers/middlewares/abuses.ts b/server/helpers/middlewares/abuses.ts new file mode 100644 index 000000000..3906f6760 --- /dev/null +++ b/server/helpers/middlewares/abuses.ts @@ -0,0 +1,38 @@ +import { Response } from 'express' +import { AbuseModel } from '../../models/abuse/abuse' +import { fetchVideo } from '../video' + +// FIXME: deprecated in 2.3. Remove this function +async function doesVideoAbuseExist (abuseIdArg: number | string, videoUUID: string, res: Response) { + const abuseId = parseInt(abuseIdArg + '', 10) + let abuse = await AbuseModel.loadByIdAndVideoId(abuseId, null, videoUUID) + + if (!abuse) { + const userId = res.locals.oauth?.token.User.id + const video = await fetchVideo(videoUUID, 'all', userId) + + if (video) abuse = await AbuseModel.loadByIdAndVideoId(abuseId, video.id) + } + + if (abuse === null) { + res.status(404) + .json({ error: 'Video abuse not found' }) + .end() + + return false + } + + res.locals.abuse = abuse + return true +} + +async function doesAbuseExist (abuseIdArg: number | string, videoUUID: string, res: Response) { + +} + +// --------------------------------------------------------------------------- + +export { + doesAbuseExist, + doesVideoAbuseExist +} diff --git a/server/helpers/middlewares/index.ts b/server/helpers/middlewares/index.ts index f91aeaa12..f57f3ad31 100644 --- a/server/helpers/middlewares/index.ts +++ b/server/helpers/middlewares/index.ts @@ -1,5 +1,5 @@ +export * from './abuses' export * from './accounts' -export * from './video-abuses' export * from './video-blacklists' export * from './video-captions' export * from './video-channels' diff --git a/server/helpers/middlewares/video-abuses.ts b/server/helpers/middlewares/video-abuses.ts deleted file mode 100644 index 97a5724b6..000000000 --- a/server/helpers/middlewares/video-abuses.ts +++ /dev/null @@ -1,32 +0,0 @@ -import { Response } from 'express' -import { VideoAbuseModel } from '../../models/video/video-abuse' -import { fetchVideo } from '../video' - -async function doesVideoAbuseExist (abuseIdArg: number | string, videoUUID: string, res: Response) { - const abuseId = parseInt(abuseIdArg + '', 10) - let videoAbuse = await VideoAbuseModel.loadByIdAndVideoId(abuseId, null, videoUUID) - - if (!videoAbuse) { - const userId = res.locals.oauth?.token.User.id - const video = await fetchVideo(videoUUID, 'all', userId) - - if (video) videoAbuse = await VideoAbuseModel.loadByIdAndVideoId(abuseId, video.id) - } - - if (videoAbuse === null) { - res.status(404) - .json({ error: 'Video abuse not found' }) - .end() - - return false - } - - res.locals.videoAbuse = videoAbuse - return true -} - -// --------------------------------------------------------------------------- - -export { - doesVideoAbuseExist -} -- cgit v1.2.3