From 3a4992633ee62d5edfbb484d9c6bcb3cf158489d Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Mon, 31 Jul 2023 14:34:36 +0200 Subject: Migrate server to ESM Sorry for the very big commit that may lead to git log issues and merge conflicts, but it's a major step forward: * Server can be faster at startup because imports() are async and we can easily lazy import big modules * Angular doesn't seem to support ES import (with .js extension), so we had to correctly organize peertube into a monorepo: * Use yarn workspace feature * Use typescript reference projects for dependencies * Shared projects have been moved into "packages", each one is now a node module (with a dedicated package.json/tsconfig.json) * server/tools have been moved into apps/ and is now a dedicated app bundled and published on NPM so users don't have to build peertube cli tools manually * server/tests have been moved into packages/ so we don't compile them every time we want to run the server * Use isolatedModule option: * Had to move from const enum to const (https://www.typescriptlang.org/docs/handbook/enums.html#objects-vs-enums) * Had to explictely specify "type" imports when used in decorators * Prefer tsx (that uses esbuild under the hood) instead of ts-node to load typescript files (tests with mocha or scripts): * To reduce test complexity as esbuild doesn't support decorator metadata, we only test server files that do not import server models * We still build tests files into js files for a faster CI * Remove unmaintained peertube CLI import script * Removed some barrels to speed up execution (less imports) --- server/controllers/api/videos/transcoding.ts | 60 ---------------------------- 1 file changed, 60 deletions(-) delete mode 100644 server/controllers/api/videos/transcoding.ts (limited to 'server/controllers/api/videos/transcoding.ts') diff --git a/server/controllers/api/videos/transcoding.ts b/server/controllers/api/videos/transcoding.ts deleted file mode 100644 index c0b93742f..000000000 --- a/server/controllers/api/videos/transcoding.ts +++ /dev/null @@ -1,60 +0,0 @@ -import express from 'express' -import { logger, loggerTagsFactory } from '@server/helpers/logger' -import { Hooks } from '@server/lib/plugins/hooks' -import { createTranscodingJobs } from '@server/lib/transcoding/create-transcoding-job' -import { computeResolutionsToTranscode } from '@server/lib/transcoding/transcoding-resolutions' -import { VideoJobInfoModel } from '@server/models/video/video-job-info' -import { HttpStatusCode, UserRight, VideoState, VideoTranscodingCreate } from '@shared/models' -import { asyncMiddleware, authenticate, createTranscodingValidator, ensureUserHasRight } from '../../../middlewares' - -const lTags = loggerTagsFactory('api', 'video') -const transcodingRouter = express.Router() - -transcodingRouter.post('/:videoId/transcoding', - authenticate, - ensureUserHasRight(UserRight.RUN_VIDEO_TRANSCODING), - asyncMiddleware(createTranscodingValidator), - asyncMiddleware(createTranscoding) -) - -// --------------------------------------------------------------------------- - -export { - transcodingRouter -} - -// --------------------------------------------------------------------------- - -async function createTranscoding (req: express.Request, res: express.Response) { - const video = res.locals.videoAll - logger.info('Creating %s transcoding job for %s.', req.body.transcodingType, video.url, lTags()) - - const body: VideoTranscodingCreate = req.body - - await VideoJobInfoModel.abortAllTasks(video.uuid, 'pendingTranscode') - - const { resolution: maxResolution, hasAudio } = await video.probeMaxQualityFile() - - const resolutions = await Hooks.wrapObject( - computeResolutionsToTranscode({ input: maxResolution, type: 'vod', includeInput: true, strictLower: false, hasAudio }), - 'filter:transcoding.manual.resolutions-to-transcode.result', - body - ) - - if (resolutions.length === 0) { - return res.sendStatus(HttpStatusCode.NO_CONTENT_204) - } - - video.state = VideoState.TO_TRANSCODE - await video.save() - - await createTranscodingJobs({ - video, - resolutions, - transcodingType: body.transcodingType, - isNewVideo: false, - user: null // Don't specify priority since these transcoding jobs are fired by the admin - }) - - return res.sendStatus(HttpStatusCode.NO_CONTENT_204) -} -- cgit v1.2.3