From 3a4992633ee62d5edfbb484d9c6bcb3cf158489d Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Mon, 31 Jul 2023 14:34:36 +0200 Subject: Migrate server to ESM Sorry for the very big commit that may lead to git log issues and merge conflicts, but it's a major step forward: * Server can be faster at startup because imports() are async and we can easily lazy import big modules * Angular doesn't seem to support ES import (with .js extension), so we had to correctly organize peertube into a monorepo: * Use yarn workspace feature * Use typescript reference projects for dependencies * Shared projects have been moved into "packages", each one is now a node module (with a dedicated package.json/tsconfig.json) * server/tools have been moved into apps/ and is now a dedicated app bundled and published on NPM so users don't have to build peertube cli tools manually * server/tests have been moved into packages/ so we don't compile them every time we want to run the server * Use isolatedModule option: * Had to move from const enum to const (https://www.typescriptlang.org/docs/handbook/enums.html#objects-vs-enums) * Had to explictely specify "type" imports when used in decorators * Prefer tsx (that uses esbuild under the hood) instead of ts-node to load typescript files (tests with mocha or scripts): * To reduce test complexity as esbuild doesn't support decorator metadata, we only test server files that do not import server models * We still build tests files into js files for a faster CI * Remove unmaintained peertube CLI import script * Removed some barrels to speed up execution (less imports) --- server/controllers/api/bulk.ts | 44 ------------------------------------------ 1 file changed, 44 deletions(-) delete mode 100644 server/controllers/api/bulk.ts (limited to 'server/controllers/api/bulk.ts') diff --git a/server/controllers/api/bulk.ts b/server/controllers/api/bulk.ts deleted file mode 100644 index c41c7d378..000000000 --- a/server/controllers/api/bulk.ts +++ /dev/null @@ -1,44 +0,0 @@ -import express from 'express' -import { removeComment } from '@server/lib/video-comment' -import { bulkRemoveCommentsOfValidator } from '@server/middlewares/validators/bulk' -import { VideoCommentModel } from '@server/models/video/video-comment' -import { HttpStatusCode } from '@shared/models' -import { BulkRemoveCommentsOfBody } from '@shared/models/bulk/bulk-remove-comments-of-body.model' -import { apiRateLimiter, asyncMiddleware, authenticate } from '../../middlewares' - -const bulkRouter = express.Router() - -bulkRouter.use(apiRateLimiter) - -bulkRouter.post('/remove-comments-of', - authenticate, - asyncMiddleware(bulkRemoveCommentsOfValidator), - asyncMiddleware(bulkRemoveCommentsOf) -) - -// --------------------------------------------------------------------------- - -export { - bulkRouter -} - -// --------------------------------------------------------------------------- - -async function bulkRemoveCommentsOf (req: express.Request, res: express.Response) { - const account = res.locals.account - const body = req.body as BulkRemoveCommentsOfBody - const user = res.locals.oauth.token.User - - const filter = body.scope === 'my-videos' - ? { onVideosOfAccount: user.Account } - : {} - - const comments = await VideoCommentModel.listForBulkDelete(account, filter) - - // Don't wait result - res.status(HttpStatusCode.NO_CONTENT_204).end() - - for (const comment of comments) { - await removeComment(comment, req, res) - } -} -- cgit v1.2.3