From 3da68f0a781ebd893521e2e6fa200280c92ae815 Mon Sep 17 00:00:00 2001 From: Rigel Kent Date: Tue, 26 Jan 2021 01:53:13 +0100 Subject: add default trending page choice, revert comments count for hot strategy --- .../edit-custom-config.component.html | 23 ++++- .../edit-custom-config.component.ts | 10 +++ .../src/app/+videos/video-list/trending/index.ts | 2 +- .../trending/video-most-viewed.component.ts | 99 ++++++++++++++++++++++ .../trending/video-trending-header.component.html | 2 +- .../trending/video-trending-header.component.ts | 29 +++++-- .../trending/video-trending.component.ts | 99 ---------------------- client/src/app/+videos/videos-routing.module.ts | 22 +++-- client/src/app/+videos/videos.module.ts | 4 +- client/src/app/core/core.module.ts | 4 +- client/src/app/core/routing/index.ts | 1 + client/src/app/core/routing/redirect.service.ts | 26 +++++- .../src/app/core/routing/trending-guard.service.ts | 14 +++ client/src/app/core/server/server.service.ts | 8 +- client/src/app/menu/menu.component.html | 6 +- .../abstract-video-list.scss | 2 +- .../video-list-header.component.html | 5 ++ .../video-list-header.component.ts | 12 +-- 18 files changed, 233 insertions(+), 135 deletions(-) create mode 100644 client/src/app/+videos/video-list/trending/video-most-viewed.component.ts delete mode 100644 client/src/app/+videos/video-list/trending/video-trending.component.ts create mode 100644 client/src/app/core/routing/trending-guard.service.ts create mode 100644 client/src/app/shared/shared-video-miniature/video-list-header.component.html (limited to 'client/src') diff --git a/client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.html b/client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.html index 9e4691670..83b1c6a31 100644 --- a/client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.html +++ b/client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.html @@ -269,9 +269,13 @@
@@ -279,6 +283,19 @@
{{ formErrors.instance.defaultClientRoute }}
+
+ +
+ +
+
{{ formErrors.instance.defaultTrendingRoute }}
+
+ diff --git a/client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.ts b/client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.ts index 330ab075a..e6fc4582b 100644 --- a/client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.ts +++ b/client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.ts @@ -186,6 +186,12 @@ export class EditCustomConfigComponent extends FormReactive implements OnInit, A languages: null, defaultClientRoute: null, + defaultTrendingRoute: null, + pages: { + hot: { + enabled: null + } + }, customizations: { javascript: null, @@ -364,6 +370,10 @@ export class EditCustomConfigComponent extends FormReactive implements OnInit, A return this.form.value['followings']['instance']['autoFollowIndex']['enabled'] === true } + isTrendingHotEnabled () { + return this.form.value['instance']['pages']['hot']['enabled'] === true + } + async formValidated () { const value: CustomConfig = this.form.getRawValue() diff --git a/client/src/app/+videos/video-list/trending/index.ts b/client/src/app/+videos/video-list/trending/index.ts index 8bae205a5..93f4b1df6 100644 --- a/client/src/app/+videos/video-list/trending/index.ts +++ b/client/src/app/+videos/video-list/trending/index.ts @@ -1,4 +1,4 @@ export * from './video-trending-header.component' -export * from './video-trending.component' export * from './video-hot.component' +export * from './video-most-viewed.component' export * from './video-most-liked.component' diff --git a/client/src/app/+videos/video-list/trending/video-most-viewed.component.ts b/client/src/app/+videos/video-list/trending/video-most-viewed.component.ts new file mode 100644 index 000000000..98ced42d6 --- /dev/null +++ b/client/src/app/+videos/video-list/trending/video-most-viewed.component.ts @@ -0,0 +1,99 @@ +import { Component, ComponentFactoryResolver, Injector, OnDestroy, OnInit } from '@angular/core' +import { ActivatedRoute, Router } from '@angular/router' +import { AuthService, LocalStorageService, Notifier, ScreenService, ServerService, UserService } from '@app/core' +import { HooksService } from '@app/core/plugins/hooks.service' +import { immutableAssign } from '@app/helpers' +import { VideoService } from '@app/shared/shared-main' +import { AbstractVideoList } from '@app/shared/shared-video-miniature' +import { VideoSortField } from '@shared/models' +import { VideoTrendingHeaderComponent } from './video-trending-header.component' + +@Component({ + selector: 'my-videos-most-viewed', + styleUrls: [ '../../../shared/shared-video-miniature/abstract-video-list.scss' ], + templateUrl: '../../../shared/shared-video-miniature/abstract-video-list.html' +}) +export class VideoMostViewedComponent extends AbstractVideoList implements OnInit, OnDestroy { + HeaderComponent = VideoTrendingHeaderComponent + titlePage: string + defaultSort: VideoSortField = '-trending' + + useUserVideoPreferences = true + + constructor ( + protected router: Router, + protected serverService: ServerService, + protected route: ActivatedRoute, + protected notifier: Notifier, + protected authService: AuthService, + protected userService: UserService, + protected screenService: ScreenService, + protected storageService: LocalStorageService, + protected cfr: ComponentFactoryResolver, + private videoService: VideoService, + private hooks: HooksService + ) { + super() + + this.headerComponentInjector = this.getInjector() + } + + ngOnInit () { + super.ngOnInit() + + this.generateSyndicationList() + + this.serverService.getConfig().subscribe( + config => { + const trendingDays = config.trending.videos.intervalDays + + if (trendingDays === 1) { + this.titleTooltip = $localize`Trending videos are those totalizing the greatest number of views during the last 24 hours` + } else { + this.titleTooltip = $localize`Trending videos are those totalizing the greatest number of views during the last ${trendingDays} days` + } + + this.headerComponentInjector = this.getInjector() + this.setHeader() + }) + } + + ngOnDestroy () { + super.ngOnDestroy() + } + + getVideosObservable (page: number) { + const newPagination = immutableAssign(this.pagination, { currentPage: page }) + const params = { + videoPagination: newPagination, + sort: this.sort, + categoryOneOf: this.categoryOneOf, + languageOneOf: this.languageOneOf, + nsfwPolicy: this.nsfwPolicy, + skipCount: true + } + + return this.hooks.wrapObsFun( + this.videoService.getVideos.bind(this.videoService), + params, + 'common', + 'filter:api.trending-videos.videos.list.params', + 'filter:api.trending-videos.videos.list.result' + ) + } + + generateSyndicationList () { + this.syndicationItems = this.videoService.getVideoFeedUrls(this.sort, undefined, this.categoryOneOf) + } + + getInjector () { + return Injector.create({ + providers: [{ + provide: 'data', + useValue: { + model: this.defaultSort + } + }] + }) + } +} diff --git a/client/src/app/+videos/video-list/trending/video-trending-header.component.html b/client/src/app/+videos/video-list/trending/video-trending-header.component.html index 6319ee6d3..a025bf1a2 100644 --- a/client/src/app/+videos/video-list/trending/video-trending-header.component.html +++ b/client/src/app/+videos/video-list/trending/video-trending-header.component.html @@ -1,5 +1,5 @@
-