From b0c36821d1dcf362f14c99ca3741e7d03aea0a04 Mon Sep 17 00:00:00 2001 From: Jorropo Date: Tue, 4 Sep 2018 11:01:54 +0200 Subject: Add video recomandation by tags (#1001) * Recommendation by tags (thx bradsk88) Thx bradsk88 for the help. * Prefer jest-preset-angular to skip need for babel config * Fix jest --- .../recent-videos-recommendation.service.spec.ts | 8 ++--- .../recent-videos-recommendation.service.ts | 39 ++++++++++++++++------ .../recommendations/recommendations.service.ts | 3 +- .../recommended-videos.component.ts | 7 ++-- .../recommendations/recommended-videos.store.ts | 9 ++--- 5 files changed, 43 insertions(+), 23 deletions(-) (limited to 'client/src/app/videos/recommendations') diff --git a/client/src/app/videos/recommendations/recent-videos-recommendation.service.spec.ts b/client/src/app/videos/recommendations/recent-videos-recommendation.service.spec.ts index f9055b82c..698b2e27b 100644 --- a/client/src/app/videos/recommendations/recent-videos-recommendation.service.spec.ts +++ b/client/src/app/videos/recommendations/recent-videos-recommendation.service.spec.ts @@ -21,7 +21,7 @@ describe('"Recent Videos" Recommender', () => { { uuid: 'uuid2' } ] getVideosMock.mockReturnValueOnce(of({ videos: vids })) - const result = await service.getRecommendations('uuid1').toPromise() + const result = await service.getRecommendations({ uuid: 'uuid1' }).toPromise() const uuids = result.map(v => v.uuid) expect(uuids).toEqual(['uuid2']) done() @@ -36,7 +36,7 @@ describe('"Recent Videos" Recommender', () => { { uuid: 'uuid7' } ] getVideosMock.mockReturnValueOnce(of({ videos: vids })) - const result = await service.getRecommendations('uuid1').toPromise() + const result = await service.getRecommendations({ uuid: 'uuid1' }).toPromise() expect(result.length).toEqual(5) done() }) @@ -51,12 +51,12 @@ describe('"Recent Videos" Recommender', () => { ] getVideosMock .mockReturnValueOnce(of({ videos: vids })) - const result = await service.getRecommendations('uuid1').toPromise() + const result = await service.getRecommendations({ uuid: 'uuid1' }).toPromise() expect(result.length).toEqual(5) done() }) it('should fetch an extra result in case the given UUID is in the list', async (done) => { - await service.getRecommendations('uuid1').toPromise() + await service.getRecommendations({ uuid: 'uuid1' }).toPromise() let expectedSize = service.pageSize + 1 let params = { currentPage: jasmine.anything(), itemsPerPage: expectedSize } expect(getVideosMock).toHaveBeenCalledWith(params, jasmine.anything()) diff --git a/client/src/app/videos/recommendations/recent-videos-recommendation.service.ts b/client/src/app/videos/recommendations/recent-videos-recommendation.service.ts index 708d67699..4723f7fd0 100644 --- a/client/src/app/videos/recommendations/recent-videos-recommendation.service.ts +++ b/client/src/app/videos/recommendations/recent-videos-recommendation.service.ts @@ -1,9 +1,12 @@ import { Inject, Injectable } from '@angular/core' import { RecommendationService } from '@app/videos/recommendations/recommendations.service' import { Video } from '@app/shared/video/video.model' -import { VideoService, VideosProvider } from '@app/shared/video/video.service' +import { RecommendationInfo } from '@app/shared/video/recommendation-info.model' +import { VideoService } from '@app/shared/video/video.service' import { map } from 'rxjs/operators' import { Observable } from 'rxjs' +import { SearchService } from '@app/search/search.service' +import { AdvancedSearch } from '@app/search/advanced-search.model' /** * Provides "recommendations" by providing the most recently uploaded videos. @@ -14,26 +17,40 @@ export class RecentVideosRecommendationService implements RecommendationService readonly pageSize = 5 constructor ( - @Inject(VideoService) private videos: VideosProvider + private videos: VideoService, + private searchService: SearchService ) { } - getRecommendations (uuid: string): Observable { - return this.fetchPage(1) + getRecommendations (recommendation: RecommendationInfo): Observable { + return this.fetchPage(1, recommendation) .pipe( map(vids => { - const otherVideos = vids.filter(v => v.uuid !== uuid) + const otherVideos = vids.filter(v => v.uuid !== recommendation.uuid) return otherVideos.slice(0, this.pageSize) }) ) } - private fetchPage (page: number): Observable { + private fetchPage (page: number, recommendation: RecommendationInfo): Observable { let pagination = { currentPage: page, itemsPerPage: this.pageSize + 1 } - return this.videos.getVideos(pagination, '-createdAt') - .pipe( - map(v => v.videos) - ) + if (!recommendation.tags) { + return this.videos.getVideos(pagination, '-createdAt') + .pipe( + map(v => v.videos) + ) + } + if (recommendation.tags.length === 0) { + return this.videos.getVideos(pagination, '-createdAt') + .pipe( + map(v => v.videos) + ) + } + return this.searchService.searchVideos('', + pagination, + new AdvancedSearch({ tagsOneOf: recommendation.tags.join(','), sort: '-createdAt' }) + ).pipe( + map(v => v.videos) + ) } - } diff --git a/client/src/app/videos/recommendations/recommendations.service.ts b/client/src/app/videos/recommendations/recommendations.service.ts index 44cbda9b7..114a808b5 100644 --- a/client/src/app/videos/recommendations/recommendations.service.ts +++ b/client/src/app/videos/recommendations/recommendations.service.ts @@ -1,8 +1,9 @@ import { Video } from '@app/shared/video/video.model' +import { RecommendationInfo } from '@app/shared/video/recommendation-info.model' import { Observable } from 'rxjs' export type UUID = string export interface RecommendationService { - getRecommendations (uuid: UUID): Observable + getRecommendations (recommendation: RecommendationInfo): Observable } diff --git a/client/src/app/videos/recommendations/recommended-videos.component.ts b/client/src/app/videos/recommendations/recommended-videos.component.ts index aa4dd0ee2..c6c1d9e5d 100644 --- a/client/src/app/videos/recommendations/recommended-videos.component.ts +++ b/client/src/app/videos/recommendations/recommended-videos.component.ts @@ -1,6 +1,7 @@ import { Component, Input, OnChanges } from '@angular/core' import { Observable } from 'rxjs' import { Video } from '@app/shared/video/video.model' +import { RecommendationInfo } from '@app/shared/video/recommendation-info.model' import { RecommendedVideosStore } from '@app/videos/recommendations/recommended-videos.store' import { User } from '@app/shared' @@ -9,7 +10,7 @@ import { User } from '@app/shared' templateUrl: './recommended-videos.component.html' }) export class RecommendedVideosComponent implements OnChanges { - @Input() inputVideo: Video + @Input() inputRecommendation: RecommendationInfo @Input() user: User readonly hasVideos$: Observable @@ -23,8 +24,8 @@ export class RecommendedVideosComponent implements OnChanges { } public ngOnChanges (): void { - if (this.inputVideo) { - this.store.requestNewRecommendations(this.inputVideo.uuid) + if (this.inputRecommendation) { + this.store.requestNewRecommendations(this.inputRecommendation) } } diff --git a/client/src/app/videos/recommendations/recommended-videos.store.ts b/client/src/app/videos/recommendations/recommended-videos.store.ts index 689adeb1f..eb5c9867f 100644 --- a/client/src/app/videos/recommendations/recommended-videos.store.ts +++ b/client/src/app/videos/recommendations/recommended-videos.store.ts @@ -1,6 +1,7 @@ import { Inject, Injectable } from '@angular/core' import { Observable, ReplaySubject } from 'rxjs' import { Video } from '@app/shared/video/video.model' +import { RecommendationInfo } from '@app/shared/video/recommendation-info.model' import { RecentVideosRecommendationService } from '@app/videos/recommendations/recent-videos-recommendation.service' import { RecommendationService, UUID } from '@app/videos/recommendations/recommendations.service' import { map, switchMap, take } from 'rxjs/operators' @@ -12,13 +13,13 @@ import { map, switchMap, take } from 'rxjs/operators' export class RecommendedVideosStore { public readonly recommendations$: Observable public readonly hasRecommendations$: Observable - private readonly requestsForLoad$$ = new ReplaySubject(1) + private readonly requestsForLoad$$ = new ReplaySubject(1) constructor ( @Inject(RecentVideosRecommendationService) private recommendations: RecommendationService ) { this.recommendations$ = this.requestsForLoad$$.pipe( - switchMap(requestedUUID => recommendations.getRecommendations(requestedUUID) + switchMap(requestedRecommendation => recommendations.getRecommendations(requestedRecommendation) .pipe(take(1)) )) this.hasRecommendations$ = this.recommendations$.pipe( @@ -26,7 +27,7 @@ export class RecommendedVideosStore { ) } - requestNewRecommendations (videoUUID: string) { - this.requestsForLoad$$.next(videoUUID) + requestNewRecommendations (recommend: RecommendationInfo) { + this.requestsForLoad$$.next(recommend) } } -- cgit v1.2.3