From bc48e33b80f357767b98c1d310b04bdda24c6d46 Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Fri, 13 Jan 2023 09:39:35 +0100 Subject: Optimize custom markup angular tags We can use the on push strategy with these components --- .../peertube-custom-tags/button-markup.component.ts | 5 +++-- .../peertube-custom-tags/channel-miniature-markup.component.ts | 5 +++-- .../peertube-custom-tags/playlist-miniature-markup.component.ts | 5 +++-- .../peertube-custom-tags/video-miniature-markup.component.ts | 5 +++-- .../peertube-custom-tags/videos-list-markup.component.ts | 5 +++-- 5 files changed, 15 insertions(+), 10 deletions(-) (limited to 'client/src/app/shared/shared-custom-markup/peertube-custom-tags') diff --git a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/button-markup.component.ts b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/button-markup.component.ts index 1af060548..264dd9577 100644 --- a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/button-markup.component.ts +++ b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/button-markup.component.ts @@ -1,4 +1,4 @@ -import { Component, Input } from '@angular/core' +import { ChangeDetectionStrategy, Component, Input } from '@angular/core' import { VideoChannel } from '../../shared-main' import { CustomMarkupComponent } from './shared' @@ -9,7 +9,8 @@ import { CustomMarkupComponent } from './shared' @Component({ selector: 'my-button-markup', templateUrl: 'button-markup.component.html', - styleUrls: [ 'button-markup.component.scss' ] + styleUrls: [ 'button-markup.component.scss' ], + changeDetection: ChangeDetectionStrategy.OnPush }) export class ButtonMarkupComponent implements CustomMarkupComponent { @Input() theme: 'primary' | 'secondary' diff --git a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/channel-miniature-markup.component.ts b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/channel-miniature-markup.component.ts index ba12b7139..1e7860750 100644 --- a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/channel-miniature-markup.component.ts +++ b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/channel-miniature-markup.component.ts @@ -1,6 +1,6 @@ import { from } from 'rxjs' import { finalize, map, switchMap, tap } from 'rxjs/operators' -import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core' +import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnInit, Output } from '@angular/core' import { MarkdownService, Notifier, UserService } from '@app/core' import { FindInBulkService } from '@app/shared/shared-search' import { VideoSortField } from '@shared/models' @@ -14,7 +14,8 @@ import { CustomMarkupComponent } from './shared' @Component({ selector: 'my-channel-miniature-markup', templateUrl: 'channel-miniature-markup.component.html', - styleUrls: [ 'channel-miniature-markup.component.scss' ] + styleUrls: [ 'channel-miniature-markup.component.scss' ], + changeDetection: ChangeDetectionStrategy.OnPush }) export class ChannelMiniatureMarkupComponent implements CustomMarkupComponent, OnInit { @Input() name: string diff --git a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/playlist-miniature-markup.component.ts b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/playlist-miniature-markup.component.ts index 07fa6fd2d..ab52e7e37 100644 --- a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/playlist-miniature-markup.component.ts +++ b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/playlist-miniature-markup.component.ts @@ -1,5 +1,5 @@ import { finalize } from 'rxjs/operators' -import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core' +import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnInit, Output } from '@angular/core' import { Notifier } from '@app/core' import { FindInBulkService } from '@app/shared/shared-search' import { MiniatureDisplayOptions } from '../../shared-video-miniature' @@ -13,7 +13,8 @@ import { CustomMarkupComponent } from './shared' @Component({ selector: 'my-playlist-miniature-markup', templateUrl: 'playlist-miniature-markup.component.html', - styleUrls: [ 'playlist-miniature-markup.component.scss' ] + styleUrls: [ 'playlist-miniature-markup.component.scss' ], + changeDetection: ChangeDetectionStrategy.OnPush }) export class PlaylistMiniatureMarkupComponent implements CustomMarkupComponent, OnInit { @Input() uuid: string diff --git a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/video-miniature-markup.component.ts b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/video-miniature-markup.component.ts index cbbacf77c..c37666359 100644 --- a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/video-miniature-markup.component.ts +++ b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/video-miniature-markup.component.ts @@ -1,5 +1,5 @@ import { finalize } from 'rxjs/operators' -import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core' +import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnInit, Output } from '@angular/core' import { AuthService, Notifier } from '@app/core' import { FindInBulkService } from '@app/shared/shared-search' import { Video } from '../../shared-main' @@ -13,7 +13,8 @@ import { CustomMarkupComponent } from './shared' @Component({ selector: 'my-video-miniature-markup', templateUrl: 'video-miniature-markup.component.html', - styleUrls: [ 'video-miniature-markup.component.scss' ] + styleUrls: [ 'video-miniature-markup.component.scss' ], + changeDetection: ChangeDetectionStrategy.OnPush }) export class VideoMiniatureMarkupComponent implements CustomMarkupComponent, OnInit { @Input() uuid: string diff --git a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/videos-list-markup.component.ts b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/videos-list-markup.component.ts index 7d3498d4c..70e88ea51 100644 --- a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/videos-list-markup.component.ts +++ b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/videos-list-markup.component.ts @@ -1,5 +1,5 @@ import { finalize } from 'rxjs/operators' -import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core' +import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnInit, Output } from '@angular/core' import { AuthService, Notifier } from '@app/core' import { VideoSortField } from '@shared/models' import { Video, VideoService } from '../../shared-main' @@ -13,7 +13,8 @@ import { CustomMarkupComponent } from './shared' @Component({ selector: 'my-videos-list-markup', templateUrl: 'videos-list-markup.component.html', - styleUrls: [ 'videos-list-markup.component.scss' ] + styleUrls: [ 'videos-list-markup.component.scss' ], + changeDetection: ChangeDetectionStrategy.OnPush }) export class VideosListMarkupComponent implements CustomMarkupComponent, OnInit { @Input() sort: string -- cgit v1.2.3