From 66357162f8e1227495f09bd4f68446aad7071c6d Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Wed, 12 Aug 2020 10:40:04 +0200 Subject: Migrate to $localize * Remove i18n polyfill to translate things in components * Reduce bundle sizes * Improve runtime perf * Reduce a lot the time to make a full client build * Reduce client build complexity * We don't need a service to translate things anymore (so we will be able to translate title pages etc) Unfortunately we may loose some translations in the migration process. I'll put a message on weblate to notify translators --- client/src/app/core/auth/auth.service.ts | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) (limited to 'client/src/app/core/auth/auth.service.ts') diff --git a/client/src/app/core/auth/auth.service.ts b/client/src/app/core/auth/auth.service.ts index d3dc48267..10e2c2c58 100644 --- a/client/src/app/core/auth/auth.service.ts +++ b/client/src/app/core/auth/auth.service.ts @@ -6,7 +6,6 @@ import { Injectable } from '@angular/core' import { Router } from '@angular/router' import { Notifier } from '@app/core/notification/notifier.service' import { objectToUrlEncoded, peertubeLocalStorage } from '@root-helpers/index' -import { I18n } from '@ngx-translate/i18n-polyfill' import { MyUser as UserServerModel, OAuthClientLocal, User, UserLogin, UserRefreshToken } from '@shared/models' import { environment } from '../../../environments/environment' import { RestExtractor } from '../rest/rest-extractor.service' @@ -48,9 +47,8 @@ export class AuthService { private notifier: Notifier, private hotkeysService: HotkeysService, private restExtractor: RestExtractor, - private router: Router, - private i18n: I18n - ) { + private router: Router + ) { this.loginChanged = new Subject() this.loginChangedSource = this.loginChanged.asObservable() @@ -62,19 +60,19 @@ export class AuthService { new Hotkey('m s', (event: KeyboardEvent): boolean => { this.router.navigate([ '/videos/subscriptions' ]) return false - }, undefined, this.i18n('Go to my subscriptions')), + }, undefined, $localize`Go to my subscriptions`), new Hotkey('m v', (event: KeyboardEvent): boolean => { this.router.navigate([ '/my-account/videos' ]) return false - }, undefined, this.i18n('Go to my videos')), + }, undefined, $localize`Go to my videos`), new Hotkey('m i', (event: KeyboardEvent): boolean => { this.router.navigate([ '/my-account/video-imports' ]) return false - }, undefined, this.i18n('Go to my imports')), + }, undefined, $localize`Go to my imports`), new Hotkey('m c', (event: KeyboardEvent): boolean => { this.router.navigate([ '/my-account/video-channels' ]) return false - }, undefined, this.i18n('Go to my channels')) + }, undefined, $localize`Go to my channels`) ] } @@ -97,14 +95,12 @@ export class AuthService { let errorMessage = error.message if (error.status === 403) { - errorMessage = this.i18n('Cannot retrieve OAuth Client credentials: {{errorText}}.\n', { errorText: error.text }) - errorMessage += this.i18n( - 'Ensure you have correctly configured PeerTube (config/ directory), in particular the "webserver" section.' - ) + errorMessage = $localize`Cannot retrieve OAuth Client credentials: ${error.text}. +Ensure you have correctly configured PeerTube (config/ directory), in particular the "webserver" section.` } // We put a bigger timeout: this is an important message - this.notifier.error(errorMessage, this.i18n('Error'), 7000) + this.notifier.error(errorMessage, $localize`Error`, 7000) } ) } @@ -216,7 +212,7 @@ export class AuthService { this.router.navigate([ '/login' ]) return observableThrowError({ - error: this.i18n('You need to reconnect.') + error: $localize`You need to reconnect.` }) }), share() -- cgit v1.2.3