From 923d3d5ad53cd23bf8107e936408e321f6175517 Mon Sep 17 00:00:00 2001 From: Rigel Kent Date: Thu, 28 Jan 2021 14:43:02 +0100 Subject: add test and openapi for hot sort parameter --- server/models/video/video-query-builder.ts | 4 +++- server/tests/api/videos/single-server.ts | 8 ++++++++ support/doc/api/openapi.yaml | 1 + 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/server/models/video/video-query-builder.ts b/server/models/video/video-query-builder.ts index 3f31ac862..e2145fb9a 100644 --- a/server/models/video/video-query-builder.ts +++ b/server/models/video/video-query-builder.ts @@ -262,7 +262,9 @@ function buildListQuery (model: typeof Model, options: BuildVideosQueryOptions) * justify a better score. However there are multiple ways to achieve that * goal, which is left for later. Yes, this is a TODO :) * - * note: weights and base score are in number of half-days. + * notes: + * - weights and base score are in number of half-days. + * - all comments are counted, regardless of being written by the video author or not * see https://github.com/reddit-archive/reddit/blob/master/r2/r2/lib/db/_sorts.pyx#L47-L58 */ const weights = { diff --git a/server/tests/api/videos/single-server.ts b/server/tests/api/videos/single-server.ts index b74bc3e80..52c6800c1 100644 --- a/server/tests/api/videos/single-server.ts +++ b/server/tests/api/videos/single-server.ts @@ -355,6 +355,14 @@ describe('Test a single server', function () { expect(videos.length).to.equal(2) }) + it('Should list and sort by hotness in descending order', async function () { + const res = await getVideosListPagination(server.url, 0, 2, '-hot') + + const videos = res.body.data + expect(res.body.total).to.equal(6) + expect(videos.length).to.equal(2) + }) + it('Should update a video', async function () { const attributes = { name: 'my super video updated', diff --git a/support/doc/api/openapi.yaml b/support/doc/api/openapi.yaml index 8ad98a9a9..b05a113ca 100644 --- a/support/doc/api/openapi.yaml +++ b/support/doc/api/openapi.yaml @@ -3491,6 +3491,7 @@ components: - -views - -likes - -trending + - -hot videosSearchSort: name: sort in: query -- cgit v1.2.3