From 86c5229b4d726202378ef46854383bcafca22310 Mon Sep 17 00:00:00 2001
From: Chocobozzz <me@florianbigard.com>
Date: Mon, 2 May 2022 10:49:48 +0200
Subject: Save replay of permanent live in client

---
 .../edit-live-configuration.component.html            |  3 ---
 .../+video-edit/shared/video-edit.component.ts        | 19 -------------------
 .../video-add-components/video-go-live.component.ts   |  2 +-
 server/middlewares/validators/videos/video-live.ts    |  4 ----
 server/tests/api/check-params/live.ts                 |  6 ------
 5 files changed, 1 insertion(+), 33 deletions(-)

diff --git a/client/src/app/+admin/config/edit-custom-config/edit-live-configuration.component.html b/client/src/app/+admin/config/edit-custom-config/edit-live-configuration.component.html
index b29651437..71d5d91f0 100644
--- a/client/src/app/+admin/config/edit-custom-config/edit-live-configuration.component.html
+++ b/client/src/app/+admin/config/edit-custom-config/edit-live-configuration.component.html
@@ -30,9 +30,6 @@
                   inputName="liveAllowReplay" formControlName="allowReplay"
                   i18n-labelText labelText="Allow your users to automatically publish a replay of their live"
                 >
-                  <ng-container ngProjectAs="description" i18n>
-                    If the user quota is reached, PeerTube will automatically terminate the live streaming
-                  </ng-container>
                 </my-peertube-checkbox>
               </div>
 
diff --git a/client/src/app/+videos/+video-edit/shared/video-edit.component.ts b/client/src/app/+videos/+video-edit/shared/video-edit.component.ts
index a2399eafb..16b964482 100644
--- a/client/src/app/+videos/+video-edit/shared/video-edit.component.ts
+++ b/client/src/app/+videos/+video-edit/shared/video-edit.component.ts
@@ -180,7 +180,6 @@ export class VideoEditComponent implements OnInit, OnDestroy {
 
     this.trackChannelChange()
     this.trackPrivacyChange()
-    this.trackLivePermanentFieldChange()
 
     this.formBuilt.emit()
   }
@@ -457,24 +456,6 @@ export class VideoEditComponent implements OnInit, OnDestroy {
       )
   }
 
-  private trackLivePermanentFieldChange () {
-    // We will update the "support" field depending on the channel
-    this.form.controls['permanentLive']
-      .valueChanges
-      .subscribe(
-        permanentLive => {
-          const saveReplayControl = this.form.controls['saveReplay']
-
-          if (permanentLive === true) {
-            saveReplayControl.setValue(false)
-            saveReplayControl.disable()
-          } else {
-            saveReplayControl.enable()
-          }
-        }
-      )
-  }
-
   private updateSupportField (support: string) {
     return this.form.patchValue({ support: support || '' })
   }
diff --git a/client/src/app/+videos/+video-edit/video-add-components/video-go-live.component.ts b/client/src/app/+videos/+video-edit/video-add-components/video-go-live.component.ts
index fde8c884b..725120d16 100644
--- a/client/src/app/+videos/+video-edit/video-add-components/video-go-live.component.ts
+++ b/client/src/app/+videos/+video-edit/video-add-components/video-go-live.component.ts
@@ -71,7 +71,7 @@ export class VideoGoLiveComponent extends VideoSend implements OnInit, AfterView
       nsfw: this.serverConfig.instance.isNSFW,
       waitTranscoding: true,
       permanentLive: this.firstStepPermanentLive,
-      saveReplay: this.firstStepPermanentLive === false && this.isReplayAllowed(),
+      saveReplay: this.isReplayAllowed(),
       channelId: this.firstStepChannelId
     }
 
diff --git a/server/middlewares/validators/videos/video-live.ts b/server/middlewares/validators/videos/video-live.ts
index 8f821c5f9..ff492da0f 100644
--- a/server/middlewares/validators/videos/video-live.ts
+++ b/server/middlewares/validators/videos/video-live.ts
@@ -170,10 +170,6 @@ const videoLiveUpdateValidator = [
 
     const body: LiveVideoUpdate = req.body
 
-    if (body.permanentLive && body.saveReplay) {
-      return res.fail({ message: 'Cannot set this live as permanent while saving its replay' })
-    }
-
     if (hasValidSaveReplay(body) !== true) {
       return res.fail({
         status: HttpStatusCode.FORBIDDEN_403,
diff --git a/server/tests/api/check-params/live.ts b/server/tests/api/check-params/live.ts
index 8d520da0d..bbd331657 100644
--- a/server/tests/api/check-params/live.ts
+++ b/server/tests/api/check-params/live.ts
@@ -414,12 +414,6 @@ describe('Test video lives API validator', function () {
       await command.update({ videoId: videoIdNotLive, fields: {}, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
     })
 
-    it('Should fail with save replay and permanent live set to true', async function () {
-      const fields = { saveReplay: true, permanentLive: true }
-
-      await command.update({ videoId: video.id, fields, expectedStatus: HttpStatusCode.BAD_REQUEST_400 })
-    })
-
     it('Should fail with bad latency setting', async function () {
       const fields = { latencyMode: 42 }
 
-- 
cgit v1.2.3