diff options
Diffstat (limited to 'server/middlewares/validators')
-rw-r--r-- | server/middlewares/validators/follows.ts | 13 | ||||
-rw-r--r-- | server/middlewares/validators/video-channels.ts | 31 | ||||
-rw-r--r-- | server/middlewares/validators/webfinger.ts | 10 |
3 files changed, 14 insertions, 40 deletions
diff --git a/server/middlewares/validators/follows.ts b/server/middlewares/validators/follows.ts index 10482e5d0..2240d30db 100644 --- a/server/middlewares/validators/follows.ts +++ b/server/middlewares/validators/follows.ts | |||
@@ -1,10 +1,9 @@ | |||
1 | import * as express from 'express' | 1 | import * as express from 'express' |
2 | import { body, param } from 'express-validator/check' | 2 | import { body, param } from 'express-validator/check' |
3 | import { getServerAccount, isTestInstance, logger } from '../../helpers' | 3 | import { getServerActor, isTestInstance, logger } from '../../helpers' |
4 | import { isIdOrUUIDValid } from '../../helpers/custom-validators/misc' | 4 | import { isEachUniqueHostValid, isHostValid } from '../../helpers/custom-validators/servers' |
5 | import { isEachUniqueHostValid } from '../../helpers/custom-validators/servers' | ||
6 | import { CONFIG } from '../../initializers' | 5 | import { CONFIG } from '../../initializers' |
7 | import { AccountFollowModel } from '../../models/account/account-follow' | 6 | import { ActorFollowModel } from '../../models/activitypub/actor-follow' |
8 | import { areValidationErrors } from './utils' | 7 | import { areValidationErrors } from './utils' |
9 | 8 | ||
10 | const followValidator = [ | 9 | const followValidator = [ |
@@ -29,15 +28,15 @@ const followValidator = [ | |||
29 | ] | 28 | ] |
30 | 29 | ||
31 | const removeFollowingValidator = [ | 30 | const removeFollowingValidator = [ |
32 | param('accountId').custom(isIdOrUUIDValid).withMessage('Should have a valid account id'), | 31 | param('host').custom(isHostValid).withMessage('Should have a valid host'), |
33 | 32 | ||
34 | async (req: express.Request, res: express.Response, next: express.NextFunction) => { | 33 | async (req: express.Request, res: express.Response, next: express.NextFunction) => { |
35 | logger.debug('Checking unfollow parameters', { parameters: req.params }) | 34 | logger.debug('Checking unfollow parameters', { parameters: req.params }) |
36 | 35 | ||
37 | if (areValidationErrors(req, res)) return | 36 | if (areValidationErrors(req, res)) return |
38 | 37 | ||
39 | const serverAccount = await getServerAccount() | 38 | const serverActor = await getServerActor() |
40 | const follow = await AccountFollowModel.loadByAccountAndTarget(serverAccount.id, req.params.accountId) | 39 | const follow = await ActorFollowModel.loadByActorAndTargetHost(serverActor.id, req.params.host) |
41 | 40 | ||
42 | if (!follow) { | 41 | if (!follow) { |
43 | return res.status(404) | 42 | return res.status(404) |
diff --git a/server/middlewares/validators/video-channels.ts b/server/middlewares/validators/video-channels.ts index 068fd210f..cc7d54c06 100644 --- a/server/middlewares/validators/video-channels.ts +++ b/server/middlewares/validators/video-channels.ts | |||
@@ -3,7 +3,7 @@ import { body, param } from 'express-validator/check' | |||
3 | import { UserRight } from '../../../shared' | 3 | import { UserRight } from '../../../shared' |
4 | import { logger } from '../../helpers' | 4 | import { logger } from '../../helpers' |
5 | import { isAccountIdExist } from '../../helpers/custom-validators/accounts' | 5 | import { isAccountIdExist } from '../../helpers/custom-validators/accounts' |
6 | import { isIdOrUUIDValid, isIdValid } from '../../helpers/custom-validators/misc' | 6 | import { isIdOrUUIDValid } from '../../helpers/custom-validators/misc' |
7 | import { | 7 | import { |
8 | isVideoChannelDescriptionValid, | 8 | isVideoChannelDescriptionValid, |
9 | isVideoChannelExist, | 9 | isVideoChannelExist, |
@@ -11,7 +11,6 @@ import { | |||
11 | } from '../../helpers/custom-validators/video-channels' | 11 | } from '../../helpers/custom-validators/video-channels' |
12 | import { UserModel } from '../../models/account/user' | 12 | import { UserModel } from '../../models/account/user' |
13 | import { VideoChannelModel } from '../../models/video/video-channel' | 13 | import { VideoChannelModel } from '../../models/video/video-channel' |
14 | import { VideoChannelShareModel } from '../../models/video/video-channel-share' | ||
15 | import { areValidationErrors } from './utils' | 14 | import { areValidationErrors } from './utils' |
16 | 15 | ||
17 | const listVideoAccountChannelsValidator = [ | 16 | const listVideoAccountChannelsValidator = [ |
@@ -98,28 +97,6 @@ const videoChannelsGetValidator = [ | |||
98 | } | 97 | } |
99 | ] | 98 | ] |
100 | 99 | ||
101 | const videoChannelsShareValidator = [ | ||
102 | param('id').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid id'), | ||
103 | param('accountId').custom(isIdValid).not().isEmpty().withMessage('Should have a valid account id'), | ||
104 | |||
105 | async (req: express.Request, res: express.Response, next: express.NextFunction) => { | ||
106 | logger.debug('Checking videoChannelShare parameters', { parameters: req.params }) | ||
107 | |||
108 | if (areValidationErrors(req, res)) return | ||
109 | if (!await isVideoChannelExist(req.params.id, res)) return | ||
110 | |||
111 | const share = await VideoChannelShareModel.load(res.locals.video.id, req.params.accountId, undefined) | ||
112 | if (!share) { | ||
113 | return res.status(404) | ||
114 | .end() | ||
115 | } | ||
116 | |||
117 | res.locals.videoChannelShare = share | ||
118 | |||
119 | return next() | ||
120 | } | ||
121 | ] | ||
122 | |||
123 | // --------------------------------------------------------------------------- | 100 | // --------------------------------------------------------------------------- |
124 | 101 | ||
125 | export { | 102 | export { |
@@ -127,15 +104,13 @@ export { | |||
127 | videoChannelsAddValidator, | 104 | videoChannelsAddValidator, |
128 | videoChannelsUpdateValidator, | 105 | videoChannelsUpdateValidator, |
129 | videoChannelsRemoveValidator, | 106 | videoChannelsRemoveValidator, |
130 | videoChannelsGetValidator, | 107 | videoChannelsGetValidator |
131 | videoChannelsShareValidator | ||
132 | } | 108 | } |
133 | 109 | ||
134 | // --------------------------------------------------------------------------- | 110 | // --------------------------------------------------------------------------- |
135 | 111 | ||
136 | function checkUserCanDeleteVideoChannel (user: UserModel, videoChannel: VideoChannelModel, res: express.Response) { | 112 | function checkUserCanDeleteVideoChannel (user: UserModel, videoChannel: VideoChannelModel, res: express.Response) { |
137 | // Retrieve the user who did the request | 113 | if (videoChannel.Actor.isOwned() === false) { |
138 | if (videoChannel.isOwned() === false) { | ||
139 | res.status(403) | 114 | res.status(403) |
140 | .json({ error: 'Cannot remove video channel of another server.' }) | 115 | .json({ error: 'Cannot remove video channel of another server.' }) |
141 | .end() | 116 | .end() |
diff --git a/server/middlewares/validators/webfinger.ts b/server/middlewares/validators/webfinger.ts index 7903c7400..2c8351799 100644 --- a/server/middlewares/validators/webfinger.ts +++ b/server/middlewares/validators/webfinger.ts | |||
@@ -2,7 +2,7 @@ import * as express from 'express' | |||
2 | import { query } from 'express-validator/check' | 2 | import { query } from 'express-validator/check' |
3 | import { logger } from '../../helpers' | 3 | import { logger } from '../../helpers' |
4 | import { isWebfingerResourceValid } from '../../helpers/custom-validators/webfinger' | 4 | import { isWebfingerResourceValid } from '../../helpers/custom-validators/webfinger' |
5 | import { AccountModel } from '../../models/account/account' | 5 | import { ActorModel } from '../../models/activitypub/actor' |
6 | import { areValidationErrors } from './utils' | 6 | import { areValidationErrors } from './utils' |
7 | 7 | ||
8 | const webfingerValidator = [ | 8 | const webfingerValidator = [ |
@@ -17,14 +17,14 @@ const webfingerValidator = [ | |||
17 | const nameWithHost = req.query.resource.substr(5) | 17 | const nameWithHost = req.query.resource.substr(5) |
18 | const [ name ] = nameWithHost.split('@') | 18 | const [ name ] = nameWithHost.split('@') |
19 | 19 | ||
20 | const account = await AccountModel.loadLocalByName(name) | 20 | const actor = await ActorModel.loadLocalByName(name) |
21 | if (!account) { | 21 | if (!actor) { |
22 | return res.status(404) | 22 | return res.status(404) |
23 | .send({ error: 'Account not found' }) | 23 | .send({ error: 'Actor not found' }) |
24 | .end() | 24 | .end() |
25 | } | 25 | } |
26 | 26 | ||
27 | res.locals.account = account | 27 | res.locals.actor = actor |
28 | return next() | 28 | return next() |
29 | } | 29 | } |
30 | ] | 30 | ] |