diff options
Diffstat (limited to 'server/controllers')
-rw-r--r-- | server/controllers/api/index.ts | 10 | ||||
-rw-r--r-- | server/controllers/api/users/index.ts | 18 |
2 files changed, 23 insertions, 5 deletions
diff --git a/server/controllers/api/index.ts b/server/controllers/api/index.ts index 60a84036e..ea2615e28 100644 --- a/server/controllers/api/index.ts +++ b/server/controllers/api/index.ts | |||
@@ -1,4 +1,5 @@ | |||
1 | import * as express from 'express' | 1 | import * as express from 'express' |
2 | import * as RateLimit from 'express-rate-limit' | ||
2 | import { configRouter } from './config' | 3 | import { configRouter } from './config' |
3 | import { jobsRouter } from './jobs' | 4 | import { jobsRouter } from './jobs' |
4 | import { oauthClientsRouter } from './oauth-clients' | 5 | import { oauthClientsRouter } from './oauth-clients' |
@@ -12,6 +13,7 @@ import * as cors from 'cors' | |||
12 | import { searchRouter } from './search' | 13 | import { searchRouter } from './search' |
13 | import { overviewsRouter } from './overviews' | 14 | import { overviewsRouter } from './overviews' |
14 | import { videoPlaylistRouter } from './video-playlist' | 15 | import { videoPlaylistRouter } from './video-playlist' |
16 | import { CONFIG } from '../../initializers/config' | ||
15 | 17 | ||
16 | const apiRouter = express.Router() | 18 | const apiRouter = express.Router() |
17 | 19 | ||
@@ -21,6 +23,14 @@ apiRouter.use(cors({ | |||
21 | credentials: true | 23 | credentials: true |
22 | })) | 24 | })) |
23 | 25 | ||
26 | // FIXME: https://github.com/nfriedly/express-rate-limit/issues/138 | ||
27 | // @ts-ignore | ||
28 | const apiRateLimiter = RateLimit({ | ||
29 | windowMs: CONFIG.RATES_LIMIT.API.WINDOW_MS, | ||
30 | max: CONFIG.RATES_LIMIT.API.MAX | ||
31 | }) | ||
32 | apiRouter.use(apiRateLimiter) | ||
33 | |||
24 | apiRouter.use('/server', serverRouter) | 34 | apiRouter.use('/server', serverRouter) |
25 | apiRouter.use('/oauth-clients', oauthClientsRouter) | 35 | apiRouter.use('/oauth-clients', oauthClientsRouter) |
26 | apiRouter.use('/config', configRouter) | 36 | apiRouter.use('/config', configRouter) |
diff --git a/server/controllers/api/users/index.ts b/server/controllers/api/users/index.ts index c1d72087c..63747a0a9 100644 --- a/server/controllers/api/users/index.ts +++ b/server/controllers/api/users/index.ts | |||
@@ -3,7 +3,7 @@ import * as RateLimit from 'express-rate-limit' | |||
3 | import { UserCreate, UserRight, UserRole, UserUpdate } from '../../../../shared' | 3 | import { UserCreate, UserRight, UserRole, UserUpdate } from '../../../../shared' |
4 | import { logger } from '../../../helpers/logger' | 4 | import { logger } from '../../../helpers/logger' |
5 | import { getFormattedObjects } from '../../../helpers/utils' | 5 | import { getFormattedObjects } from '../../../helpers/utils' |
6 | import { RATES_LIMIT, WEBSERVER } from '../../../initializers/constants' | 6 | import { WEBSERVER } from '../../../initializers/constants' |
7 | import { Emailer } from '../../../lib/emailer' | 7 | import { Emailer } from '../../../lib/emailer' |
8 | import { Redis } from '../../../lib/redis' | 8 | import { Redis } from '../../../lib/redis' |
9 | import { createUserAccountAndChannelAndPlaylist, sendVerifyUserEmail } from '../../../lib/user' | 9 | import { createUserAccountAndChannelAndPlaylist, sendVerifyUserEmail } from '../../../lib/user' |
@@ -53,14 +53,21 @@ const auditLogger = auditLoggerFactory('users') | |||
53 | // FIXME: https://github.com/nfriedly/express-rate-limit/issues/138 | 53 | // FIXME: https://github.com/nfriedly/express-rate-limit/issues/138 |
54 | // @ts-ignore | 54 | // @ts-ignore |
55 | const loginRateLimiter = RateLimit({ | 55 | const loginRateLimiter = RateLimit({ |
56 | windowMs: RATES_LIMIT.LOGIN.WINDOW_MS, | 56 | windowMs: CONFIG.RATES_LIMIT.LOGIN.WINDOW_MS, |
57 | max: RATES_LIMIT.LOGIN.MAX | 57 | max: CONFIG.RATES_LIMIT.LOGIN.MAX |
58 | }) | ||
59 | |||
60 | // @ts-ignore | ||
61 | const signupRateLimiter = RateLimit({ | ||
62 | windowMs: CONFIG.RATES_LIMIT.SIGNUP.WINDOW_MS, | ||
63 | max: CONFIG.RATES_LIMIT.SIGNUP.MAX, | ||
64 | skipFailedRequests: true | ||
58 | }) | 65 | }) |
59 | 66 | ||
60 | // @ts-ignore | 67 | // @ts-ignore |
61 | const askSendEmailLimiter = new RateLimit({ | 68 | const askSendEmailLimiter = new RateLimit({ |
62 | windowMs: RATES_LIMIT.ASK_SEND_EMAIL.WINDOW_MS, | 69 | windowMs: CONFIG.RATES_LIMIT.ASK_SEND_EMAIL.WINDOW_MS, |
63 | max: RATES_LIMIT.ASK_SEND_EMAIL.MAX | 70 | max: CONFIG.RATES_LIMIT.ASK_SEND_EMAIL.MAX |
64 | }) | 71 | }) |
65 | 72 | ||
66 | const usersRouter = express.Router() | 73 | const usersRouter = express.Router() |
@@ -114,6 +121,7 @@ usersRouter.post('/', | |||
114 | ) | 121 | ) |
115 | 122 | ||
116 | usersRouter.post('/register', | 123 | usersRouter.post('/register', |
124 | signupRateLimiter, | ||
117 | asyncMiddleware(ensureUserRegistrationAllowed), | 125 | asyncMiddleware(ensureUserRegistrationAllowed), |
118 | ensureUserRegistrationAllowedForIP, | 126 | ensureUserRegistrationAllowedForIP, |
119 | asyncMiddleware(usersRegisterValidator), | 127 | asyncMiddleware(usersRegisterValidator), |