diff options
Diffstat (limited to 'server/controllers/api/plugins.ts')
-rw-r--r-- | server/controllers/api/plugins.ts | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/server/controllers/api/plugins.ts b/server/controllers/api/plugins.ts index e18eed332..b64062287 100644 --- a/server/controllers/api/plugins.ts +++ b/server/controllers/api/plugins.ts | |||
@@ -144,7 +144,7 @@ async function installPlugin (req: express.Request, res: express.Response) { | |||
144 | return res.json(plugin.toFormattedJSON()) | 144 | return res.json(plugin.toFormattedJSON()) |
145 | } catch (err) { | 145 | } catch (err) { |
146 | logger.warn('Cannot install plugin %s.', toInstall, { err }) | 146 | logger.warn('Cannot install plugin %s.', toInstall, { err }) |
147 | return res.sendStatus(HttpStatusCode.BAD_REQUEST_400) | 147 | return res.fail({ message: 'Cannot install plugin ' + toInstall }) |
148 | } | 148 | } |
149 | } | 149 | } |
150 | 150 | ||
@@ -159,7 +159,7 @@ async function updatePlugin (req: express.Request, res: express.Response) { | |||
159 | return res.json(plugin.toFormattedJSON()) | 159 | return res.json(plugin.toFormattedJSON()) |
160 | } catch (err) { | 160 | } catch (err) { |
161 | logger.warn('Cannot update plugin %s.', toUpdate, { err }) | 161 | logger.warn('Cannot update plugin %s.', toUpdate, { err }) |
162 | return res.sendStatus(HttpStatusCode.BAD_REQUEST_400) | 162 | return res.fail({ message: 'Cannot update plugin ' + toUpdate }) |
163 | } | 163 | } |
164 | } | 164 | } |
165 | 165 | ||
@@ -168,7 +168,7 @@ async function uninstallPlugin (req: express.Request, res: express.Response) { | |||
168 | 168 | ||
169 | await PluginManager.Instance.uninstall(body.npmName) | 169 | await PluginManager.Instance.uninstall(body.npmName) |
170 | 170 | ||
171 | return res.sendStatus(HttpStatusCode.NO_CONTENT_204) | 171 | return res.status(HttpStatusCode.NO_CONTENT_204).end() |
172 | } | 172 | } |
173 | 173 | ||
174 | function getPublicPluginSettings (req: express.Request, res: express.Response) { | 174 | function getPublicPluginSettings (req: express.Request, res: express.Response) { |
@@ -197,7 +197,7 @@ async function updatePluginSettings (req: express.Request, res: express.Response | |||
197 | 197 | ||
198 | await PluginManager.Instance.onSettingsChanged(plugin.name, plugin.settings) | 198 | await PluginManager.Instance.onSettingsChanged(plugin.name, plugin.settings) |
199 | 199 | ||
200 | return res.sendStatus(HttpStatusCode.NO_CONTENT_204) | 200 | return res.status(HttpStatusCode.NO_CONTENT_204).end() |
201 | } | 201 | } |
202 | 202 | ||
203 | async function listAvailablePlugins (req: express.Request, res: express.Response) { | 203 | async function listAvailablePlugins (req: express.Request, res: express.Response) { |
@@ -206,8 +206,10 @@ async function listAvailablePlugins (req: express.Request, res: express.Response | |||
206 | const resultList = await listAvailablePluginsFromIndex(query) | 206 | const resultList = await listAvailablePluginsFromIndex(query) |
207 | 207 | ||
208 | if (!resultList) { | 208 | if (!resultList) { |
209 | return res.status(HttpStatusCode.SERVICE_UNAVAILABLE_503) | 209 | return res.fail({ |
210 | .json({ error: 'Plugin index unavailable. Please retry later' }) | 210 | status: HttpStatusCode.SERVICE_UNAVAILABLE_503, |
211 | message: 'Plugin index unavailable. Please retry later' | ||
212 | }) | ||
211 | } | 213 | } |
212 | 214 | ||
213 | return res.json(resultList) | 215 | return res.json(resultList) |