diff options
-rwxr-xr-x | scripts/parse-log.ts | 2 | ||||
-rw-r--r-- | server/helpers/logger.ts | 40 |
2 files changed, 17 insertions, 25 deletions
diff --git a/scripts/parse-log.ts b/scripts/parse-log.ts index dccab0884..d22e90266 100755 --- a/scripts/parse-log.ts +++ b/scripts/parse-log.ts | |||
@@ -90,4 +90,4 @@ function getNewestFile (files: string[], basePath: string) { | |||
90 | out.sort((a, b) => b.mtime - a.mtime) | 90 | out.sort((a, b) => b.mtime - a.mtime) |
91 | 91 | ||
92 | return (out.length > 0) ? out[ 0 ].file : '' | 92 | return (out.length > 0) ? out[ 0 ].file : '' |
93 | } \ No newline at end of file | 93 | } |
diff --git a/server/helpers/logger.ts b/server/helpers/logger.ts index 7fdfe2125..6d369a8fb 100644 --- a/server/helpers/logger.ts +++ b/server/helpers/logger.ts | |||
@@ -9,36 +9,28 @@ const label = CONFIG.WEBSERVER.HOSTNAME + ':' + CONFIG.WEBSERVER.PORT | |||
9 | // Create the directory if it does not exist | 9 | // Create the directory if it does not exist |
10 | mkdirp.sync(CONFIG.STORAGE.LOG_DIR) | 10 | mkdirp.sync(CONFIG.STORAGE.LOG_DIR) |
11 | 11 | ||
12 | // Use object for better performances (~ O(1)) | 12 | function loggerReplacer (key: string, value: any) { |
13 | const excludedKeys = { | 13 | if (value instanceof Error) { |
14 | level: true, | 14 | const error = {} |
15 | message: true, | 15 | |
16 | splat: true, | 16 | Object.getOwnPropertyNames(value).forEach(key => error[ key ] = value[ key ]) |
17 | timestamp: true, | ||
18 | label: true | ||
19 | } | ||
20 | function keysExcluder (key, value) { | ||
21 | if (excludedKeys[key] === true) return undefined | ||
22 | 17 | ||
23 | if (key === 'err') return value.stack | 18 | return error |
19 | } | ||
24 | 20 | ||
25 | return value | 21 | return value |
26 | } | 22 | } |
27 | 23 | ||
28 | const consoleLoggerFormat = winston.format.printf(info => { | 24 | const consoleLoggerFormat = winston.format.printf(info => { |
29 | let additionalInfos = JSON.stringify(info, keysExcluder, 2) | 25 | let additionalInfos = JSON.stringify(info.meta, loggerReplacer, 2) |
30 | if (additionalInfos === '{}') additionalInfos = '' | 26 | if (additionalInfos === undefined || additionalInfos === '{}') additionalInfos = '' |
31 | else additionalInfos = ' ' + additionalInfos | 27 | else additionalInfos = ' ' + additionalInfos |
32 | 28 | ||
33 | return `[${info.label}] ${info.timestamp} ${info.level}: ${info.message}${additionalInfos}` | 29 | return `[${info.label}] ${info.timestamp} ${info.level}: ${info.message}${additionalInfos}` |
34 | }) | 30 | }) |
35 | 31 | ||
36 | const jsonLoggerFormat = winston.format.printf(infoArg => { | 32 | const jsonLoggerFormat = winston.format.printf(info => { |
37 | let info = infoArg.err | 33 | return JSON.stringify(info, loggerReplacer) |
38 | ? Object.assign({}, infoArg, { err: infoArg.err.stack }) | ||
39 | : infoArg | ||
40 | |||
41 | return JSON.stringify(info) | ||
42 | }) | 34 | }) |
43 | 35 | ||
44 | const timestampFormatter = winston.format.timestamp({ | 36 | const timestampFormatter = winston.format.timestamp({ |
@@ -50,16 +42,18 @@ const labelFormatter = winston.format.label({ | |||
50 | 42 | ||
51 | const logger = winston.createLogger({ | 43 | const logger = winston.createLogger({ |
52 | level: CONFIG.LOG.LEVEL, | 44 | level: CONFIG.LOG.LEVEL, |
45 | format: winston.format.combine( | ||
46 | labelFormatter, | ||
47 | winston.format.splat() | ||
48 | ), | ||
53 | transports: [ | 49 | transports: [ |
54 | new winston.transports.File({ | 50 | new winston.transports.File({ |
55 | filename: path.join(CONFIG.STORAGE.LOG_DIR, 'peertube.log'), | 51 | filename: path.join(CONFIG.STORAGE.LOG_DIR, 'peertube.log'), |
56 | handleExceptions: true, | 52 | handleExceptions: true, |
57 | maxsize: 5242880, | 53 | maxsize: 1024 * 1024 * 30, |
58 | maxFiles: 5, | 54 | maxFiles: 5, |
59 | format: winston.format.combine( | 55 | format: winston.format.combine( |
60 | winston.format.timestamp(), | 56 | winston.format.timestamp(), |
61 | labelFormatter, | ||
62 | winston.format.splat(), | ||
63 | jsonLoggerFormat | 57 | jsonLoggerFormat |
64 | ) | 58 | ) |
65 | }), | 59 | }), |
@@ -67,8 +61,6 @@ const logger = winston.createLogger({ | |||
67 | handleExceptions: true, | 61 | handleExceptions: true, |
68 | format: winston.format.combine( | 62 | format: winston.format.combine( |
69 | timestampFormatter, | 63 | timestampFormatter, |
70 | winston.format.splat(), | ||
71 | labelFormatter, | ||
72 | winston.format.colorize(), | 64 | winston.format.colorize(), |
73 | consoleLoggerFormat | 65 | consoleLoggerFormat |
74 | ) | 66 | ) |