diff options
-rwxr-xr-x | scripts/parse-log.ts | 2 | ||||
-rw-r--r-- | server/controllers/api/users.ts | 22 | ||||
-rw-r--r-- | server/initializers/installer.ts | 6 | ||||
-rw-r--r-- | server/lib/user.ts | 22 | ||||
-rw-r--r-- | server/lib/video-channel.ts | 4 | ||||
-rw-r--r-- | server/models/account/account.ts | 2 | ||||
-rw-r--r-- | server/tests/api/config.ts | 10 | ||||
-rw-r--r-- | server/tests/utils/index.ts | 2 |
8 files changed, 44 insertions, 26 deletions
diff --git a/scripts/parse-log.ts b/scripts/parse-log.ts index 81a22f7a0..8aac6fbda 100755 --- a/scripts/parse-log.ts +++ b/scripts/parse-log.ts | |||
@@ -38,5 +38,5 @@ const rl = createInterface({ | |||
38 | 38 | ||
39 | rl.on('line', line => { | 39 | rl.on('line', line => { |
40 | const log = JSON.parse(line) | 40 | const log = JSON.parse(line) |
41 | logLevels[log.level](log.message) | 41 | logLevels[log.level](log.message, log.stack) |
42 | }) | 42 | }) |
diff --git a/server/controllers/api/users.ts b/server/controllers/api/users.ts index 41ffb64cb..ac7c87517 100644 --- a/server/controllers/api/users.ts +++ b/server/controllers/api/users.ts | |||
@@ -70,7 +70,7 @@ usersRouter.post('/', | |||
70 | usersRouter.post('/register', | 70 | usersRouter.post('/register', |
71 | ensureUserRegistrationAllowed, | 71 | ensureUserRegistrationAllowed, |
72 | usersRegisterValidator, | 72 | usersRegisterValidator, |
73 | asyncMiddleware(registerUser) | 73 | asyncMiddleware(registerUserRetryWrapper) |
74 | ) | 74 | ) |
75 | 75 | ||
76 | usersRouter.put('/me', | 76 | usersRouter.put('/me', |
@@ -113,7 +113,7 @@ async function getUserVideos (req: express.Request, res: express.Response, next: | |||
113 | 113 | ||
114 | async function createUserRetryWrapper (req: express.Request, res: express.Response, next: express.NextFunction) { | 114 | async function createUserRetryWrapper (req: express.Request, res: express.Response, next: express.NextFunction) { |
115 | const options = { | 115 | const options = { |
116 | arguments: [ req, res ], | 116 | arguments: [ req ], |
117 | errorMessage: 'Cannot insert the user with many retries.' | 117 | errorMessage: 'Cannot insert the user with many retries.' |
118 | } | 118 | } |
119 | 119 | ||
@@ -123,7 +123,7 @@ async function createUserRetryWrapper (req: express.Request, res: express.Respon | |||
123 | return res.type('json').status(204).end() | 123 | return res.type('json').status(204).end() |
124 | } | 124 | } |
125 | 125 | ||
126 | async function createUser (req: express.Request, res: express.Response, next: express.NextFunction) { | 126 | async function createUser (req: express.Request) { |
127 | const body: UserCreate = req.body | 127 | const body: UserCreate = req.body |
128 | const user = db.User.build({ | 128 | const user = db.User.build({ |
129 | username: body.username, | 129 | username: body.username, |
@@ -139,7 +139,18 @@ async function createUser (req: express.Request, res: express.Response, next: ex | |||
139 | logger.info('User %s with its channel and account created.', body.username) | 139 | logger.info('User %s with its channel and account created.', body.username) |
140 | } | 140 | } |
141 | 141 | ||
142 | async function registerUser (req: express.Request, res: express.Response, next: express.NextFunction) { | 142 | async function registerUserRetryWrapper (req: express.Request, res: express.Response, next: express.NextFunction) { |
143 | const options = { | ||
144 | arguments: [ req ], | ||
145 | errorMessage: 'Cannot insert the user with many retries.' | ||
146 | } | ||
147 | |||
148 | await retryTransactionWrapper(registerUser, options) | ||
149 | |||
150 | return res.type('json').status(204).end() | ||
151 | } | ||
152 | |||
153 | async function registerUser (req: express.Request) { | ||
143 | const body: UserCreate = req.body | 154 | const body: UserCreate = req.body |
144 | 155 | ||
145 | const user = db.User.build({ | 156 | const user = db.User.build({ |
@@ -152,7 +163,8 @@ async function registerUser (req: express.Request, res: express.Response, next: | |||
152 | }) | 163 | }) |
153 | 164 | ||
154 | await createUserAccountAndChannel(user) | 165 | await createUserAccountAndChannel(user) |
155 | return res.type('json').status(204).end() | 166 | |
167 | logger.info('User %s with its channel and account registered.', body.username) | ||
156 | } | 168 | } |
157 | 169 | ||
158 | async function getUserInformation (req: express.Request, res: express.Response, next: express.NextFunction) { | 170 | async function getUserInformation (req: express.Request, res: express.Response, next: express.NextFunction) { |
diff --git a/server/initializers/installer.ts b/server/initializers/installer.ts index 3f4c4dfbb..865495722 100644 --- a/server/initializers/installer.ts +++ b/server/initializers/installer.ts | |||
@@ -2,10 +2,9 @@ import * as passwordGenerator from 'password-generator' | |||
2 | import { UserRole } from '../../shared' | 2 | import { UserRole } from '../../shared' |
3 | import { logger, mkdirpPromise, rimrafPromise } from '../helpers' | 3 | import { logger, mkdirpPromise, rimrafPromise } from '../helpers' |
4 | import { createUserAccountAndChannel } from '../lib' | 4 | import { createUserAccountAndChannel } from '../lib' |
5 | import { createLocalAccount } from '../lib/user' | 5 | import { createLocalAccountWithoutKeys } from '../lib/user' |
6 | import { applicationExist, clientsExist, usersExist } from './checker' | 6 | import { applicationExist, clientsExist, usersExist } from './checker' |
7 | import { CACHE, CONFIG, LAST_MIGRATION_VERSION, SERVER_ACCOUNT_NAME } from './constants' | 7 | import { CACHE, CONFIG, LAST_MIGRATION_VERSION, SERVER_ACCOUNT_NAME } from './constants' |
8 | |||
9 | import { database as db } from './database' | 8 | import { database as db } from './database' |
10 | 9 | ||
11 | async function installApplication () { | 10 | async function installApplication () { |
@@ -136,5 +135,6 @@ async function createApplicationIfNotExist () { | |||
136 | const applicationInstance = await db.Application.create({ migrationVersion: LAST_MIGRATION_VERSION }) | 135 | const applicationInstance = await db.Application.create({ migrationVersion: LAST_MIGRATION_VERSION }) |
137 | 136 | ||
138 | logger.info('Creating application account.') | 137 | logger.info('Creating application account.') |
139 | return createLocalAccount(SERVER_ACCOUNT_NAME, null, applicationInstance.id, undefined) | 138 | |
139 | return createLocalAccountWithoutKeys(SERVER_ACCOUNT_NAME, null, applicationInstance.id, undefined) | ||
140 | } | 140 | } |
diff --git a/server/lib/user.ts b/server/lib/user.ts index 9884e566f..2d7b36b4f 100644 --- a/server/lib/user.ts +++ b/server/lib/user.ts | |||
@@ -5,16 +5,17 @@ import { database as db } from '../initializers' | |||
5 | import { CONFIG } from '../initializers/constants' | 5 | import { CONFIG } from '../initializers/constants' |
6 | import { UserInstance } from '../models' | 6 | import { UserInstance } from '../models' |
7 | import { createVideoChannel } from './video-channel' | 7 | import { createVideoChannel } from './video-channel' |
8 | import { logger } from '../helpers/logger' | ||
8 | 9 | ||
9 | async function createUserAccountAndChannel (user: UserInstance, validateUser = true) { | 10 | async function createUserAccountAndChannel (user: UserInstance, validateUser = true) { |
10 | const res = await db.sequelize.transaction(async t => { | 11 | const { account, videoChannel } = await db.sequelize.transaction(async t => { |
11 | const userOptions = { | 12 | const userOptions = { |
12 | transaction: t, | 13 | transaction: t, |
13 | validate: validateUser | 14 | validate: validateUser |
14 | } | 15 | } |
15 | 16 | ||
16 | const userCreated = await user.save(userOptions) | 17 | const userCreated = await user.save(userOptions) |
17 | const accountCreated = await createLocalAccount(user.username, user.id, null, t) | 18 | const accountCreated = await createLocalAccountWithoutKeys(user.username, user.id, null, t) |
18 | 19 | ||
19 | const videoChannelName = `Default ${userCreated.username} channel` | 20 | const videoChannelName = `Default ${userCreated.username} channel` |
20 | const videoChannelInfo = { | 21 | const videoChannelInfo = { |
@@ -25,18 +26,23 @@ async function createUserAccountAndChannel (user: UserInstance, validateUser = t | |||
25 | return { account: accountCreated, videoChannel } | 26 | return { account: accountCreated, videoChannel } |
26 | }) | 27 | }) |
27 | 28 | ||
28 | return res | 29 | // Set account keys, this could be long so process after the account creation and do not block the client |
30 | const { publicKey, privateKey } = await createPrivateAndPublicKeys() | ||
31 | account.set('publicKey', publicKey) | ||
32 | account.set('privateKey', privateKey) | ||
33 | account.save().catch(err => logger.error('Cannot set public/private keys of local account %d.', account.id, err)) | ||
34 | |||
35 | return { account, videoChannel } | ||
29 | } | 36 | } |
30 | 37 | ||
31 | async function createLocalAccount (name: string, userId: number, applicationId: number, t: Sequelize.Transaction) { | 38 | async function createLocalAccountWithoutKeys (name: string, userId: number, applicationId: number, t: Sequelize.Transaction) { |
32 | const { publicKey, privateKey } = await createPrivateAndPublicKeys() | ||
33 | const url = getActivityPubUrl('account', name) | 39 | const url = getActivityPubUrl('account', name) |
34 | 40 | ||
35 | const accountInstance = db.Account.build({ | 41 | const accountInstance = db.Account.build({ |
36 | name, | 42 | name, |
37 | url, | 43 | url, |
38 | publicKey, | 44 | publicKey: null, |
39 | privateKey, | 45 | privateKey: null, |
40 | followersCount: 0, | 46 | followersCount: 0, |
41 | followingCount: 0, | 47 | followingCount: 0, |
42 | inboxUrl: url + '/inbox', | 48 | inboxUrl: url + '/inbox', |
@@ -56,5 +62,5 @@ async function createLocalAccount (name: string, userId: number, applicationId: | |||
56 | 62 | ||
57 | export { | 63 | export { |
58 | createUserAccountAndChannel, | 64 | createUserAccountAndChannel, |
59 | createLocalAccount | 65 | createLocalAccountWithoutKeys |
60 | } | 66 | } |
diff --git a/server/lib/video-channel.ts b/server/lib/video-channel.ts index e69ec062f..6f9ae2d95 100644 --- a/server/lib/video-channel.ts +++ b/server/lib/video-channel.ts | |||
@@ -25,9 +25,7 @@ async function createVideoChannel (videoChannelInfo: VideoChannelCreate, account | |||
25 | // Do not forget to add Account information to the created video channel | 25 | // Do not forget to add Account information to the created video channel |
26 | videoChannelCreated.Account = account | 26 | videoChannelCreated.Account = account |
27 | 27 | ||
28 | await sendCreateVideoChannel(videoChannelCreated, t) | 28 | // No need to seed this empty video channel to followers |
29 | await shareVideoChannelByServer(videoChannelCreated, t) | ||
30 | |||
31 | return videoChannelCreated | 29 | return videoChannelCreated |
32 | } | 30 | } |
33 | 31 | ||
diff --git a/server/models/account/account.ts b/server/models/account/account.ts index 84461a2eb..c370e1709 100644 --- a/server/models/account/account.ts +++ b/server/models/account/account.ts | |||
@@ -75,7 +75,7 @@ export default function defineAccount (sequelize: Sequelize.Sequelize, DataTypes | |||
75 | }, | 75 | }, |
76 | publicKey: { | 76 | publicKey: { |
77 | type: DataTypes.STRING(CONSTRAINTS_FIELDS.ACCOUNTS.PUBLIC_KEY.max), | 77 | type: DataTypes.STRING(CONSTRAINTS_FIELDS.ACCOUNTS.PUBLIC_KEY.max), |
78 | allowNull: false, | 78 | allowNull: true, |
79 | validate: { | 79 | validate: { |
80 | publicKeyValid: value => { | 80 | publicKeyValid: value => { |
81 | const res = isAccountPublicKeyValid(value) | 81 | const res = isAccountPublicKeyValid(value) |
diff --git a/server/tests/api/config.ts b/server/tests/api/config.ts index 3dda3b4d7..72a9e5679 100644 --- a/server/tests/api/config.ts +++ b/server/tests/api/config.ts | |||
@@ -15,7 +15,7 @@ describe('Test config', function () { | |||
15 | let server = null | 15 | let server = null |
16 | 16 | ||
17 | before(async function () { | 17 | before(async function () { |
18 | this.timeout(120000) | 18 | this.timeout(10000) |
19 | 19 | ||
20 | await flushTests() | 20 | await flushTests() |
21 | server = await runServer(1) | 21 | server = await runServer(1) |
@@ -29,9 +29,11 @@ describe('Test config', function () { | |||
29 | }) | 29 | }) |
30 | 30 | ||
31 | it('Should have a correct config on a server with registration enabled and a users limit', async function () { | 31 | it('Should have a correct config on a server with registration enabled and a users limit', async function () { |
32 | await registerUser(server.url, 'user1', 'super password') | 32 | await Promise.all([ |
33 | await registerUser(server.url, 'user2', 'super password') | 33 | registerUser(server.url, 'user1', 'super password'), |
34 | await registerUser(server.url, 'user3', 'super password') | 34 | registerUser(server.url, 'user2', 'super password'), |
35 | registerUser(server.url, 'user3', 'super password') | ||
36 | ]) | ||
35 | 37 | ||
36 | const res = await getConfig(server.url) | 38 | const res = await getConfig(server.url) |
37 | const data = res.body | 39 | const data = res.body |
diff --git a/server/tests/utils/index.ts b/server/tests/utils/index.ts index 4325e4c94..fe6d3b041 100644 --- a/server/tests/utils/index.ts +++ b/server/tests/utils/index.ts | |||
@@ -3,7 +3,7 @@ export * from './clients' | |||
3 | export * from './config' | 3 | export * from './config' |
4 | export * from './login' | 4 | export * from './login' |
5 | export * from './miscs' | 5 | export * from './miscs' |
6 | export * from './pods' | 6 | export * from './follows' |
7 | export * from './request-schedulers' | 7 | export * from './request-schedulers' |
8 | export * from './requests' | 8 | export * from './requests' |
9 | export * from './servers' | 9 | export * from './servers' |