replace numbers with typed http status codes (#3409)

2 files changed, 8 insertions, 6 deletions

diff --git a/shared/extra-utils/search/video-channels.ts b/shared/extra-utils/search/video-channels.ts
index d16210530..8e0f42578 100644
--- a/shared/extra-utils/search/video-channels.ts
+++ b/shared/extra-utils/search/video-channels.ts
@@ -1,7 +1,8 @@
 import { VideoChannelsSearchQuery } from '@shared/models'
 import { makeGetRequest } from '../requests/requests'
+import { HttpStatusCode } from '../../../shared/core-utils/miscs/http-error-codes'
 
-function searchVideoChannel (url: string, search: string, token?: string, statusCodeExpected = 200) {
+function searchVideoChannel (url: string, search: string, token?: string, statusCodeExpected = HttpStatusCode.OK_200) {
   const path = '/api/v1/search/video-channels'
 
   return makeGetRequest({
@@ -23,7 +24,7 @@ function advancedVideoChannelSearch (url: string, search: VideoChannelsSearchQue
     url,
     path,
     query: search,
-    statusCodeExpected: 200
+    statusCodeExpected: HttpStatusCode.OK_200
   })
 }
 
diff --git a/shared/extra-utils/search/videos.ts b/shared/extra-utils/search/videos.ts
index 4c52ea11c..ac65357e3 100644
--- a/shared/extra-utils/search/videos.ts
+++ b/shared/extra-utils/search/videos.ts
@@ -3,6 +3,7 @@
 import * as request from 'supertest'
 import { VideosSearchQuery } from '../../models/search'
 import { immutableAssign } from '../miscs/miscs'
+import { HttpStatusCode } from '../../../shared/core-utils/miscs/http-error-codes'
 
 function searchVideo (url: string, search: string) {
   const path = '/api/v1/search/videos'
@@ -13,7 +14,7 @@ function searchVideo (url: string, search: string) {
     .query(query)
     .set('Accept', 'application/json')
 
-  return req.expect(200)
+  return req.expect(HttpStatusCode.OK_200)
             .expect('Content-Type', /json/)
 }
 
@@ -25,7 +26,7 @@ function searchVideoWithToken (url: string, search: string, token: string, query
     .query(immutableAssign(query, { sort: '-publishedAt', search }))
     .set('Accept', 'application/json')
 
-  return req.expect(200)
+  return req.expect(HttpStatusCode.OK_200)
             .expect('Content-Type', /json/)
 }
 
@@ -38,7 +39,7 @@ function searchVideoWithSort (url: string, search: string, sort: string) {
     .get(path)
     .query(query)
     .set('Accept', 'application/json')
-    .expect(200)
+    .expect(HttpStatusCode.OK_200)
     .expect('Content-Type', /json/)
 }
 
@@ -49,7 +50,7 @@ function advancedVideosSearch (url: string, options: VideosSearchQuery) {
     .get(path)
     .query(options)
     .set('Accept', 'application/json')
-    .expect(200)
+    .expect(HttpStatusCode.OK_200)
     .expect('Content-Type', /json/)
 }