Refactor requests

1 files changed, 100 insertions, 156 deletions

diff --git a/shared/extra-utils/requests/requests.ts b/shared/extra-utils/requests/requests.ts
index 60c9b938b..70f790222 100644
--- a/shared/extra-utils/requests/requests.ts
+++ b/shared/extra-utils/requests/requests.ts
@@ -1,111 +1,82 @@
-/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/no-floating-promises */
+/* eslint-disable @typescript-eslint/no-floating-promises */
 
-import { isAbsolute, join } from 'path'
 import { decode } from 'querystring'
 import * as request from 'supertest'
 import { URL } from 'url'
-import { HttpStatusCode } from '@shared/core-utils'
-import { buildAbsoluteFixturePath, root } from '../miscs/tests'
+import { HttpStatusCode } from '@shared/models'
+import { buildAbsoluteFixturePath } from '../miscs/tests'
 
-function makeRawRequest (url: string, statusCodeExpected?: HttpStatusCode, range?: string) {
-  const { host, protocol, pathname } = new URL(url)
-
-  return makeGetRequest({ url: `${protocol}//${host}`, path: pathname, statusCodeExpected, range })
-}
-
-function makeGetRequest (options: {
+export type CommonRequestParams = {
   url: string
   path?: string
-  query?: any
-  token?: string
-  statusCodeExpected?: HttpStatusCode
   contentType?: string
   range?: string
   redirects?: number
   accept?: string
   host?: string
-}) {
-  if (!options.statusCodeExpected) options.statusCodeExpected = HttpStatusCode.BAD_REQUEST_400
-  if (options.contentType === undefined) options.contentType = 'application/json'
-
-  const req = request(options.url).get(options.path)
+  token?: string
+  headers?: { [ name: string ]: string }
+  type?: string
+  xForwardedFor?: string
+  expectedStatus?: HttpStatusCode
+}
 
-  if (options.contentType) req.set('Accept', options.contentType)
-  if (options.token) req.set('Authorization', 'Bearer ' + options.token)
-  if (options.query) req.query(options.query)
-  if (options.range) req.set('Range', options.range)
-  if (options.accept) req.set('Accept', options.accept)
-  if (options.host) req.set('Host', options.host)
-  if (options.redirects) req.redirects(options.redirects)
+function makeRawRequest (url: string, expectedStatus?: HttpStatusCode, range?: string) {
+  const { host, protocol, pathname } = new URL(url)
 
-  return req.expect(options.statusCodeExpected)
+  return makeGetRequest({ url: `${protocol}//${host}`, path: pathname, expectedStatus, range })
 }
 
-function makeDeleteRequest (options: {
-  url: string
-  path: string
-  token?: string
-  statusCodeExpected?: HttpStatusCode
+function makeGetRequest (options: CommonRequestParams & {
+  query?: any
 }) {
-  if (!options.statusCodeExpected) options.statusCodeExpected = HttpStatusCode.BAD_REQUEST_400
+  const req = request(options.url).get(options.path)
+                                  .query(options.query)
 
-  const req = request(options.url)
-    .delete(options.path)
-    .set('Accept', 'application/json')
+  return buildRequest(req, { contentType: 'application/json', expectedStatus: HttpStatusCode.BAD_REQUEST_400, ...options })
+}
 
-  if (options.token) req.set('Authorization', 'Bearer ' + options.token)
+function makeHTMLRequest (url: string, path: string) {
+  return makeGetRequest({
+    url,
+    path,
+    accept: 'text/html',
+    expectedStatus: HttpStatusCode.OK_200
+  })
+}
 
-  return req.expect(options.statusCodeExpected)
+function makeActivityPubGetRequest (url: string, path: string, expectedStatus = HttpStatusCode.OK_200) {
+  return makeGetRequest({
+    url,
+    path,
+    expectedStatus: expectedStatus,
+    accept: 'application/activity+json,text/html;q=0.9,\\*/\\*;q=0.8'
+  })
 }
 
-function makeUploadRequest (options: {
-  url: string
+function makeDeleteRequest (options: CommonRequestParams) {
+  const req = request(options.url).delete(options.path)
+
+  return buildRequest(req, { accept: 'application/json', expectedStatus: HttpStatusCode.BAD_REQUEST_400, ...options })
+}
+
+function makeUploadRequest (options: CommonRequestParams & {
   method?: 'POST' | 'PUT'
-  path: string
-  token?: string
 
   fields: { [ fieldName: string ]: any }
   attaches?: { [ attachName: string ]: any | any[] }
-
-  headers?: { [ name: string ]: string }
-
-  statusCodeExpected?: HttpStatusCode
 }) {
-  if (options.statusCodeExpected === undefined) {
-    options.statusCodeExpected = HttpStatusCode.BAD_REQUEST_400
-  }
+  let req = options.method === 'PUT'
+    ? request(options.url).put(options.path)
+    : request(options.url).post(options.path)
 
-  let req: request.Test
-  if (options.method === 'PUT') {
-    req = request(options.url).put(options.path)
-  } else {
-    req = request(options.url).post(options.path)
-  }
+  req = buildRequest(req, { accept: 'application/json', expectedStatus: HttpStatusCode.BAD_REQUEST_400, ...options })
 
-  req.set('Accept', 'application/json')
-
-  if (options.token) req.set('Authorization', 'Bearer ' + options.token)
-
-  Object.keys(options.headers || {}).forEach(name => {
-    req.set(name, options.headers[name])
-  })
-
-  Object.keys(options.fields).forEach(field => {
-    const value = options.fields[field]
-
-    if (value === undefined) return
-
-    if (Array.isArray(value)) {
-      for (let i = 0; i < value.length; i++) {
-        req.field(field + '[' + i + ']', value[i])
-      }
-    } else {
-      req.field(field, value)
-    }
-  })
+  buildFields(req, options.fields)
 
   Object.keys(options.attaches || {}).forEach(attach => {
     const value = options.attaches[attach]
+
     if (Array.isArray(value)) {
       req.attach(attach, buildAbsoluteFixturePath(value[0]), value[1])
     } else {
@@ -113,40 +84,16 @@ function makeUploadRequest (options: {
     }
   })
 
-  if (options.statusCodeExpected) {
-    req.expect(options.statusCodeExpected)
-  }
-
   return req
 }
 
-function makePostBodyRequest (options: {
-  url: string
-  path: string
-  token?: string
+function makePostBodyRequest (options: CommonRequestParams & {
   fields?: { [ fieldName: string ]: any }
-  headers?: { [ name: string ]: string }
-  type?: string
-  xForwardedFor?: string
-  statusCodeExpected?: HttpStatusCode
 }) {
-  if (!options.fields) options.fields = {}
-  if (!options.statusCodeExpected) options.statusCodeExpected = HttpStatusCode.BAD_REQUEST_400
-
-  const req = request(options.url)
-                .post(options.path)
-                .set('Accept', 'application/json')
+  const req = request(options.url).post(options.path)
+                                  .send(options.fields)
 
-  if (options.token) req.set('Authorization', 'Bearer ' + options.token)
-  if (options.xForwardedFor) req.set('X-Forwarded-For', options.xForwardedFor)
-  if (options.type) req.type(options.type)
-
-  Object.keys(options.headers || {}).forEach(name => {
-    req.set(name, options.headers[name])
-  })
-
-  return req.send(options.fields)
-            .expect(options.statusCodeExpected)
+  return buildRequest(req, { accept: 'application/json', expectedStatus: HttpStatusCode.BAD_REQUEST_400, ...options })
 }
 
 function makePutBodyRequest (options: {
@@ -154,58 +101,12 @@ function makePutBodyRequest (options: {
   path: string
   token?: string
   fields: { [ fieldName: string ]: any }
-  statusCodeExpected?: HttpStatusCode
-}) {
-  if (!options.statusCodeExpected) options.statusCodeExpected = HttpStatusCode.BAD_REQUEST_400
-
-  const req = request(options.url)
-                .put(options.path)
-                .set('Accept', 'application/json')
-
-  if (options.token) req.set('Authorization', 'Bearer ' + options.token)
-
-  return req.send(options.fields)
-            .expect(options.statusCodeExpected)
-}
-
-function makeHTMLRequest (url: string, path: string) {
-  return request(url)
-    .get(path)
-    .set('Accept', 'text/html')
-    .expect(HttpStatusCode.OK_200)
-}
-
-function makeActivityPubGetRequest (url: string, path: string, expectedStatus = HttpStatusCode.OK_200) {
-  return makeGetRequest({
-    url,
-    path,
-    statusCodeExpected: expectedStatus,
-    accept: 'application/activity+json,text/html;q=0.9,\\*/\\*;q=0.8'
-  })
-}
-
-function updateImageRequest (options: {
-  url: string
-  path: string
-  accessToken: string
-  fixture: string
-  fieldname: string
+  expectedStatus?: HttpStatusCode
 }) {
-  let filePath = ''
-  if (isAbsolute(options.fixture)) {
-    filePath = options.fixture
-  } else {
-    filePath = join(root(), 'server', 'tests', 'fixtures', options.fixture)
-  }
+  const req = request(options.url).put(options.path)
+                                  .send(options.fields)
 
-  return makeUploadRequest({
-    url: options.url,
-    path: options.path,
-    token: options.accessToken,
-    fields: {},
-    attaches: { [options.fieldname]: filePath },
-    statusCodeExpected: HttpStatusCode.OK_200
-  })
+  return buildRequest(req, { accept: 'application/json', expectedStatus: HttpStatusCode.BAD_REQUEST_400, ...options })
 }
 
 function decodeQueryString (path: string) {
@@ -233,6 +134,49 @@ export {
   makeRawRequest,
   makeActivityPubGetRequest,
   unwrapBody,
-  unwrapText,
-  updateImageRequest
+  unwrapText
+}
+
+// ---------------------------------------------------------------------------
+
+function buildRequest (req: request.Test, options: CommonRequestParams) {
+  if (options.contentType) req.set('Accept', options.contentType)
+  if (options.token) req.set('Authorization', 'Bearer ' + options.token)
+  if (options.range) req.set('Range', options.range)
+  if (options.accept) req.set('Accept', options.accept)
+  if (options.host) req.set('Host', options.host)
+  if (options.redirects) req.redirects(options.redirects)
+  if (options.expectedStatus) req.expect(options.expectedStatus)
+  if (options.xForwardedFor) req.set('X-Forwarded-For', options.xForwardedFor)
+  if (options.type) req.type(options.type)
+
+  Object.keys(options.headers || {}).forEach(name => {
+    req.set(name, options.headers[name])
+  })
+
+  return req
+}
+
+function buildFields (req: request.Test, fields: { [ fieldName: string ]: any }, namespace?: string) {
+  if (!fields) return
+
+  let formKey: string
+
+  for (const key of Object.keys(fields)) {
+    if (namespace) formKey = `${namespace}[${key}]`
+    else formKey = key
+
+    if (fields[key] === undefined) continue
+
+    if (Array.isArray(fields[key]) && fields[key].length === 0) {
+      req.field(key, null)
+      continue
+    }
+
+    if (fields[key] !== null && typeof fields[key] === 'object') {
+      buildFields(req, fields[key], formKey)
+    } else {
+      req.field(formKey, fields[key])
+    }
+  }
 }