Optimize remote image processing

2 files changed, 60 insertions, 0 deletions

diff --git a/server/tests/helpers/image.ts b/server/tests/helpers/image.ts
new file mode 100644
index 000000000..54911697f
--- /dev/null
+++ b/server/tests/helpers/image.ts
@@ -0,0 +1,59 @@
+/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */
+
+import 'mocha'
+import { readFile, remove } from 'fs-extra'
+import { join } from 'path'
+import { processImage } from '../../../server/helpers/image-utils'
+import { buildAbsoluteFixturePath, root } from '../../../shared/extra-utils'
+import { expect } from 'chai'
+
+async function checkBuffers (path1: string, path2: string, equals: boolean) {
+  const [ buf1, buf2 ] = await Promise.all([
+    readFile(path1),
+    readFile(path2)
+  ])
+
+  if (equals) {
+    expect(buf1.equals(buf2)).to.be.true
+  } else {
+    expect(buf1.equals(buf2)).to.be.false
+  }
+}
+
+describe('Image helpers', function () {
+  const imageDestDir = join(root(), 'test-images')
+  const imageDest = join(imageDestDir, 'test.jpg')
+  const thumbnailSize = { width: 223, height: 122 }
+
+  it('Should skip processing if the source image is okay', async function () {
+    const input = buildAbsoluteFixturePath('thumbnail.jpg')
+    await processImage(input, imageDest, thumbnailSize, true)
+
+    await checkBuffers(input, imageDest, true)
+  })
+
+  it('Should not skip processing if the source image does not have the appropriate extension', async function () {
+    const input = buildAbsoluteFixturePath('thumbnail.png')
+    await processImage(input, imageDest, thumbnailSize, true)
+
+    await checkBuffers(input, imageDest, false)
+  })
+
+  it('Should not skip processing if the source image does not have the appropriate size', async function () {
+    const input = buildAbsoluteFixturePath('preview.jpg')
+    await processImage(input, imageDest, thumbnailSize, true)
+
+    await checkBuffers(input, imageDest, false)
+  })
+
+  it('Should not skip processing if the source image does not have the appropriate size', async function () {
+    const input = buildAbsoluteFixturePath('thumbnail-big.jpg')
+    await processImage(input, imageDest, thumbnailSize, true)
+
+    await checkBuffers(input, imageDest, false)
+  })
+
+  after(async function () {
+    await remove(imageDest)
+  })
+})
diff --git a/server/tests/helpers/index.ts b/server/tests/helpers/index.ts
index 03b971770..66db93c99 100644
--- a/server/tests/helpers/index.ts
+++ b/server/tests/helpers/index.ts
@@ -1,3 +1,4 @@
+import './image'
 import './core-utils'
 import './comment-model'
 import './request'