diff options
author | Theodore R. Smith <theodore@phpexperts.pro> | 2020-12-27 09:13:11 -0600 |
---|---|---|
committer | Theodore R. Smith <theodore@phpexperts.pro> | 2020-12-27 14:29:54 -0600 |
commit | 8e76aa1d75aebdadd0451d2e57c9bb65d1e75b9a (patch) | |
tree | 3b9809e75c8e8f9044080182801f4516a11fe242 /server/tests/cli | |
parent | f88453e2335ec9140df927d3cca727d2a3a4ab70 (diff) | |
download | PeerTube-8e76aa1d75aebdadd0451d2e57c9bb65d1e75b9a.tar.gz PeerTube-8e76aa1d75aebdadd0451d2e57c9bb65d1e75b9a.tar.zst PeerTube-8e76aa1d75aebdadd0451d2e57c9bb65d1e75b9a.zip |
(#3520) [cli] Hardened `auth add`: No longer fails with extraneous characters.
**The Solution:**
I have hardened `auth add` by stripping out everything from the third '/' to the end of the instance URL.
**The Problem:**
When adding an authorization for the peertube-cli, before this commit you could not have anything after the domain_name:port.
For instance, if there was a trailing / in your instance URL, before this commit it will always fail with
expected 200 "OK", got 404 "Not Found".
It took me over 20 minutes to figure out that this was the problem.
See Issue #3091.
Diffstat (limited to 'server/tests/cli')
-rw-r--r-- | server/tests/cli/peertube.ts | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/server/tests/cli/peertube.ts b/server/tests/cli/peertube.ts index 348438533..fcf7e2e2e 100644 --- a/server/tests/cli/peertube.ts +++ b/server/tests/cli/peertube.ts | |||
@@ -66,6 +66,18 @@ describe('Test CLI wrapper', function () { | |||
66 | await execCLI(`${env} ${cmd} auth add -u ${server.url} -U user_1 -p super_password`) | 66 | await execCLI(`${env} ${cmd} auth add -u ${server.url} -U user_1 -p super_password`) |
67 | }) | 67 | }) |
68 | 68 | ||
69 | it('Should not fail to add a user if there is a slash at the end of the instance URL', async function () { | ||
70 | this.timeout(60000) | ||
71 | |||
72 | const env = getEnvCli(server) | ||
73 | let fullServerURL | ||
74 | fullServerURL = server.url + '/' | ||
75 | await execCLI(`${env} ${cmd} auth add -u ${fullServerURL} -U user_1 -p super_password`) | ||
76 | |||
77 | fullServerURL = server.url + '/asdfasdf' | ||
78 | await execCLI(`${env} ${cmd} auth add -u ${fullServerURL} -U user_1 -p super_password`) | ||
79 | }) | ||
80 | |||
69 | it('Should default to this user', async function () { | 81 | it('Should default to this user', async function () { |
70 | this.timeout(60000) | 82 | this.timeout(60000) |
71 | 83 | ||