Fix nodeinfo endpoint

1 files changed, 37 insertions, 36 deletions

diff --git a/server/middlewares/cache.ts b/server/middlewares/cache.ts
index 1e5a13b2e..c671b88c9 100644
--- a/server/middlewares/cache.ts
+++ b/server/middlewares/cache.ts
@@ -6,59 +6,60 @@ import { logger } from '../helpers/logger'
 
 const lock = new AsyncLock({ timeout: 5000 })
 
-function cacheRoute (lifetime: number) {
+function cacheRoute (lifetimeArg: string | number) {
   return async function (req: express.Request, res: express.Response, next: express.NextFunction) {
     const redisKey = Redis.Instance.buildCachedRouteKey(req)
 
-    await lock.acquire(redisKey, async (done) => {
-      const cached = await Redis.Instance.getCachedRoute(req)
+    try {
+      await lock.acquire(redisKey, async (done) => {
+        const cached = await Redis.Instance.getCachedRoute(req)
 
-      // Not cached
-      if (!cached) {
-        logger.debug('No cached results for route %s.', req.originalUrl)
+        // Not cached
+        if (!cached) {
+          logger.debug('No cached results for route %s.', req.originalUrl)
 
-        const sendSave = res.send.bind(res)
+          const sendSave = res.send.bind(res)
 
-        res.send = (body) => {
-          if (res.statusCode >= 200 && res.statusCode < 400) {
-            const contentType = res.get('content-type')
-            Redis.Instance.setCachedRoute(req, body, lifetime, contentType, res.statusCode)
-                 .then(() => done())
-                 .catch(err => {
-                   logger.error('Cannot cache route.', { err })
-                   return done(err)
-                 })
+          res.send = (body) => {
+            if (res.statusCode >= 200 && res.statusCode < 400) {
+              const contentType = res.get('content-type')
+              const lifetime = parseDuration(lifetimeArg)
+
+              Redis.Instance.setCachedRoute(req, body, lifetime, contentType, res.statusCode)
+                   .then(() => done())
+                   .catch(err => {
+                     logger.error('Cannot cache route.', { err })
+                     return done(err)
+                   })
+            }
+
+            return sendSave(body)
           }
 
-          return sendSave(body)
+          return next()
         }
 
-        return next()
-      }
-
-      if (cached.contentType) res.set('content-type', cached.contentType)
+        if (cached.contentType) res.set('content-type', cached.contentType)
 
-      if (cached.statusCode) {
-        const statusCode = parseInt(cached.statusCode, 10)
-        if (!isNaN(statusCode)) res.status(statusCode)
-      }
+        if (cached.statusCode) {
+          const statusCode = parseInt(cached.statusCode, 10)
+          if (!isNaN(statusCode)) res.status(statusCode)
+        }
 
-      logger.debug('Use cached result for %s.', req.originalUrl)
-      res.send(cached.body).end()
+        logger.debug('Use cached result for %s.', req.originalUrl)
+        res.send(cached.body).end()
 
-      return done()
-    })
+        return done()
+      })
+    } catch (err) {
+      logger.error('Cannot serve cached route.', err)
+      return next()
+    }
   }
 }
 
-const cache = (duration: number | string) => {
-  const _lifetime = parseDuration(duration, 3600000)
-  return cacheRoute(_lifetime)
-}
-
 // ---------------------------------------------------------------------------
 
 export {
-  cacheRoute,
-  cache
+  cacheRoute
 }