replace numbers with typed http status codes (#3409)

1 files changed, 6 insertions, 5 deletions

diff --git a/server/middlewares/validators/config.ts b/server/middlewares/validators/config.ts
index d0071ccc1..93de453a7 100644
--- a/server/middlewares/validators/config.ts
+++ b/server/middlewares/validators/config.ts
@@ -8,6 +8,7 @@ import { isUserNSFWPolicyValid, isUserVideoQuotaDailyValid, isUserVideoQuotaVali
 import { logger } from '../../helpers/logger'
 import { isThemeRegistered } from '../../lib/plugins/theme-utils'
 import { areValidationErrors } from './utils'
+import { HttpStatusCode } from '../../../shared/core-utils/miscs/http-error-codes'
 
 const customConfigUpdateValidator = [
   body('instance.name').exists().withMessage('Should have a valid instance name'),
@@ -105,9 +106,9 @@ function checkInvalidConfigIfEmailDisabled (customConfig: CustomConfig, res: exp
   if (isEmailEnabled()) return true
 
   if (customConfig.signup.requiresEmailVerification === true) {
-    res.status(400)
-      .send({ error: 'Emailer is disabled but you require signup email verification.' })
-      .end()
+    res.status(HttpStatusCode.BAD_REQUEST_400)
+       .send({ error: 'Emailer is disabled but you require signup email verification.' })
+       .end()
     return false
   }
 
@@ -118,7 +119,7 @@ function checkInvalidTranscodingConfig (customConfig: CustomConfig, res: express
   if (customConfig.transcoding.enabled === false) return true
 
   if (customConfig.transcoding.webtorrent.enabled === false && customConfig.transcoding.hls.enabled === false) {
-    res.status(400)
+    res.status(HttpStatusCode.BAD_REQUEST_400)
        .send({ error: 'You need to enable at least webtorrent transcoding or hls transcoding' })
        .end()
     return false
@@ -131,7 +132,7 @@ function checkInvalidLiveConfig (customConfig: CustomConfig, res: express.Respon
   if (customConfig.live.enabled === false) return true
 
   if (customConfig.live.allowReplay === true && customConfig.transcoding.enabled === false) {
-    res.status(400)
+    res.status(HttpStatusCode.BAD_REQUEST_400)
        .send({ error: 'You cannot allow live replay if transcoding is not enabled' })
        .end()
     return false