diff options
author | Caroline Chuong <caroline.chuong@octo.com> | 2020-06-08 19:42:51 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-06-08 19:42:51 +0200 |
commit | 6ad971d5f5e9ea2adfc58bd83ba1790efa4a8d12 (patch) | |
tree | 15cd22d1e2de6166cbf5de0501ae1692d6deb4c2 /client/src/app/shared | |
parent | c2caa99b942dea7fa9d2856f53efd1316169658e (diff) | |
download | PeerTube-6ad971d5f5e9ea2adfc58bd83ba1790efa4a8d12.tar.gz PeerTube-6ad971d5f5e9ea2adfc58bd83ba1790efa4a8d12.tar.zst PeerTube-6ad971d5f5e9ea2adfc58bd83ba1790efa4a8d12.zip |
add aria-hidden to non-descriptive icons (#2844)
Diffstat (limited to 'client/src/app/shared')
5 files changed, 9 insertions, 9 deletions
diff --git a/client/src/app/shared/buttons/delete-button.component.html b/client/src/app/shared/buttons/delete-button.component.html index 25196fbd5..398b6db1e 100644 --- a/client/src/app/shared/buttons/delete-button.component.html +++ b/client/src/app/shared/buttons/delete-button.component.html | |||
@@ -1,5 +1,5 @@ | |||
1 | <span class="action-button action-button-delete grey-button" [title]="title" role="button"> | 1 | <span class="action-button action-button-delete grey-button" [title]="title" role="button"> |
2 | <my-global-icon iconName="delete"></my-global-icon> | 2 | <my-global-icon iconName="delete" aria-hidden="true"></my-global-icon> |
3 | 3 | ||
4 | <span class="button-label" *ngIf="label">{{ label }}</span> | 4 | <span class="button-label" *ngIf="label">{{ label }}</span> |
5 | <span class="button-label" i18n *ngIf="!label">Delete</span> | 5 | <span class="button-label" i18n *ngIf="!label">Delete</span> |
diff --git a/client/src/app/shared/buttons/edit-button.component.html b/client/src/app/shared/buttons/edit-button.component.html index 3d7cd4780..b852bb38a 100644 --- a/client/src/app/shared/buttons/edit-button.component.html +++ b/client/src/app/shared/buttons/edit-button.component.html | |||
@@ -1,5 +1,5 @@ | |||
1 | <a class="action-button action-button-edit grey-button" [routerLink]="routerLink" i18n-title title="Edit"> | 1 | <a class="action-button action-button-edit grey-button" [routerLink]="routerLink" i18n-title title="Edit"> |
2 | <my-global-icon iconName="edit"></my-global-icon> | 2 | <my-global-icon iconName="edit" aria-hidden="true"></my-global-icon> |
3 | 3 | ||
4 | <span class="button-label" *ngIf="label">{{ label }}</span> | 4 | <span class="button-label" *ngIf="label">{{ label }}</span> |
5 | <span i18n class="button-label" *ngIf="!label">Edit</span> | 5 | <span i18n class="button-label" *ngIf="!label">Edit</span> |
diff --git a/client/src/app/shared/users/user-notifications.component.html b/client/src/app/shared/users/user-notifications.component.html index 108122b57..8dbe6e329 100644 --- a/client/src/app/shared/users/user-notifications.component.html +++ b/client/src/app/shared/users/user-notifications.component.html | |||
@@ -81,7 +81,7 @@ | |||
81 | </ng-container> | 81 | </ng-container> |
82 | 82 | ||
83 | <ng-container *ngSwitchCase="UserNotificationType.MY_VIDEO_PUBLISHED"> | 83 | <ng-container *ngSwitchCase="UserNotificationType.MY_VIDEO_PUBLISHED"> |
84 | <my-global-icon iconName="sparkle"></my-global-icon> | 84 | <my-global-icon iconName="sparkle" aria-hidden="true"></my-global-icon> |
85 | 85 | ||
86 | <div class="message" i18n> | 86 | <div class="message" i18n> |
87 | Your video <a (click)="markAsRead(notification)" [routerLink]="notification.videoUrl">{{ notification.video.name }}</a> has been published | 87 | Your video <a (click)="markAsRead(notification)" [routerLink]="notification.videoUrl">{{ notification.video.name }}</a> has been published |
@@ -89,7 +89,7 @@ | |||
89 | </ng-container> | 89 | </ng-container> |
90 | 90 | ||
91 | <ng-container *ngSwitchCase="UserNotificationType.MY_VIDEO_IMPORT_SUCCESS"> | 91 | <ng-container *ngSwitchCase="UserNotificationType.MY_VIDEO_IMPORT_SUCCESS"> |
92 | <my-global-icon iconName="cloud-download"></my-global-icon> | 92 | <my-global-icon iconName="cloud-download" aria-hidden="true"></my-global-icon> |
93 | 93 | ||
94 | <div class="message" i18n> | 94 | <div class="message" i18n> |
95 | <a (click)="markAsRead(notification)" [routerLink]="notification.videoUrl || notification.videoImportUrl">Your video import</a> {{ notification.videoImportIdentifier }} succeeded | 95 | <a (click)="markAsRead(notification)" [routerLink]="notification.videoUrl || notification.videoImportUrl">Your video import</a> {{ notification.videoImportIdentifier }} succeeded |
@@ -97,7 +97,7 @@ | |||
97 | </ng-container> | 97 | </ng-container> |
98 | 98 | ||
99 | <ng-container *ngSwitchCase="UserNotificationType.MY_VIDEO_IMPORT_ERROR"> | 99 | <ng-container *ngSwitchCase="UserNotificationType.MY_VIDEO_IMPORT_ERROR"> |
100 | <my-global-icon iconName="cloud-error"></my-global-icon> | 100 | <my-global-icon iconName="cloud-error" aria-hidden="true"></my-global-icon> |
101 | 101 | ||
102 | <div class="message" i18n> | 102 | <div class="message" i18n> |
103 | <a (click)="markAsRead(notification)" [routerLink]="notification.videoImportUrl">Your video import</a> {{ notification.videoImportIdentifier }} failed | 103 | <a (click)="markAsRead(notification)" [routerLink]="notification.videoImportUrl">Your video import</a> {{ notification.videoImportIdentifier }} failed |
diff --git a/client/src/app/shared/video-playlist/video-add-to-playlist.component.html b/client/src/app/shared/video-playlist/video-add-to-playlist.component.html index 58108584b..a40e0699e 100644 --- a/client/src/app/shared/video-playlist/video-add-to-playlist.component.html +++ b/client/src/app/shared/video-playlist/video-add-to-playlist.component.html | |||
@@ -4,7 +4,7 @@ | |||
4 | <div i18n class="title">Save to</div> | 4 | <div i18n class="title">Save to</div> |
5 | 5 | ||
6 | <div class="options" (click)="displayOptions = !displayOptions"> | 6 | <div class="options" (click)="displayOptions = !displayOptions"> |
7 | <my-global-icon iconName="cog"></my-global-icon> | 7 | <my-global-icon iconName="cog" aria-hidden="true"></my-global-icon> |
8 | 8 | ||
9 | <span i18n>Options</span> | 9 | <span i18n>Options</span> |
10 | </div> | 10 | </div> |
@@ -60,7 +60,7 @@ | |||
60 | </div> | 60 | </div> |
61 | 61 | ||
62 | <div class="new-playlist-button dropdown-item" (click)="openCreateBlock($event)" [hidden]="isNewPlaylistBlockOpened"> | 62 | <div class="new-playlist-button dropdown-item" (click)="openCreateBlock($event)" [hidden]="isNewPlaylistBlockOpened"> |
63 | <my-global-icon iconName="add"></my-global-icon> | 63 | <my-global-icon iconName="add" aria-hidden="true"></my-global-icon> |
64 | 64 | ||
65 | <span i18n>Create a private playlist</span> | 65 | <span i18n>Create a private playlist</span> |
66 | </div> | 66 | </div> |
diff --git a/client/src/app/shared/video-playlist/video-playlist-element-miniature.component.html b/client/src/app/shared/video-playlist/video-playlist-element-miniature.component.html index c956e6cd2..e3f7ef017 100644 --- a/client/src/app/shared/video-playlist/video-playlist-element-miniature.component.html +++ b/client/src/app/shared/video-playlist/video-playlist-element-miniature.component.html | |||
@@ -46,7 +46,7 @@ | |||
46 | <div ngbDropdownMenu> | 46 | <div ngbDropdownMenu> |
47 | <ng-container *ngIf="playlistElement.video"> | 47 | <ng-container *ngIf="playlistElement.video"> |
48 | <div class="dropdown-item" (click)="toggleDisplayTimestampsOptions($event, playlistElement)"> | 48 | <div class="dropdown-item" (click)="toggleDisplayTimestampsOptions($event, playlistElement)"> |
49 | <my-global-icon iconName="edit"></my-global-icon> | 49 | <my-global-icon iconName="edit" aria-hidden="true"></my-global-icon> |
50 | <ng-container i18n>Edit starts/stops at</ng-container> | 50 | <ng-container i18n>Edit starts/stops at</ng-container> |
51 | </div> | 51 | </div> |
52 | 52 | ||
@@ -84,7 +84,7 @@ | |||
84 | </ng-container> | 84 | </ng-container> |
85 | 85 | ||
86 | <span class="dropdown-item" (click)="removeFromPlaylist(playlistElement)"> | 86 | <span class="dropdown-item" (click)="removeFromPlaylist(playlistElement)"> |
87 | <my-global-icon iconName="delete"></my-global-icon> | 87 | <my-global-icon iconName="delete" aria-hidden="true"></my-global-icon> |
88 | <ng-container i18n>Delete from {{ playlist?.displayName }}</ng-container> | 88 | <ng-container i18n>Delete from {{ playlist?.displayName }}</ng-container> |
89 | </span> | 89 | </span> |
90 | </div> | 90 | </div> |