diff options
author | Chocobozzz <me@florianbigard.com> | 2020-08-12 10:40:04 +0200 |
---|---|---|
committer | Chocobozzz <me@florianbigard.com> | 2020-08-14 10:28:30 +0200 |
commit | 66357162f8e1227495f09bd4f68446aad7071c6d (patch) | |
tree | 7d4429506deb512b2fe1d0267f38a28cda20af55 /client/src/app/core/routing | |
parent | 8c360747995e17eb5520e22fc3d7bd4c3d26eeee (diff) | |
download | PeerTube-66357162f8e1227495f09bd4f68446aad7071c6d.tar.gz PeerTube-66357162f8e1227495f09bd4f68446aad7071c6d.tar.zst PeerTube-66357162f8e1227495f09bd4f68446aad7071c6d.zip |
Migrate to $localize
* Remove i18n polyfill to translate things in components
* Reduce bundle sizes
* Improve runtime perf
* Reduce a lot the time to make a full client build
* Reduce client build complexity
* We don't need a service to translate things anymore (so we will be able to translate title pages etc)
Unfortunately we may loose some translations in the migration process.
I'll put a message on weblate to notify translators
Diffstat (limited to 'client/src/app/core/routing')
-rw-r--r-- | client/src/app/core/routing/can-deactivate-guard.service.ts | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/client/src/app/core/routing/can-deactivate-guard.service.ts b/client/src/app/core/routing/can-deactivate-guard.service.ts index e0405293a..8fce495e9 100644 --- a/client/src/app/core/routing/can-deactivate-guard.service.ts +++ b/client/src/app/core/routing/can-deactivate-guard.service.ts | |||
@@ -2,7 +2,6 @@ import { Observable } from 'rxjs' | |||
2 | import { Injectable } from '@angular/core' | 2 | import { Injectable } from '@angular/core' |
3 | import { CanDeactivate } from '@angular/router' | 3 | import { CanDeactivate } from '@angular/router' |
4 | import { ConfirmService } from '@app/core/confirm' | 4 | import { ConfirmService } from '@app/core/confirm' |
5 | import { I18n } from '@ngx-translate/i18n-polyfill' | ||
6 | 5 | ||
7 | export type CanComponentDeactivateResult = { text?: string, canDeactivate: Observable<boolean> | boolean } | 6 | export type CanComponentDeactivateResult = { text?: string, canDeactivate: Observable<boolean> | boolean } |
8 | 7 | ||
@@ -12,18 +11,16 @@ export interface CanComponentDeactivate { | |||
12 | 11 | ||
13 | @Injectable() | 12 | @Injectable() |
14 | export class CanDeactivateGuard implements CanDeactivate<CanComponentDeactivate> { | 13 | export class CanDeactivateGuard implements CanDeactivate<CanComponentDeactivate> { |
15 | constructor ( | 14 | |
16 | private confirmService: ConfirmService, | 15 | constructor (private confirmService: ConfirmService) { } |
17 | private i18n: I18n | ||
18 | ) { } | ||
19 | 16 | ||
20 | canDeactivate (component: CanComponentDeactivate) { | 17 | canDeactivate (component: CanComponentDeactivate) { |
21 | const result = component.canDeactivate() | 18 | const result = component.canDeactivate() |
22 | const text = result.text || this.i18n('All unsaved data will be lost, are you sure you want to leave this page?') | 19 | const text = result.text || $localize`All unsaved data will be lost, are you sure you want to leave this page?` |
23 | 20 | ||
24 | return result.canDeactivate || this.confirmService.confirm( | 21 | return result.canDeactivate || this.confirmService.confirm( |
25 | text, | 22 | text, |
26 | this.i18n('Warning') | 23 | $localize`Warning` |
27 | ) | 24 | ) |
28 | } | 25 | } |
29 | 26 | ||