diff options
author | Chocobozzz <me@florianbigard.com> | 2023-01-13 09:39:35 +0100 |
---|---|---|
committer | Chocobozzz <me@florianbigard.com> | 2023-01-13 09:39:35 +0100 |
commit | bc48e33b80f357767b98c1d310b04bdda24c6d46 (patch) | |
tree | 24f21505fb6d42707a2917736170ad7eb11d5bec | |
parent | 6a056bbe4df1c29039d46df2b7937163033a5585 (diff) | |
download | PeerTube-bc48e33b80f357767b98c1d310b04bdda24c6d46.tar.gz PeerTube-bc48e33b80f357767b98c1d310b04bdda24c6d46.tar.zst PeerTube-bc48e33b80f357767b98c1d310b04bdda24c6d46.zip |
Optimize custom markup angular tags
We can use the on push strategy with these components
5 files changed, 15 insertions, 10 deletions
diff --git a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/button-markup.component.ts b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/button-markup.component.ts index 1af060548..264dd9577 100644 --- a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/button-markup.component.ts +++ b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/button-markup.component.ts | |||
@@ -1,4 +1,4 @@ | |||
1 | import { Component, Input } from '@angular/core' | 1 | import { ChangeDetectionStrategy, Component, Input } from '@angular/core' |
2 | import { VideoChannel } from '../../shared-main' | 2 | import { VideoChannel } from '../../shared-main' |
3 | import { CustomMarkupComponent } from './shared' | 3 | import { CustomMarkupComponent } from './shared' |
4 | 4 | ||
@@ -9,7 +9,8 @@ import { CustomMarkupComponent } from './shared' | |||
9 | @Component({ | 9 | @Component({ |
10 | selector: 'my-button-markup', | 10 | selector: 'my-button-markup', |
11 | templateUrl: 'button-markup.component.html', | 11 | templateUrl: 'button-markup.component.html', |
12 | styleUrls: [ 'button-markup.component.scss' ] | 12 | styleUrls: [ 'button-markup.component.scss' ], |
13 | changeDetection: ChangeDetectionStrategy.OnPush | ||
13 | }) | 14 | }) |
14 | export class ButtonMarkupComponent implements CustomMarkupComponent { | 15 | export class ButtonMarkupComponent implements CustomMarkupComponent { |
15 | @Input() theme: 'primary' | 'secondary' | 16 | @Input() theme: 'primary' | 'secondary' |
diff --git a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/channel-miniature-markup.component.ts b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/channel-miniature-markup.component.ts index ba12b7139..1e7860750 100644 --- a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/channel-miniature-markup.component.ts +++ b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/channel-miniature-markup.component.ts | |||
@@ -1,6 +1,6 @@ | |||
1 | import { from } from 'rxjs' | 1 | import { from } from 'rxjs' |
2 | import { finalize, map, switchMap, tap } from 'rxjs/operators' | 2 | import { finalize, map, switchMap, tap } from 'rxjs/operators' |
3 | import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core' | 3 | import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnInit, Output } from '@angular/core' |
4 | import { MarkdownService, Notifier, UserService } from '@app/core' | 4 | import { MarkdownService, Notifier, UserService } from '@app/core' |
5 | import { FindInBulkService } from '@app/shared/shared-search' | 5 | import { FindInBulkService } from '@app/shared/shared-search' |
6 | import { VideoSortField } from '@shared/models' | 6 | import { VideoSortField } from '@shared/models' |
@@ -14,7 +14,8 @@ import { CustomMarkupComponent } from './shared' | |||
14 | @Component({ | 14 | @Component({ |
15 | selector: 'my-channel-miniature-markup', | 15 | selector: 'my-channel-miniature-markup', |
16 | templateUrl: 'channel-miniature-markup.component.html', | 16 | templateUrl: 'channel-miniature-markup.component.html', |
17 | styleUrls: [ 'channel-miniature-markup.component.scss' ] | 17 | styleUrls: [ 'channel-miniature-markup.component.scss' ], |
18 | changeDetection: ChangeDetectionStrategy.OnPush | ||
18 | }) | 19 | }) |
19 | export class ChannelMiniatureMarkupComponent implements CustomMarkupComponent, OnInit { | 20 | export class ChannelMiniatureMarkupComponent implements CustomMarkupComponent, OnInit { |
20 | @Input() name: string | 21 | @Input() name: string |
diff --git a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/playlist-miniature-markup.component.ts b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/playlist-miniature-markup.component.ts index 07fa6fd2d..ab52e7e37 100644 --- a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/playlist-miniature-markup.component.ts +++ b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/playlist-miniature-markup.component.ts | |||
@@ -1,5 +1,5 @@ | |||
1 | import { finalize } from 'rxjs/operators' | 1 | import { finalize } from 'rxjs/operators' |
2 | import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core' | 2 | import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnInit, Output } from '@angular/core' |
3 | import { Notifier } from '@app/core' | 3 | import { Notifier } from '@app/core' |
4 | import { FindInBulkService } from '@app/shared/shared-search' | 4 | import { FindInBulkService } from '@app/shared/shared-search' |
5 | import { MiniatureDisplayOptions } from '../../shared-video-miniature' | 5 | import { MiniatureDisplayOptions } from '../../shared-video-miniature' |
@@ -13,7 +13,8 @@ import { CustomMarkupComponent } from './shared' | |||
13 | @Component({ | 13 | @Component({ |
14 | selector: 'my-playlist-miniature-markup', | 14 | selector: 'my-playlist-miniature-markup', |
15 | templateUrl: 'playlist-miniature-markup.component.html', | 15 | templateUrl: 'playlist-miniature-markup.component.html', |
16 | styleUrls: [ 'playlist-miniature-markup.component.scss' ] | 16 | styleUrls: [ 'playlist-miniature-markup.component.scss' ], |
17 | changeDetection: ChangeDetectionStrategy.OnPush | ||
17 | }) | 18 | }) |
18 | export class PlaylistMiniatureMarkupComponent implements CustomMarkupComponent, OnInit { | 19 | export class PlaylistMiniatureMarkupComponent implements CustomMarkupComponent, OnInit { |
19 | @Input() uuid: string | 20 | @Input() uuid: string |
diff --git a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/video-miniature-markup.component.ts b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/video-miniature-markup.component.ts index cbbacf77c..c37666359 100644 --- a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/video-miniature-markup.component.ts +++ b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/video-miniature-markup.component.ts | |||
@@ -1,5 +1,5 @@ | |||
1 | import { finalize } from 'rxjs/operators' | 1 | import { finalize } from 'rxjs/operators' |
2 | import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core' | 2 | import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnInit, Output } from '@angular/core' |
3 | import { AuthService, Notifier } from '@app/core' | 3 | import { AuthService, Notifier } from '@app/core' |
4 | import { FindInBulkService } from '@app/shared/shared-search' | 4 | import { FindInBulkService } from '@app/shared/shared-search' |
5 | import { Video } from '../../shared-main' | 5 | import { Video } from '../../shared-main' |
@@ -13,7 +13,8 @@ import { CustomMarkupComponent } from './shared' | |||
13 | @Component({ | 13 | @Component({ |
14 | selector: 'my-video-miniature-markup', | 14 | selector: 'my-video-miniature-markup', |
15 | templateUrl: 'video-miniature-markup.component.html', | 15 | templateUrl: 'video-miniature-markup.component.html', |
16 | styleUrls: [ 'video-miniature-markup.component.scss' ] | 16 | styleUrls: [ 'video-miniature-markup.component.scss' ], |
17 | changeDetection: ChangeDetectionStrategy.OnPush | ||
17 | }) | 18 | }) |
18 | export class VideoMiniatureMarkupComponent implements CustomMarkupComponent, OnInit { | 19 | export class VideoMiniatureMarkupComponent implements CustomMarkupComponent, OnInit { |
19 | @Input() uuid: string | 20 | @Input() uuid: string |
diff --git a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/videos-list-markup.component.ts b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/videos-list-markup.component.ts index 7d3498d4c..70e88ea51 100644 --- a/client/src/app/shared/shared-custom-markup/peertube-custom-tags/videos-list-markup.component.ts +++ b/client/src/app/shared/shared-custom-markup/peertube-custom-tags/videos-list-markup.component.ts | |||
@@ -1,5 +1,5 @@ | |||
1 | import { finalize } from 'rxjs/operators' | 1 | import { finalize } from 'rxjs/operators' |
2 | import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core' | 2 | import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnInit, Output } from '@angular/core' |
3 | import { AuthService, Notifier } from '@app/core' | 3 | import { AuthService, Notifier } from '@app/core' |
4 | import { VideoSortField } from '@shared/models' | 4 | import { VideoSortField } from '@shared/models' |
5 | import { Video, VideoService } from '../../shared-main' | 5 | import { Video, VideoService } from '../../shared-main' |
@@ -13,7 +13,8 @@ import { CustomMarkupComponent } from './shared' | |||
13 | @Component({ | 13 | @Component({ |
14 | selector: 'my-videos-list-markup', | 14 | selector: 'my-videos-list-markup', |
15 | templateUrl: 'videos-list-markup.component.html', | 15 | templateUrl: 'videos-list-markup.component.html', |
16 | styleUrls: [ 'videos-list-markup.component.scss' ] | 16 | styleUrls: [ 'videos-list-markup.component.scss' ], |
17 | changeDetection: ChangeDetectionStrategy.OnPush | ||
17 | }) | 18 | }) |
18 | export class VideosListMarkupComponent implements CustomMarkupComponent, OnInit { | 19 | export class VideosListMarkupComponent implements CustomMarkupComponent, OnInit { |
19 | @Input() sort: string | 20 | @Input() sort: string |