From: Ismaël Bouya <ismael.bouya@normalesup.org>
Date: Mon, 19 Mar 2018 16:13:37 +0000 (+0100)
Subject: Don’t mount unavailables mounts
X-Git-Url: https://git.immae.eu/?p=perso%2FImmae%2FProjets%2FPuppet.git;a=commitdiff_plain;h=f25ad097f24e0d39d5dd9ac2cef39760e671e08f

Don’t mount unavailables mounts
---

diff --git a/environments/global/common.yaml b/environments/global/common.yaml
index 4836f6e..094e0ff 100644
--- a/environments/global/common.yaml
+++ b/environments/global/common.yaml
@@ -1,6 +1,6 @@
 ---
 lookup_options:
-  base_installation::mounts:
+  profile::fstab::mounts:
     merge: unique
   classes:
     merge: deep
@@ -22,9 +22,6 @@ base_installation::ldap_cn: "%{facts.ec2_metadata.hostname}"
 base_installation::ldap_server: "ldap.immae.eu"
 base_installation::ldap_uri: "ldaps://ldap.immae.eu"
 # FIXME: get all mounts without needing that hack?
-base_installation::mounts:
-  - "%{facts.ldapvar.self.vars.mounts.0}"
-  - "%{facts.ldapvar.self.vars.mounts.1}"
 base_installation::puppet_conf_path: "/etc/puppetlabs/puppet"
 base_installation::puppet_code_path: "/etc/puppetlabs/code"
 base_installation::puppet_pass_seed: "/etc/puppetlabs/puppet/password_seed"
@@ -32,6 +29,9 @@ base_installation::puppet_ssl_path: "/etc/puppetlabs/ssl"
 base_installation::system_locales: ["fr_FR.UTF-8", "en_US.UTF-8"]
 base_installation::system_timezone: "Europe/Paris"
 base_installation::system_users: [] # Fetched via ldap
+profile::fstab::mounts:
+  - "%{facts.ldapvar.self.vars.mounts.0}"
+  - "%{facts.ldapvar.self.vars.mounts.1}"
 profile::xmr_stak::mining_pool: "" # Fetched via ldap
 profile::xmr_stak::wallet: "" # Fetched via ldap
 profile::mail::mailhub: "" # Fetched via ldap
diff --git a/modules/base_installation/manifests/init.pp b/modules/base_installation/manifests/init.pp
index cb1cdda..998f8ff 100644
--- a/modules/base_installation/manifests/init.pp
+++ b/modules/base_installation/manifests/init.pp
@@ -6,7 +6,6 @@ class base_installation (
   Optional[String]        $ldap_dn          = $base_installation::params::ldap_dn,
   Optional[String]        $ldap_server      = $base_installation::params::ldap_server,
   Optional[String]        $ldap_uri         = $base_installation::params::ldap_uri,
-  Optional[Array[String]] $mounts           = $base_installation::params::mounts,
   Optional[String]        $puppet_code_path = $base_installation::params::puppet_code_path,
   Optional[String]        $puppet_conf_path = $base_installation::params::puppet_conf_path,
   Optional[String]        $puppet_pass_seed = $base_installation::params::puppet_pass_seed,
@@ -31,5 +30,4 @@ class base_installation (
   contain ::base_installation::users
   contain ::base_installation::package_managers
   contain ::base_installation::puppet
-  contain ::base_installation::fstab
 }
diff --git a/modules/base_installation/manifests/params.pp b/modules/base_installation/manifests/params.pp
index 2a9fe6a..5ade838 100644
--- a/modules/base_installation/manifests/params.pp
+++ b/modules/base_installation/manifests/params.pp
@@ -10,7 +10,6 @@ class base_installation::params {
   $ldap_cert_path   = "/etc/ssl/certs/ca-certificates.crt"
   $ldap_uri         = "ldaps://ldap.example.com"
   $ldap_server      = "ldap.example.com"
-  $mounts           = []
   $real_hostname    = "example.com"
   $system_hostname  = "example.com"
   $system_locales   = ["en_US.UTF-8"]
diff --git a/modules/base_installation/manifests/fstab.pp b/modules/profile/manifests/fstab.pp
similarity index 73%
rename from modules/base_installation/manifests/fstab.pp
rename to modules/profile/manifests/fstab.pp
index f012e76..5f2e58e 100644
--- a/modules/base_installation/manifests/fstab.pp
+++ b/modules/profile/manifests/fstab.pp
@@ -1,6 +1,6 @@
-class base_installation::fstab (
-  $mounts = $base_installation::mounts
-) inherits base_installation {
+class profile::fstab (
+  Optional[Array] $mounts = []
+) {
   $mounts.each |$mount| {
     unless empty($mount) {
       $infos = split($mount, ';')
diff --git a/modules/role/manifests/backup.pp b/modules/role/manifests/backup.pp
index edfd5e0..d7ba486 100644
--- a/modules/role/manifests/backup.pp
+++ b/modules/role/manifests/backup.pp
@@ -8,6 +8,7 @@ class role::backup (
 ) {
   include "base_installation"
 
+  include "profile::fstab"
   include "profile::mail"
   include "profile::tools"
   include "profile::xmr_stak"