From 183a53e3be74fabf501eaff19a39a47f1a6c9af5 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Isma=C3=ABl=20Bouya?= <ismael.bouya@normalesup.org>
Date: Wed, 17 Jan 2018 02:43:28 +0100
Subject: [PATCH] Write some tests for Portfolio class

---
 portfolio.py | 10 ++++--
 test.py      | 87 ++++++++++++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 92 insertions(+), 5 deletions(-)

diff --git a/portfolio.py b/portfolio.py
index 507f796..a4fbf94 100644
--- a/portfolio.py
+++ b/portfolio.py
@@ -32,8 +32,14 @@ class Portfolio:
         urllib3.disable_warnings()
         http = urllib3.PoolManager()
 
-        r = http.request("GET", cls.URL)
-        cls.data = json.loads(r.data)
+        try:
+            r = http.request("GET", cls.URL)
+        except Exception:
+            return
+        try:
+            cls.data = json.loads(r.data)
+        except json.JSONDecodeError:
+            cls.data = None
 
     @classmethod
     def parse_cryptoportfolio(cls):
diff --git a/test.py b/test.py
index 9e228d7..21077a3 100644
--- a/test.py
+++ b/test.py
@@ -3,9 +3,6 @@ import unittest
 from unittest import mock
 
 class AmountTest(unittest.TestCase):
-    def setUp(self):
-        super(AmountTest, self).setUp()
-
     def test_values(self):
         amount = portfolio.Amount("BTC", 0.65)
         self.assertEqual(0.65, amount.value)
@@ -170,5 +167,89 @@ class AmountTest(unittest.TestCase):
         amount2.linked_to = amount3
         self.assertEqual("Amount(32.00000000 BTX -> Amount(12000.00000000 USDT -> Amount(0.10000000 BTC)))", repr(amount1))
 
+class PortfolioTest(unittest.TestCase):
+    import urllib3
+    def fill_data(self):
+        if self.json_response is not None:
+            portfolio.Portfolio.data = self.json_response
+
+    def setUp(self):
+        super(PortfolioTest, self).setUp()
+
+        with open("test_portfolio.json") as example:
+            import json
+            self.json_response = json.load(example)
+
+        self.patcher = mock.patch.multiple(portfolio.Portfolio, data=None, liquidities={})
+        self.patcher.start()
+
+    @mock.patch.object(urllib3, "disable_warnings")
+    @mock.patch.object(urllib3.poolmanager.PoolManager, "request")
+    @mock.patch.object(portfolio.Portfolio, "URL", new="foo://bar")
+    def test_get_cryptoportfolio(self, request, disable_warnings):
+        request.side_effect = [
+                type('', (), { "data": '{ "foo": "bar" }' }),
+                type('', (), { "data": 'System Error' }),
+                Exception("Connection error"),
+                ]
+
+        portfolio.Portfolio.get_cryptoportfolio()
+        self.assertIn("foo", portfolio.Portfolio.data)
+        self.assertEqual("bar", portfolio.Portfolio.data["foo"])
+        request.assert_called_with("GET", "foo://bar")
+
+        request.reset_mock()
+        portfolio.Portfolio.get_cryptoportfolio()
+        self.assertIsNone(portfolio.Portfolio.data)
+        request.assert_called_with("GET", "foo://bar")
+
+        request.reset_mock()
+        portfolio.Portfolio.data = "foo"
+        portfolio.Portfolio.get_cryptoportfolio()
+        request.assert_called_with("GET", "foo://bar")
+        self.assertEqual("foo", portfolio.Portfolio.data)
+        disable_warnings.assert_called_with()
+
+    @mock.patch.object(portfolio.Portfolio, "get_cryptoportfolio")
+    def test_parse_cryptoportfolio(self, mock_get):
+        mock_get.side_effect = self.fill_data
+
+        portfolio.Portfolio.parse_cryptoportfolio()
+
+        self.assertListEqual(
+                ["medium", "high"],
+                list(portfolio.Portfolio.liquidities.keys()))
+
+        liquidities = portfolio.Portfolio.liquidities
+        self.assertEqual(10, len(liquidities["medium"].keys()))
+        self.assertEqual(10, len(liquidities["high"].keys()))
+
+        expected = {'BTC': 2857, 'DGB': 1015, 'DOGE': 1805, 'SC': 623, 'ZEC': 3701}
+        self.assertDictEqual(expected, liquidities["high"]['2018-01-08'])
+
+        expected = {'ETC': 1000, 'FCT': 1000, 'GAS': 1000, 'NAV': 1000, 'OMG': 1000, 'OMNI': 1000, 'PPC': 1000, 'RIC': 1000, 'VIA': 1000, 'XCP': 1000}
+        self.assertDictEqual(expected, liquidities["medium"]['2018-01-08'])
+
+        # It doesn't refetch the data when available
+        portfolio.Portfolio.parse_cryptoportfolio()
+        mock_get.assert_called_once_with()
+
+        portfolio.Portfolio.data["portfolio_1"]["holding"]["direction"][3] = "short"
+        self.assertRaises(AssertionError, portfolio.Portfolio.parse_cryptoportfolio)
+
+    @mock.patch.object(portfolio.Portfolio, "get_cryptoportfolio")
+    def test_repartition_pertenthousand(self, mock_get):
+        mock_get.side_effect = self.fill_data
+
+        expected_medium = {'USDT': 1000, 'ETC': 1000, 'FCT': 1000, 'OMG': 1000, 'STEEM': 1000, 'STRAT': 1000, 'XEM': 1000, 'XMR': 1000, 'XVC': 1000, 'ZRX': 1000}
+        expected_high = {'USDT': 1226, 'BTC': 1429, 'ETC': 1127, 'ETH': 1569, 'FCT': 3341, 'GAS': 1308}
+
+        self.assertEqual(expected_medium, portfolio.Portfolio.repartition_pertenthousand())
+        self.assertEqual(expected_medium, portfolio.Portfolio.repartition_pertenthousand(liquidity="medium"))
+        self.assertEqual(expected_high, portfolio.Portfolio.repartition_pertenthousand(liquidity="high"))
+
+    def tearDown(self):
+        self.patcher.stop()
+
 if __name__ == '__main__':
     unittest.main()
-- 
2.41.0