Ensure ENV is well defined when using make

[github/wallabag/wallabag.git] / GNUmakefile

diff --git a/GNUmakefile b/GNUmakefile
index 15d737db5099c13e0095179177d8efaf7271e849..db87c5d210ee114d18a26dda018e728765912bf8 100755 (executable)
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -2,7 +2,17 @@ SHELL=bash
 TMP_FOLDER=/tmp
 RELEASE_FOLDER=wllbg-release
 
-ENV ?= prod
+# ensure the ENV variable is well defined
+ifeq ($(origin ENV), prod)
+       # all good ("prod" is a valid env)
+else ifeq ($(origin ENV), dev)
+       # all good ("dev" is a valid env)
+else ifeq ($(origin ENV), test)
+       # all good ("test" is a valid env)
+else
+       # not good, force it to "prod"
+       override ENV = prod
+endif
 
 help: ## Display this help menu
        @grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
@@ -10,14 +20,14 @@ help: ## Display this help menu
 clean: ## Clear the application cache
        rm -rf var/cache/*
 
-install: ## Install wallabag with the latest version
+install: customcss ## Install wallabag with the latest version
        @./scripts/install.sh $(ENV)
 
 update: ## Update the wallabag installation to the latest version
        @./scripts/update.sh $(ENV)
 
 dev: ENV=dev
-dev: build ## Install the latest dev version
+dev: build customcss ## Install the latest dev version
        @./scripts/dev.sh
 
 run: ## Run the wallabag built-in server
@@ -27,6 +37,9 @@ build: ## Run webpack
        @npm install
        @npm run build:$(ENV)
 
+customcss:
+       @touch web/custom.css
+
 prepare: clean ## Prepare database for testsuite
 ifdef DB
        cp app/config/tests/parameters_test.$(DB).yml app/config/parameters_test.yml