]> git.immae.eu Git - github/wallabag/wallabag.git/blame - src/Wallabag/CoreBundle/Helper/DownloadImages.php
Fix image downloading on null image path
[github/wallabag/wallabag.git] / src / Wallabag / CoreBundle / Helper / DownloadImages.php
CommitLineData
419214d7
TC
1<?php
2
3namespace Wallabag\CoreBundle\Helper;
4
7f559418 5use GuzzleHttp\Client;
577c0b6d 6use GuzzleHttp\Message\Response;
f808b016
JB
7use Psr\Log\LoggerInterface;
8use Symfony\Component\DomCrawler\Crawler;
e0597476 9use Symfony\Component\Finder\Finder;
f808b016 10use Symfony\Component\HttpFoundation\File\MimeType\MimeTypeExtensionGuesser;
419214d7 11
156bf627
JB
12class DownloadImages
13{
7f559418
JB
14 const REGENERATE_PICTURES_QUALITY = 80;
15
16 private $client;
17 private $baseFolder;
419214d7 18 private $logger;
7f559418 19 private $mimeGuesser;
41ada277 20 private $wallabagUrl;
419214d7 21
e0597476 22 public function __construct(Client $client, $baseFolder, $wallabagUrl, LoggerInterface $logger)
156bf627 23 {
7f559418
JB
24 $this->client = $client;
25 $this->baseFolder = $baseFolder;
e0597476 26 $this->wallabagUrl = rtrim($wallabagUrl, '/');
419214d7 27 $this->logger = $logger;
7f559418
JB
28 $this->mimeGuesser = new MimeTypeExtensionGuesser();
29
30 $this->setFolder();
419214d7
TC
31 }
32
7f559418
JB
33 /**
34 * Process the html and extract image from it, save them to local and return the updated html.
35 *
e0597476 36 * @param int $entryId ID of the entry
7f559418 37 * @param string $html
e0597476 38 * @param string $url Used as a base path for relative image and folder
7f559418
JB
39 *
40 * @return string
41 */
e0597476 42 public function processHtml($entryId, $html, $url)
156bf627 43 {
7f559418 44 $crawler = new Crawler($html);
c15bb5ad
S
45 $imagesCrawler = $crawler
46 ->filterXpath('//img');
47 $imagesUrls = $imagesCrawler
9bf7752f 48 ->extract(['src']);
c15bb5ad
S
49 $imagesSrcsetUrls = $this->getSrcsetUrls($imagesCrawler);
50 $imagesUrls = array_unique(array_merge($imagesUrls, $imagesSrcsetUrls));
419214d7 51
e0597476 52 $relativePath = $this->getRelativePath($entryId);
7f559418 53
419214d7 54 // download and save the image to the folder
c15bb5ad 55 foreach ($imagesUrls as $image) {
e0597476 56 $imagePath = $this->processSingleImage($entryId, $image, $url, $relativePath);
7f559418
JB
57
58 if (false === $imagePath) {
59 continue;
60 }
61
9bf7752f 62 // if image contains "&" and we can't find it in the html it might be because it's encoded as &amp;
fcad69a4
JB
63 if (false !== stripos($image, '&') && false === stripos($html, $image)) {
64 $image = str_replace('&', '&amp;', $image);
65 }
66
7f559418 67 $html = str_replace($image, $imagePath, $html);
419214d7
TC
68 }
69
7f559418 70 return $html;
419214d7
TC
71 }
72
7f559418
JB
73 /**
74 * Process a single image:
75 * - retrieve it
76 * - re-saved it (for security reason)
77 * - return the new local path.
78 *
e0597476 79 * @param int $entryId ID of the entry
7f559418
JB
80 * @param string $imagePath Path to the image to retrieve
81 * @param string $url Url from where the image were found
82 * @param string $relativePath Relative local path to saved the image
83 *
84 * @return string Relative url to access the image from the web
85 */
e0597476 86 public function processSingleImage($entryId, $imagePath, $url, $relativePath = null)
156bf627 87 {
3fbbe0d9
S
88 if (null === $imagePath) {
89 return false;
90 }
91
e0597476
JB
92 if (null === $relativePath) {
93 $relativePath = $this->getRelativePath($entryId);
419214d7
TC
94 }
95
f808b016 96 $this->logger->debug('DownloadImages: working on image: ' . $imagePath);
e0597476 97
f808b016 98 $folderPath = $this->baseFolder . '/' . $relativePath;
419214d7 99
7f559418
JB
100 // build image path
101 $absolutePath = $this->getAbsoluteLink($url, $imagePath);
102 if (false === $absolutePath) {
e0597476 103 $this->logger->error('DownloadImages: Can not determine the absolute path for that image, skipping.');
419214d7
TC
104
105 return false;
106 }
107
48656e0e
JB
108 try {
109 $res = $this->client->get($absolutePath);
110 } catch (\Exception $e) {
e0597476 111 $this->logger->error('DownloadImages: Can not retrieve image, skipping.', ['exception' => $e]);
48656e0e
JB
112
113 return false;
114 }
7f559418 115
577c0b6d
JB
116 $ext = $this->getExtensionFromResponse($res, $imagePath);
117 if (false === $res) {
419214d7
TC
118 return false;
119 }
577c0b6d 120
7f559418 121 $hashImage = hash('crc32', $absolutePath);
f808b016 122 $localPath = $folderPath . '/' . $hashImage . '.' . $ext;
7f559418
JB
123
124 try {
125 $im = imagecreatefromstring($res->getBody());
126 } catch (\Exception $e) {
127 $im = false;
128 }
419214d7 129
48656e0e 130 if (false === $im) {
e0597476 131 $this->logger->error('DownloadImages: Error while regenerating image', ['path' => $localPath]);
419214d7
TC
132
133 return false;
134 }
135
7f559418
JB
136 switch ($ext) {
137 case 'gif':
001cc716 138 imagegif($im, $localPath);
e0597476 139 $this->logger->debug('DownloadImages: Re-creating gif');
419214d7 140 break;
7f559418
JB
141 case 'jpeg':
142 case 'jpg':
001cc716 143 imagejpeg($im, $localPath, self::REGENERATE_PICTURES_QUALITY);
e0597476 144 $this->logger->debug('DownloadImages: Re-creating jpg');
419214d7 145 break;
7f559418 146 case 'png':
7a3260ae
KD
147 imagealphablending($im, false);
148 imagesavealpha($im, true);
001cc716 149 imagepng($im, $localPath, ceil(self::REGENERATE_PICTURES_QUALITY / 100 * 9));
e0597476 150 $this->logger->debug('DownloadImages: Re-creating png');
419214d7 151 }
7f559418 152
419214d7
TC
153 imagedestroy($im);
154
f808b016 155 return $this->wallabagUrl . '/assets/images/' . $relativePath . '/' . $hashImage . '.' . $ext;
419214d7
TC
156 }
157
e0597476
JB
158 /**
159 * Remove all images for the given entry id.
160 *
161 * @param int $entryId ID of the entry
162 */
163 public function removeImages($entryId)
164 {
165 $relativePath = $this->getRelativePath($entryId);
f808b016 166 $folderPath = $this->baseFolder . '/' . $relativePath;
e0597476
JB
167
168 $finder = new Finder();
169 $finder
170 ->files()
171 ->ignoreDotFiles(true)
172 ->in($folderPath);
173
174 foreach ($finder as $file) {
175 @unlink($file->getRealPath());
176 }
177
178 @rmdir($folderPath);
179 }
180
c15bb5ad
S
181 /**
182 * Get images urls from the srcset image attribute.
183 *
184 * @param Crawler $imagesCrawler
185 *
186 * @return array An array of urls
187 */
188 protected function getSrcsetUrls(Crawler $imagesCrawler)
189 {
190 $urls = [];
191 $iterator = $imagesCrawler
192 ->getIterator();
193 while ($iterator->valid()) {
194 $srcsetAttribute = $iterator->current()->getAttribute('srcset');
195 if ('' !== $srcsetAttribute) {
196 $srcset = array_map('trim', explode(',', $srcsetAttribute));
197 $srcsetUrls = array_map(function ($src) {
198 return explode(' ', $src)[0];
199 }, $srcset);
200 $urls = array_merge($srcsetUrls, $urls);
201 }
202 $iterator->next();
203 }
204
205 return $urls;
206 }
207
f808b016
JB
208 /**
209 * Setup base folder where all images are going to be saved.
210 */
211 private function setFolder()
212 {
213 // if folder doesn't exist, attempt to create one and store the folder name in property $folder
214 if (!file_exists($this->baseFolder)) {
215 mkdir($this->baseFolder, 0755, true);
216 }
217 }
218
7f559418
JB
219 /**
220 * Generate the folder where we are going to save images based on the entry url.
221 *
e0597476 222 * @param int $entryId ID of the entry
7f559418
JB
223 *
224 * @return string
225 */
e0597476 226 private function getRelativePath($entryId)
419214d7 227 {
e0597476 228 $hashId = hash('crc32', $entryId);
f808b016
JB
229 $relativePath = $hashId[0] . '/' . $hashId[1] . '/' . $hashId;
230 $folderPath = $this->baseFolder . '/' . $relativePath;
419214d7 231
7f559418
JB
232 if (!file_exists($folderPath)) {
233 mkdir($folderPath, 0777, true);
419214d7
TC
234 }
235
e0597476 236 $this->logger->debug('DownloadImages: Folder used for that Entry id', ['folder' => $folderPath, 'entryId' => $entryId]);
419214d7 237
7f559418
JB
238 return $relativePath;
239 }
419214d7 240
7f559418
JB
241 /**
242 * Make an $url absolute based on the $base.
243 *
244 * @see Graby->makeAbsoluteStr
245 *
246 * @param string $base Base url
247 * @param string $url Url to make it absolute
248 *
249 * @return false|string
250 */
251 private function getAbsoluteLink($base, $url)
252 {
253 if (preg_match('!^https?://!i', $url)) {
254 // already absolute
255 return $url;
419214d7
TC
256 }
257
7f559418 258 $base = new \SimplePie_IRI($base);
419214d7 259
7f559418
JB
260 // remove '//' in URL path (causes URLs not to resolve properly)
261 if (isset($base->ipath)) {
262 $base->ipath = preg_replace('!//+!', '/', $base->ipath);
419214d7
TC
263 }
264
7f559418
JB
265 if ($absolute = \SimplePie_IRI::absolutize($base, $url)) {
266 return $absolute->get_uri();
94654765 267 }
156bf627 268
e0597476 269 $this->logger->error('DownloadImages: Can not make an absolute link', ['base' => $base, 'url' => $url]);
48656e0e 270
7f559418 271 return false;
94654765 272 }
577c0b6d
JB
273
274 /**
275 * Retrieve and validate the extension from the response of the url of the image.
276 *
277 * @param Response $res Guzzle Response
278 * @param string $imagePath Path from the src image from the content (used for log only)
279 *
280 * @return string|false Extension name or false if validation failed
281 */
282 private function getExtensionFromResponse(Response $res, $imagePath)
283 {
284 $ext = $this->mimeGuesser->guess($res->getHeader('content-type'));
285 $this->logger->debug('DownloadImages: Checking extension', ['ext' => $ext, 'header' => $res->getHeader('content-type')]);
286
287 // ok header doesn't have the extension, try a different way
288 if (empty($ext)) {
289 $types = [
290 'jpeg' => "\xFF\xD8\xFF",
291 'gif' => 'GIF',
292 'png' => "\x89\x50\x4e\x47\x0d\x0a",
293 ];
294 $bytes = substr((string) $res->getBody(), 0, 8);
295
296 foreach ($types as $type => $header) {
297 if (0 === strpos($bytes, $header)) {
298 $ext = $type;
299 break;
300 }
301 }
302
303 $this->logger->debug('DownloadImages: Checking extension (alternative)', ['ext' => $ext]);
304 }
305
306 if (!in_array($ext, ['jpeg', 'jpg', 'gif', 'png'], true)) {
f808b016 307 $this->logger->error('DownloadImages: Processed image with not allowed extension. Skipping: ' . $imagePath);
577c0b6d
JB
308
309 return false;
310 }
311
312 return $ext;
313 }
419214d7 314}