]> git.immae.eu Git - github/shaarli/Shaarli.git/log
github/shaarli/Shaarli.git
3 years agoMerge branch 'master' into v0.12 v0.12 v0.12.1
ArthurHoaro [Thu, 12 Nov 2020 12:02:36 +0000 (13:02 +0100)] 
Merge branch 'master' into v0.12

3 years agoBump Shaarli version to v0.12.1
ArthurHoaro [Thu, 12 Nov 2020 12:01:53 +0000 (13:01 +0100)] 
Bump Shaarli version to v0.12.1

3 years agoMerge pull request #1638 from ArthurHoaro/changelog/v0.12.1
ArthurHoaro [Thu, 12 Nov 2020 12:00:45 +0000 (13:00 +0100)] 
Merge pull request #1638 from ArthurHoaro/changelog/v0.12.1

CHANGELOG v0.12.1

3 years agoCHANGELOG v0.12.1 1638/head
ArthurHoaro [Thu, 12 Nov 2020 11:56:22 +0000 (12:56 +0100)] 
CHANGELOG v0.12.1

3 years agoMerge pull request #1635 from ArthurHoaro/feature/phpcs
ArthurHoaro [Tue, 10 Nov 2020 09:46:04 +0000 (10:46 +0100)] 
Merge pull request #1635 from ArthurHoaro/feature/phpcs

3 years agoMerge pull request #1637 from ArthurHoaro/fix/server-admin-update-check
ArthurHoaro [Tue, 10 Nov 2020 09:45:50 +0000 (10:45 +0100)] 
Merge pull request #1637 from ArthurHoaro/fix/server-admin-update-check

Server admin: do not retrieve latest version without update_check

3 years agoMerge pull request #1636 from ArthurHoaro/fix/vintage-async-metadata
ArthurHoaro [Tue, 10 Nov 2020 09:45:22 +0000 (10:45 +0100)] 
Merge pull request #1636 from ArthurHoaro/fix/vintage-async-metadata

3 years agoMerge pull request #1630 from ArthurHoaro/fix/apache-config
ArthurHoaro [Tue, 10 Nov 2020 09:45:05 +0000 (10:45 +0100)] 
Merge pull request #1630 from ArthurHoaro/fix/apache-config

Reviewed Apache configuration

3 years agoMerge pull request #1634 from ArthurHoaro/fix/docker-compose
ArthurHoaro [Tue, 10 Nov 2020 09:44:50 +0000 (10:44 +0100)] 
Merge pull request #1634 from ArthurHoaro/fix/docker-compose

Docker-compose: fix SSL certificate + add parameter for Docker tag

3 years agoMerge pull request #1628 from ArthurHoaro/fix/nginx-config
ArthurHoaro [Tue, 10 Nov 2020 09:44:29 +0000 (10:44 +0100)] 
Merge pull request #1628 from ArthurHoaro/fix/nginx-config

Reviewed nginx configuration

3 years agoServer admin: do not retrieve latest version without update_check 1637/head
ArthurHoaro [Mon, 9 Nov 2020 13:37:45 +0000 (14:37 +0100)] 
Server admin: do not retrieve latest version without update_check

If the setting 'updates.check_updates' is disabled, do not retrieve the latest version on server administration page.

Additionally, updated default values for

  - updates.check_updates from false to true
  - updates.check_updates_branch from stable to latest

3 years agoVintage theme: fix routes in daily page 1636/head
ArthurHoaro [Mon, 9 Nov 2020 11:46:43 +0000 (12:46 +0100)] 
Vintage theme: fix routes in daily page

3 years agoVintage theme: display global messages
ArthurHoaro [Mon, 9 Nov 2020 11:46:24 +0000 (12:46 +0100)] 
Vintage theme: display global messages

3 years agoVintage theme: support async metadata retrieval
ArthurHoaro [Mon, 9 Nov 2020 11:36:04 +0000 (12:36 +0100)] 
Vintage theme: support async metadata retrieval

3 years agoUpdate Static Analysis documentation 1635/head
ArthurHoaro [Mon, 9 Nov 2020 11:17:40 +0000 (12:17 +0100)] 
Update Static Analysis documentation

3 years agoRun PHPCS during Travis CI checks + disable xdebug
ArthurHoaro [Mon, 9 Nov 2020 09:56:02 +0000 (10:56 +0100)] 
Run PHPCS during Travis CI checks + disable xdebug

3 years agoManually fix remaining PHPCS errors
ArthurHoaro [Sun, 8 Nov 2020 14:02:45 +0000 (15:02 +0100)] 
Manually fix remaining PHPCS errors

3 years agoApply PHP Code Beautifier on source code for linter automatic fixes
ArthurHoaro [Tue, 22 Sep 2020 18:25:47 +0000 (20:25 +0200)] 
Apply PHP Code Beautifier on source code for linter automatic fixes

3 years agoDocker-compose: fix SSL certificate + add parameter for Docker tag 1634/head
ArthurHoaro [Mon, 9 Nov 2020 09:36:13 +0000 (10:36 +0100)] 
Docker-compose: fix SSL certificate + add parameter for Docker tag

Use envvar SHAARLI_VIRTUAL_HOST for Traefik's docker.domain parameter instead of localhost (I'm not sure if did work at some point).

Add an environment variable to choose which Docker tag to use instead of using master by default.

Fixes #1632

3 years agoCoding style: switch PHPCS to PSR12
ArthurHoaro [Tue, 22 Sep 2020 18:16:23 +0000 (20:16 +0200)] 
Coding style: switch PHPCS to PSR12

Also temporarily ignore test code (one step at a time).

Reference: https://www.php-fig.org/psr/psr-12/

Related to #95

3 years agoMerge pull request #1621 from ArthurHoaro/feature/tag-separators
ArthurHoaro [Sun, 8 Nov 2020 13:07:33 +0000 (14:07 +0100)] 
Merge pull request #1621 from ArthurHoaro/feature/tag-separators

3 years agoMerge pull request #1629 from ArthurHoaro/fix/demo-vimeo
ArthurHoaro [Sun, 8 Nov 2020 13:06:45 +0000 (14:06 +0100)] 
Merge pull request #1629 from ArthurHoaro/fix/demo-vimeo

Replace vimeo link in demo bookmarks due to IP ban on the demo instance

3 years agoMerge pull request #1631 from ArthurHoaro/fix/html-extract-quote-fix
ArthurHoaro [Sun, 8 Nov 2020 13:06:38 +0000 (14:06 +0100)] 
Merge pull request #1631 from ArthurHoaro/fix/html-extract-quote-fix

Fix an issue truncating extracted metadata content

3 years agoFix an issue truncating extracted metadata content 1631/head
ArthurHoaro [Sun, 8 Nov 2020 12:54:39 +0000 (13:54 +0100)] 
Fix an issue truncating extracted metadata content

Previous regex forced the selection to stop at either the first single or double quote found, regardless of the opening quote. Using '\1', we're sure to wait for the proper quote before stopping the capture.

3 years agoReviewed Apache configuration 1630/head
ArthurHoaro [Sun, 8 Nov 2020 12:13:13 +0000 (13:13 +0100)] 
Reviewed Apache configuration

(in documentation)

For security purpose, block access to any static file not matching the list of allowed extensions.
It allows us to remove the specific retriction on dotfiles, and fix Apache part of #1608.

3 years agoReplace vimeo link in demo bookmarks due to IP ban on the demo instance 1629/head
ArthurHoaro [Sun, 8 Nov 2020 10:58:17 +0000 (11:58 +0100)] 
Replace vimeo link in demo bookmarks due to IP ban on the demo instance

Fixes #1148

3 years agoReviewed nginx configuration 1628/head
ArthurHoaro [Sat, 7 Nov 2020 13:27:49 +0000 (14:27 +0100)] 
Reviewed nginx configuration

Both in documentation and Docker image.

For security purpose, it no longer allow to access static files through
the main nginx *location*. Static files are served if their extension
matches the whitelist.

As a side effect, we no longer need specific restrictions, and
therefore it fixes the nginx part of #1608.

3 years agoMerge pull request #1627 from ArthurHoaro/fix/unexpected-error
ArthurHoaro [Fri, 6 Nov 2020 09:00:03 +0000 (10:00 +0100)] 
Merge pull request #1627 from ArthurHoaro/fix/unexpected-error

Display error details even with dev.debug set to false

3 years agoDisplay error details even with dev.debug set to false 1627/head
ArthurHoaro [Thu, 5 Nov 2020 18:45:41 +0000 (19:45 +0100)] 
Display error details even with dev.debug set to false

It makes more sense to display the error even if it's unexpected.
Only for logged in users.

Fixes #1606

3 years agoESLint 1621/head
ArthurHoaro [Thu, 5 Nov 2020 18:08:38 +0000 (19:08 +0100)] 
ESLint

3 years agoTags separator: vintage theme compatibility
ArthurHoaro [Thu, 5 Nov 2020 17:16:52 +0000 (18:16 +0100)] 
Tags separator: vintage theme compatibility

3 years agoBump shaarli/netscape-bookmark-parser dependency version
ArthurHoaro [Tue, 3 Nov 2020 12:35:27 +0000 (13:35 +0100)] 
Bump shaarli/netscape-bookmark-parser dependency version

3 years agoFeature: support any tag separator
ArthurHoaro [Thu, 22 Oct 2020 14:21:03 +0000 (16:21 +0200)] 
Feature: support any tag separator

So it allows to have multiple words tags.

Breaking change: commas ',' are no longer a default separator.

Fixes #594

3 years agoMerge pull request #1626 from ArthurHoaro/fix/vintage-webpack
ArthurHoaro [Thu, 5 Nov 2020 16:54:14 +0000 (17:54 +0100)] 
Merge pull request #1626 from ArthurHoaro/fix/vintage-webpack

Webpack: fix vintage theme images include

3 years agoWebpack: fix vintage theme images include 1626/head
ArthurHoaro [Thu, 5 Nov 2020 16:44:33 +0000 (17:44 +0100)] 
Webpack: fix vintage theme images include

3 years agoMerge pull request #1625 from ArthurHoaro/fix/delete-confirm-popup
ArthurHoaro [Thu, 5 Nov 2020 15:58:24 +0000 (16:58 +0100)] 
Merge pull request #1625 from ArthurHoaro/fix/delete-confirm-popup

Fix confirm popup before bookmark deletion

3 years agoFix confirm popup before bookmark deletion 1625/head
ArthurHoaro [Thu, 5 Nov 2020 15:32:15 +0000 (16:32 +0100)] 
Fix confirm popup before bookmark deletion

Regression introduced by #1596

Fixes #1623

3 years agoMerge pull request #1620 from ArthurHoaro/feature/no-auto-link
ArthurHoaro [Thu, 5 Nov 2020 15:47:17 +0000 (16:47 +0100)] 
Merge pull request #1620 from ArthurHoaro/feature/no-auto-link

Default formatter: add a setting to disable auto-linkification

3 years agoMerge pull request #1624 from ArthurHoaro/fix/delete-redirect
ArthurHoaro [Thu, 5 Nov 2020 15:36:34 +0000 (16:36 +0100)] 
Merge pull request #1624 from ArthurHoaro/fix/delete-redirect

Fix: redirect to referrer after bookmark deletion

3 years agoMerge pull request #1619 from ArthurHoaro/fix/translations
ArthurHoaro [Thu, 5 Nov 2020 15:36:04 +0000 (16:36 +0100)] 
Merge pull request #1619 from ArthurHoaro/fix/translations

Fix French translation

3 years agoFix: redirect to referrer after bookmark deletion 1624/head
ArthurHoaro [Thu, 5 Nov 2020 15:14:22 +0000 (16:14 +0100)] 
Fix: redirect to referrer after bookmark deletion

Except if the referer points to a permalink (which has been deleted).

Fixes #1622

3 years agoDefault formatter: add a setting to disable auto-linkification 1620/head
ArthurHoaro [Tue, 3 Nov 2020 11:38:38 +0000 (12:38 +0100)] 
Default formatter: add a setting to disable auto-linkification

  + update documentation
  + single parameter for both URL and hashtags

Fixes #1094

3 years agoFix French translation 1619/head
ArthurHoaro [Tue, 3 Nov 2020 10:58:02 +0000 (11:58 +0100)] 
Fix French translation

2 missing key + 1 wrong translation

Fixes  #1571

3 years agoMerge pull request #1610 from ArthurHoaro/fix/wallabag
ArthurHoaro [Tue, 3 Nov 2020 10:46:54 +0000 (11:46 +0100)] 
Merge pull request #1610 from ArthurHoaro/fix/wallabag

Plugin wallabag: minor improvements

3 years agoMerge pull request #1618 from ArthurHoaro/fix/ut-daily-date-1-digit
ArthurHoaro [Mon, 2 Nov 2020 18:42:20 +0000 (19:42 +0100)] 
Merge pull request #1618 from ArthurHoaro/fix/ut-daily-date-1-digit

UT: fix formatting issue when the current day has a single digit

3 years agoUT: fix formatting issue when the current day has a single digit 1618/head
ArthurHoaro [Mon, 2 Nov 2020 18:22:50 +0000 (19:22 +0100)] 
UT: fix formatting issue when the current day has a single digit

3 years agoMerge pull request #1616 from dimtion/fix-api-redirect
ArthurHoaro [Thu, 29 Oct 2020 15:03:07 +0000 (16:03 +0100)] 
Merge pull request #1616 from dimtion/fix-api-redirect

API postLink: change relative path to absolute path

3 years agopostLink: change relative path to absolute path 1616/head
Loïc Carr [Thu, 29 Oct 2020 02:57:40 +0000 (19:57 -0700)] 
postLink: change relative path to absolute path

3 years agoMerge pull request #1615 from ArthurHoaro/hotfix/save-redirect
ArthurHoaro [Wed, 28 Oct 2020 13:18:25 +0000 (14:18 +0100)] 
Merge pull request #1615 from ArthurHoaro/hotfix/save-redirect

Remove unnecessary escape of referer

3 years agoRemove unnecessary escape of referer 1615/head
ArthurHoaro [Wed, 28 Oct 2020 13:13:50 +0000 (14:13 +0100)] 
Remove unnecessary escape of referer

Fixes #1611

3 years agoMerge pull request #1614 from ArthurHoaro/hotfix/php71-compat-login
ArthurHoaro [Wed, 28 Oct 2020 13:08:08 +0000 (14:08 +0100)] 
Merge pull request #1614 from ArthurHoaro/hotfix/php71-compat-login

Fix compatiliby issue on login with PHP 7.1

3 years agoFix compatiliby issue on login with PHP 7.1 1614/head
ArthurHoaro [Wed, 28 Oct 2020 13:02:08 +0000 (14:02 +0100)] 
Fix compatiliby issue on login with PHP 7.1

 session_set_cookie_params does not return any value in PHP 7.1

3 years agoMerge pull request #1613 from ArthurHoaro/hotfix/404-not-authorized
ArthurHoaro [Wed, 28 Oct 2020 12:22:40 +0000 (13:22 +0100)] 
Merge pull request #1613 from ArthurHoaro/hotfix/404-not-authorized

Raise 404 error instead of 500 if permalink access is denied

3 years agoRaise 404 error instead of 500 if permalink access is denied 1613/head
ArthurHoaro [Wed, 28 Oct 2020 11:54:52 +0000 (12:54 +0100)] 
Raise 404 error instead of 500 if permalink access is denied

3 years agoMerge pull request #1612 from ArthurHoaro/hotfix/simplexml
ArthurHoaro [Wed, 28 Oct 2020 11:30:19 +0000 (12:30 +0100)] 
Merge pull request #1612 from ArthurHoaro/hotfix/simplexml

Include php-simplexml in Docker image

3 years agoInclude php-simplexml in Docker image 1612/head
ArthurHoaro [Wed, 28 Oct 2020 11:25:52 +0000 (12:25 +0100)] 
Include php-simplexml in Docker image

Composer 2.0 is now blocking everything if requirements are not met

3 years agoPlugin wallabag: minor improvements 1610/head
ArthurHoaro [Sat, 24 Oct 2020 14:25:06 +0000 (16:25 +0200)] 
Plugin wallabag: minor improvements

  - hide the wallabag icon for logged out users
  - set API V2 as default parameter
  - fix URL encoding issue with special chars

Fixes #1147

3 years agoMerge pull request #1587 from ArthurHoaro/feature/batch-bookmark-creation
ArthurHoaro [Tue, 27 Oct 2020 19:18:18 +0000 (20:18 +0100)] 
Merge pull request #1587 from ArthurHoaro/feature/batch-bookmark-creation

3 years agoBulk creation: ignore blank lines 1587/head
ArthurHoaro [Fri, 23 Oct 2020 11:28:02 +0000 (13:28 +0200)] 
Bulk creation: ignore blank lines

3 years agoBulk creation: displays a progress bar when saving all displayed forms
ArthurHoaro [Fri, 23 Oct 2020 10:53:49 +0000 (12:53 +0200)] 
Bulk creation: displays a progress bar when saving all displayed forms

3 years agoBulk creation: improve performances using memoization
ArthurHoaro [Fri, 23 Oct 2020 10:29:52 +0000 (12:29 +0200)] 
Bulk creation: improve performances using memoization

Reduced additional processing time per links from ~40ms to ~5ms

3 years agoBulk creation: fix private status based on the first form
ArthurHoaro [Sun, 11 Oct 2020 11:34:38 +0000 (13:34 +0200)] 
Bulk creation: fix private status based on the first form

3 years agoFeature: bulk creation of bookmarks
ArthurHoaro [Sat, 10 Oct 2020 15:40:26 +0000 (17:40 +0200)] 
Feature: bulk creation of bookmarks

This changes creates a new form in addlink page allowing to create
multiple bookmarks at once more easily. It focuses on re-using as much
existing code and template component as  possible.

These changes includes:
  - a new form in addlink (hidden behind a button by default),
containing a text area for URL, and tags/private status to apply to
created links
  - this form displays a new template called editlink.batch, itself
including editlink template multiple times
  - User interation in this new templates are handle by a new JS script
(shaare-batch.js) making AJAX requests, and therefore does not need page
reloading
  - ManageShaareController has been split into 3 distinct controllers:
    + ShaareAdd: displays addlink template
    + ShaareManage: various operation applied on existing shaares
(change visibility, pin, deletion, etc.)
    + ShaarePublish: handles creation/edit forms and saving Shaare's
form
  - Updated translations

Fixes #137

3 years agoMerge pull request #1595 from ArthurHoaro/feature/daily-period
ArthurHoaro [Tue, 27 Oct 2020 18:59:28 +0000 (19:59 +0100)] 
Merge pull request #1595 from ArthurHoaro/feature/daily-period

3 years agoFix rebase issue 1595/head
ArthurHoaro [Tue, 27 Oct 2020 18:55:29 +0000 (19:55 +0100)] 
Fix rebase issue

3 years agoFeature: add weekly and monthly view/RSS feed for daily page
ArthurHoaro [Fri, 16 Oct 2020 09:50:53 +0000 (11:50 +0200)] 
Feature: add weekly and monthly view/RSS feed for daily page

  - Heavy refactoring of DailyController
  - Add a banner like in tag cloud to display monthly and weekly links
  - Translations: t() now supports variables with optional first letter
uppercase

Fixes #160

3 years agoMove utils classes to Shaarli\Helper namespace and folder
ArthurHoaro [Fri, 16 Oct 2020 11:34:59 +0000 (13:34 +0200)] 
Move utils classes to Shaarli\Helper namespace and folder

3 years agoMerge pull request #1597 from ArthurHoaro/feature/share-private-bookmark
ArthurHoaro [Tue, 27 Oct 2020 18:40:57 +0000 (19:40 +0100)] 
Merge pull request #1597 from ArthurHoaro/feature/share-private-bookmark

Feature: Share private bookmarks using a URL containing a private key

3 years agoFeature: Share private bookmarks using a URL containing a private key 1597/head
ArthurHoaro [Fri, 16 Oct 2020 18:17:08 +0000 (20:17 +0200)] 
Feature: Share private bookmarks using a URL containing a private key

  - Add a share link next to « Permalink » in linklist (using share icon
from fork awesome)
  - This link generates a private key associated to the bookmark
  - Accessing the bookmark while logged out with the proper key will
display it

Fixes #475

3 years agoMerge pull request #1604 from ArthurHoaro/feature/server-admin-page
ArthurHoaro [Tue, 27 Oct 2020 18:29:43 +0000 (19:29 +0100)] 
Merge pull request #1604 from ArthurHoaro/feature/server-admin-page

Feature: add a Server administration page

3 years agoMerge pull request #1609 from GaneshKandu/patch-1
ArthurHoaro [Tue, 27 Oct 2020 18:27:06 +0000 (19:27 +0100)] 
Merge pull request #1609 from GaneshKandu/patch-1

3 years agoRemoved PHP_EOL 1609/head
Ganesh Kandu [Tue, 27 Oct 2020 12:38:14 +0000 (18:08 +0530)] 
Removed PHP_EOL

just replace "*/ ?>" and "<?php /*" with '' and "Trim" output whatever is EOF will trimmed out.

3 years agoReplaced PHP_EOL to "\n"
Ganesh Kandu [Tue, 27 Oct 2020 12:12:35 +0000 (17:42 +0530)] 
Replaced PHP_EOL  to "\n"

i was getting error

```
An error occurred while parsing JSON configuration file (data/config.json.php): error code #4
➜ Syntax error
Please check your JSON syntax (without PHP comment tags) using a JSON lint tool such as jsonlint.com.
```
after debug i found
```php
        $data = str_replace(self::getPhpHeaders(), '', $data);
        $data = str_replace(self::getPhpSuffix(), '', $data);
```
doesn't removing php header and php suffix

cause of this issue was PHP_EOL represents the endline character for the current system. if my  ```config.json.php```  was encoded with unix ( LF ) and php running on windows windows encoding ( CR LF ) is not same as unix encoding ( LF ) so ```str_replace``` doesn't replace strin  then it causes issue.

3 years agoMerge pull request #1601 from ArthurHoaro/feature/psr3
ArthurHoaro [Sat, 24 Oct 2020 09:37:29 +0000 (11:37 +0200)] 
Merge pull request #1601 from ArthurHoaro/feature/psr3

3 years agoMerge pull request #1605 from ArthurHoaro/fix/nginx-doc-rule
ArthurHoaro [Wed, 21 Oct 2020 13:55:39 +0000 (15:55 +0200)] 
Merge pull request #1605 from ArthurHoaro/fix/nginx-doc-rule

Fix: nginx - add rule to disable url-rewriting for the docs

3 years agoFix: nginx - add rule to disable url-rewriting for the docs 1605/head
ArthurHoaro [Wed, 21 Oct 2020 13:23:30 +0000 (15:23 +0200)] 
Fix: nginx - add rule to disable url-rewriting for the docs

Related to #1603

3 years agoFeature: add a Server administration page 1604/head
ArthurHoaro [Wed, 21 Oct 2020 11:12:15 +0000 (13:12 +0200)] 
Feature: add a Server administration page

It contains mostly read only information about the current Shaarli instance,
PHP version, extensions, file and folder permissions, etc.
Also action buttons to clear the cache or sync thumbnails.

Part of the content of this page is also displayed on the install page,
to check server requirement before installing Shaarli config file.

Fixes #40
Fixes #185

3 years agoMerge pull request #1602 from ArthurHoaro/fix/root-exceptions
ArthurHoaro [Tue, 20 Oct 2020 19:37:20 +0000 (21:37 +0200)] 
Merge pull request #1602 from ArthurHoaro/fix/root-exceptions

Dislay an error if an exception occurs in the error handler

3 years agoDislay an error if an exception occurs in the error handler 1602/head
ArthurHoaro [Tue, 20 Oct 2020 16:32:46 +0000 (18:32 +0200)] 
Dislay an error if an exception occurs in the error handler

Related to #1598

3 years agoUse PSR-3 logger for login attempts 1601/head
ArthurHoaro [Tue, 20 Oct 2020 09:47:07 +0000 (11:47 +0200)] 
Use PSR-3 logger for login attempts

Fixes #1122

3 years agoComposer: explicitly import katzgrau/klogger (already included in netscape-bookmark...
ArthurHoaro [Tue, 20 Oct 2020 08:39:58 +0000 (10:39 +0200)] 
Composer: explicitly import katzgrau/klogger (already included in netscape-bookmark-parser)

3 years agoMerge pull request #1584 from ArthurHoaro/feature/async-thumbnail-retrieval
ArthurHoaro [Tue, 20 Oct 2020 08:30:02 +0000 (10:30 +0200)] 
Merge pull request #1584 from ArthurHoaro/feature/async-thumbnail-retrieval

Asynchronous retrieval of bookmark's thumbnails

3 years agoAsynchronous retrieval of bookmark's thumbnails 1584/head
ArthurHoaro [Thu, 15 Oct 2020 09:46:24 +0000 (11:46 +0200)] 
Asynchronous retrieval of bookmark's thumbnails

This feature is based general.enable_async_metadata setting and works with existing metadata.js file.
The script is compatible with any template:
   - the thumbnail div bloc must have  attribute
   - the bookmark bloc must have  attribute with the bookmark ID as value

Fixes #1564

3 years agoMerge pull request #1567 from ArthurHoaro/feature/async-title-retrieval
ArthurHoaro [Tue, 20 Oct 2020 08:14:28 +0000 (10:14 +0200)] 
Merge pull request #1567 from ArthurHoaro/feature/async-title-retrieval

3 years agoMerge pull request #1600 from yudete/master
ArthurHoaro [Tue, 20 Oct 2020 08:08:03 +0000 (10:08 +0200)] 
Merge pull request #1600 from yudete/master

3 years agoUpdate translations (Japanese) 1600/head
yudete [Mon, 19 Oct 2020 01:25:51 +0000 (10:25 +0900)] 
Update translations (Japanese)

3 years agoUpdate translations (Japanese)
yudete [Mon, 19 Oct 2020 01:17:35 +0000 (10:17 +0900)] 
Update translations (Japanese)

3 years agoMerge pull request #1588 from ArthurHoaro/feature/search-highlight
ArthurHoaro [Fri, 16 Oct 2020 18:40:49 +0000 (20:40 +0200)] 
Merge pull request #1588 from ArthurHoaro/feature/search-highlight

3 years agoadd search highlight unit tests 1588/head
ArthurHoaro [Mon, 12 Oct 2020 10:23:57 +0000 (12:23 +0200)] 
add search highlight unit tests

3 years agoFeature: highlight fulltext search results
ArthurHoaro [Mon, 12 Oct 2020 09:35:55 +0000 (11:35 +0200)] 
Feature: highlight fulltext search results

How it works:

  1. when a fulltext search is made, Shaarli looks for the first
occurence position of every term matching the search. No change here,
but we store these positions in an array, in Bookmark's additionalContent.
  2. when formatting bookmarks (through BookmarkFormatter
implementation):
    1. first we insert specific tokens at every search result positions
    2. we format the content (escape HTML, apply markdown, etc.)
    3. as a last step, we replace our token with displayable span
elements

Cons: this tightens coupling between search filters and formatters
Pros: it was absolutely necessary not to perform the
search twice. this solution has close to no impact on performances.

Fixes #205

3 years agoMerge pull request #1596 from ArthurHoaro/feature/better-rename-tag
ArthurHoaro [Fri, 16 Oct 2020 18:15:19 +0000 (20:15 +0200)] 
Merge pull request #1596 from ArthurHoaro/feature/better-rename-tag

Improve Manage tags page

3 years agoImprove Manage tags page 1596/head
ArthurHoaro [Fri, 16 Oct 2020 18:03:25 +0000 (20:03 +0200)] 
Improve Manage tags page

Fixes #1125

3 years agoMerge pull request #1593 from ArthurHoaro/fix/no-url-rewriting
ArthurHoaro [Fri, 16 Oct 2020 17:26:03 +0000 (19:26 +0200)] 
Merge pull request #1593 from ArthurHoaro/fix/no-url-rewriting

3 years agoDoc: typo 1593/head
ArthurHoaro [Fri, 16 Oct 2020 17:20:45 +0000 (19:20 +0200)] 
Doc: typo

3 years agoInject ROOT_PATH in plugin instead of regenerating it everywhere
ArthurHoaro [Fri, 16 Oct 2020 11:06:06 +0000 (13:06 +0200)] 
Inject ROOT_PATH in plugin instead of regenerating it everywhere

3 years agoSupport using Shaarli without URL rewriting
ArthurHoaro [Fri, 16 Oct 2020 10:47:11 +0000 (12:47 +0200)] 
Support using Shaarli without URL rewriting

   - Shaarli can be fully used by prefixing any URL with /index.php/
   - {$base_path} used in templates already works with this configuration
   - Assets path (outside of theme's assets) must be prefixed with {$root_url}/
   - Documentation section in « Server configuration »

Fixes #1590

3 years agoMerge pull request #1592 from ArthurHoaro/fix/strict-type-daily
ArthurHoaro [Fri, 16 Oct 2020 10:16:54 +0000 (12:16 +0200)] 
Merge pull request #1592 from ArthurHoaro/fix/strict-type-daily

Strict types: fix an issue in daily where the date could be an int

3 years agoStrict types: fix an issue in daily where the date could be an int 1592/head
ArthurHoaro [Fri, 16 Oct 2020 10:04:46 +0000 (12:04 +0200)] 
Strict types: fix an issue in daily where the date could be an int

3 years agoImprove metadata retrieval (performances and accuracy) 1567/head
ArthurHoaro [Thu, 15 Oct 2020 09:20:33 +0000 (11:20 +0200)] 
Improve metadata retrieval (performances and accuracy)

  - Use dedicated function to download headers to avoid apply multiple regexps on headers
  - Also try to extract title from meta tags

3 years agoAdd a setting to retrieve bookmark metadata asynchrounously
ArthurHoaro [Fri, 25 Sep 2020 11:29:36 +0000 (13:29 +0200)] 
Add a setting to retrieve bookmark metadata asynchrounously

  - There is a new standalone script (metadata.js) which requests
    a new controller to get bookmark metadata and fill the form async
  - This feature is enabled with the new setting: general.enable_async_metadata
    (enabled by default)
  - general.retrieve_description is now enabled by default
  - A small rotating loader animation has a been added to bookmark inputs
    when metadata is being retrieved (default template)
  - Custom JS htmlentities has been removed and  mathiasbynens/he
    library is used instead

Fixes #1563