From: VirtualTam <virtualtam@flibidi.net>
Date: Fri, 18 Jan 2019 21:58:09 +0000 (+0100)
Subject: fix: ensure HTML tags are stripped from OpenGraph description
X-Git-Tag: v0.11.0~42^2
X-Git-Url: https://git.immae.eu/?p=github%2Fshaarli%2FShaarli.git;a=commitdiff_plain;h=49106a5d8cf1153b5da23f889d15e46fa480e7cc

fix: ensure HTML tags are stripped from OpenGraph description

Fixes https://github.com/shaarli/Shaarli/issues/1250
Relates to https://github.com/shaarli/Shaarli/issues/1242

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
---

diff --git a/tpl/default/includes.html b/tpl/default/includes.html
index 0427e224..6c30d1bf 100644
--- a/tpl/default/includes.html
+++ b/tpl/default/includes.html
@@ -21,7 +21,7 @@
   <meta property="og:type" content="article" />
   <meta property="og:url" content="{$index_url}?{$link.shorturl}" />
   {$ogDescription=isset($link.description_src) ? $link.description_src : $link.description}
-  <meta property="og:description" content="{function="substr($ogDescription, 0, 300)"}" />
+  <meta property="og:description" content="{function="substr(strip_tags($ogDescription), 0, 300)"}" />
   {if="$link.thumbnail"}
     <meta property="og:image" content="{$index_url}{$link.thumbnail}" />
   {/if}
diff --git a/tpl/vintage/includes.html b/tpl/vintage/includes.html
index df093495..2efb6b10 100644
--- a/tpl/vintage/includes.html
+++ b/tpl/vintage/includes.html
@@ -18,7 +18,7 @@
   <meta property="og:type" content="article" />
   <meta property="og:url" content="{$index_url}?{$link.shorturl}" />
   {$ogDescription=isset($link.description_src) ? $link.description_src : $link.description}
-  <meta property="og:description" content="{function="mb_substr($ogDescription, 0, 300)"}" />
+  <meta property="og:description" content="{function="mb_substr(strip_tags($ogDescription), 0, 300)"}" />
   {if="$link.thumbnail"}
     <meta property="og:image" content="{$index_url}{$link.thumbnail}" />
   {/if}