From 0bb5669cf602aa5aa2aae76299328827a1c290c5 Mon Sep 17 00:00:00 2001 From: Mathieu Bruyen Date: Thu, 25 Feb 2016 09:19:12 +0100 Subject: [PATCH] Remove SMTP configuration environment overrides SMTP configuration has been added in #1518 to use ParameterHandle's env-map. But Symfony actually has a native way of allowing parameters to be overriden from environment so rather than having to define a mapping for each possible parameter, users can define any override in parameters.yml: > parameters: > database_host: %WALLABAG_DB_HOST% and define an environment variable SYMFONY__WALLABAG_DB_HOST. Links: env-map: https://github.com/Incenteev/ParameterHandler#using-environment-variables-to-set-the-parameters Symfony external parameters: http://symfony.com/doc/current/cookbook/configuration/external_parameters.html --- composer.json | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/composer.json b/composer.json index 1abf6f20..4c3fbdaf 100644 --- a/composer.json +++ b/composer.json @@ -90,11 +90,8 @@ "fabpot/php-cs-fixer": "~1.9" }, "scripts": { - "build-parameters": [ - "Incenteev\\ParameterHandler\\ScriptHandler::buildParameters" - ], "post-cmd": [ - "@build-parameters", + "Incenteev\\ParameterHandler\\ScriptHandler::buildParameters", "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::buildBootstrap", "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::clearCache", "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installAssets", @@ -116,13 +113,7 @@ "symfony-tests-dir": "tests", "symfony-assets-install": "relative", "incenteev-parameters": { - "file": "app/config/parameters.yml", - "env-map": { - "mailer_host": "WALLABAG_MAILER_HOST", - "mailer_user": "WALLABAG_MAILER_USER", - "mailer_password": "WALLABAG_MAILER_PASSWORD", - "secret": "WALLABAG_SECRET" - } + "file": "app/config/parameters.yml" } }, "autoload": { -- 2.41.0