From 1bb2ff2cfbffcdc571bc2f8b171ca892c8aebece Mon Sep 17 00:00:00 2001
From: =?utf8?q?Isma=C3=ABl=20Bouya?= <ismael.bouya@normalesup.org>
Date: Sat, 29 Dec 2018 10:40:42 +0100
Subject: [PATCH] Refactor a bit configurations

---
 virtual/eldiron.nix  |  4 ++--
 virtual/packages.nix | 35 ++++++++++++++++++++---------------
 2 files changed, 22 insertions(+), 17 deletions(-)

diff --git a/virtual/eldiron.nix b/virtual/eldiron.nix
index fd72608..c347029 100644
--- a/virtual/eldiron.nix
+++ b/virtual/eldiron.nix
@@ -101,7 +101,7 @@
           hostName = "db-1.immae.eu";
           documentRoot = null;
           extraConfig = builtins.concatStringsSep "\n" [
-            mypkgs.adminer.apacheConf
+            mypkgs.adminer.apache.vhostConf
           ];
         })
         (withSSL "eldiron" // {
@@ -109,7 +109,7 @@
           hostName = "tools.immae.eu";
           documentRoot = null;
           extraConfig = builtins.concatStringsSep "\n" [
-            mypkgs.adminer.apacheConf
+            mypkgs.adminer.apache.vhostConf
           ];
         })
         { # Should go last, default fallback
diff --git a/virtual/packages.nix b/virtual/packages.nix
index 2e16a0d..c257dab 100644
--- a/virtual/packages.nix
+++ b/virtual/packages.nix
@@ -8,9 +8,10 @@ with import (builtins.fetchTarball {
 let
   adminer = rec {
     webRoot = pkgs.stdenv.mkDerivation rec {
-      name = "adminer-4.7.0";
+      version = "4.7.0";
+      name = "adminer-${version}";
       src = pkgs.fetchurl {
-        url = "https://www.adminer.org/static/download/4.7.0/${name}.php";
+        url = "https://www.adminer.org/static/download/${version}/${name}.php";
         sha256 = "1qq2g7rbfh2vrqfm3g0bz0qs057b049n0mhabnsbd1sgnpvnc5z7";
       };
       phases = "installPhase";
@@ -23,10 +24,10 @@ let
       socket = "/var/run/phpfpm/adminer.sock";
       pool = ''
         listen = ${socket}
-        user = wwwrun
-        group = wwwrun
-        listen.owner = wwwrun
-        listen.group = wwwrun
+        user = ${apache.user}
+        group = ${apache.group}
+        listen.owner = ${apache.user}
+        listen.group = ${apache.group}
         pm = ondemand
         pm.max_children = 5
         pm.process_idle_timeout = 60
@@ -34,15 +35,19 @@ let
         php_admin_value[open_basedir] = "${webRoot}:/tmp"
         '';
     };
-    apacheConf = ''
-      Alias /adminer ${webRoot}
-      <Directory ${webRoot}>
-        DirectoryIndex = index.php
-        <FilesMatch "\.php$">
-          SetHandler "proxy:unix:${phpFpm.socket}|fcgi://localhost"
-        </FilesMatch>
-      </Directory>
-      '';
+    apache = {
+      user = "wwwrun";
+      group = "wwwrun";
+      vhostConf = ''
+        Alias /adminer ${webRoot}
+        <Directory ${webRoot}>
+          DirectoryIndex = index.php
+          <FilesMatch "\.php$">
+            SetHandler "proxy:unix:${phpFpm.socket}|fcgi://localhost"
+          </FilesMatch>
+        </Directory>
+        '';
+    };
     nginxConf = {
       alias = webRoot;
       index = "index.php";
-- 
2.41.0