From 497e0cad7ca2d2e771c8d41f7bc50ab2bc222cdb Mon Sep 17 00:00:00 2001 From: =?utf8?q?Nicolas=20L=C5=93uillet?= Date: Sun, 13 Sep 2015 09:57:35 +0200 Subject: [PATCH] add test for previewPicture filter --- src/Wallabag/CoreBundle/Filter/EntryFilterType.php | 4 +--- .../Tests/Controller/EntryControllerTest.php | 13 +++++++++++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/Wallabag/CoreBundle/Filter/EntryFilterType.php b/src/Wallabag/CoreBundle/Filter/EntryFilterType.php index 11c69abd..de95eed9 100644 --- a/src/Wallabag/CoreBundle/Filter/EntryFilterType.php +++ b/src/Wallabag/CoreBundle/Filter/EntryFilterType.php @@ -45,9 +45,7 @@ class EntryFilterType extends AbstractType ->add('isStarred', 'filter_checkbox') ->add('previewPicture', 'filter_checkbox', array( 'apply_filter' => function (QueryInterface $filterQuery, $field, $values) { - $value = $values['value']; - - if (false === $value) { + if (false === $values['value']) { return; } diff --git a/src/Wallabag/CoreBundle/Tests/Controller/EntryControllerTest.php b/src/Wallabag/CoreBundle/Tests/Controller/EntryControllerTest.php index a0966285..5798009c 100644 --- a/src/Wallabag/CoreBundle/Tests/Controller/EntryControllerTest.php +++ b/src/Wallabag/CoreBundle/Tests/Controller/EntryControllerTest.php @@ -369,4 +369,17 @@ class EntryControllerTest extends WallabagCoreTestCase $crawler = $client->submit($form); $this->assertCount(1, $crawler->filter('div[class=entry]')); } + + public function testPreviewPictureFilter() + { + $this->logInAs('admin'); + $client = $this->getClient(); + + $crawler = $client->request('GET', '/unread/list'); + $form = $crawler->filter('button[id=submit-filter]')->form(); + $form['entry_filter[previewPicture]']->tick(); + + $crawler = $client->submit($form); + $this->assertCount(1, $crawler->filter('div[class=entry]')); + } } -- 2.41.0