From 842a15732b5ddcd9c9c90e790a448235800ef870 Mon Sep 17 00:00:00 2001
From: Chocobozzz <me@florianbigard.com>
Date: Tue, 23 Nov 2021 15:22:07 +0100
Subject: [PATCH] Ensure we don't run transcoding after import file

---
 server/tests/api/videos/video-create-transcoding.ts |  6 +-----
 server/tests/cli/create-import-video-file-job.ts    | 10 ++++++++++
 shared/extra-utils/server/jobs.ts                   |  9 ++++++++-
 3 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/server/tests/api/videos/video-create-transcoding.ts b/server/tests/api/videos/video-create-transcoding.ts
index 128bc885a..c4627e0c1 100644
--- a/server/tests/api/videos/video-create-transcoding.ts
+++ b/server/tests/api/videos/video-create-transcoding.ts
@@ -7,6 +7,7 @@ import {
   cleanupTests,
   createMultipleServers,
   doubleFollow,
+  expectNoFailedTranscodingJob,
   expectStartWith,
   makeRawRequest,
   ObjectStorageCommand,
@@ -30,11 +31,6 @@ async function checkFilesInObjectStorage (video: VideoDetails) {
   }
 }
 
-async function expectNoFailedTranscodingJob (server: PeerTubeServer) {
-  const { data } = await server.jobs.listFailed({ jobType: 'video-transcoding' })
-  expect(data).to.have.lengthOf(0)
-}
-
 function runTests (objectStorage: boolean) {
   let servers: PeerTubeServer[] = []
   let videoUUID: string
diff --git a/server/tests/cli/create-import-video-file-job.ts b/server/tests/cli/create-import-video-file-job.ts
index 1e278bacc..17ed67b05 100644
--- a/server/tests/cli/create-import-video-file-job.ts
+++ b/server/tests/cli/create-import-video-file-job.ts
@@ -7,6 +7,7 @@ import {
   cleanupTests,
   createMultipleServers,
   doubleFollow,
+  expectNoFailedTranscodingJob,
   expectStartWith,
   makeRawRequest,
   ObjectStorageCommand,
@@ -69,6 +70,10 @@ function runTests (objectStorage: boolean) {
     }
 
     await waitJobs(servers)
+
+    for (const server of servers) {
+      await server.config.enableTranscoding()
+    }
   })
 
   it('Should run a import job on video 1 with a lower resolution', async function () {
@@ -139,6 +144,11 @@ function runTests (objectStorage: boolean) {
     }
   })
 
+  it('Should not have run transcoding after an import job', async function () {
+    const { data } = await servers[0].jobs.list({ jobType: 'video-transcoding' })
+    expect(data).to.have.lengthOf(0)
+  })
+
   after(async function () {
     await cleanupTests(servers)
   })
diff --git a/shared/extra-utils/server/jobs.ts b/shared/extra-utils/server/jobs.ts
index afaaa5cd6..34fefd444 100644
--- a/shared/extra-utils/server/jobs.ts
+++ b/shared/extra-utils/server/jobs.ts
@@ -1,4 +1,5 @@
 
+import { expect } from 'chai'
 import { JobState, JobType } from '../../models'
 import { wait } from '../miscs'
 import { PeerTubeServer } from './server'
@@ -70,8 +71,14 @@ async function waitJobs (serversArg: PeerTubeServer[] | PeerTubeServer, skipDela
   } while (pendingRequests)
 }
 
+async function expectNoFailedTranscodingJob (server: PeerTubeServer) {
+  const { data } = await server.jobs.listFailed({ jobType: 'video-transcoding' })
+  expect(data).to.have.lengthOf(0)
+}
+
 // ---------------------------------------------------------------------------
 
 export {
-  waitJobs
+  waitJobs,
+  expectNoFailedTranscodingJob
 }
-- 
2.41.0