]>
git.immae.eu Git - github/wallabag/wallabag.git/log
Jeremy Benoist [Fri, 21 Jun 2019 10:54:52 +0000 (12:54 +0200)]
Typo
Jeremy Benoist [Fri, 21 Jun 2019 10:46:53 +0000 (12:46 +0200)]
Use Twig 2.0
`mnapoli/piwik-twig-extension` locked Twig to the 1.10 version. The new version is compatible with Twig 2.0
Jeremy Benoist [Fri, 21 Jun 2019 09:34:26 +0000 (11:34 +0200)]
Update deps
Jérémy Benoist [Fri, 21 Jun 2019 05:04:45 +0000 (07:04 +0200)]
Merge pull request #4023 from wallabag/dependabot/composer/symfony/monolog-bundle-3.4.0
Bump symfony/monolog-bundle from 3.3.1 to 3.4.0
dependabot-preview[bot] [Fri, 21 Jun 2019 02:21:27 +0000 (02:21 +0000)]
Bump symfony/monolog-bundle from 3.3.1 to 3.4.0
Bumps [symfony/monolog-bundle](https://github.com/symfony/monolog-bundle) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/symfony/monolog-bundle/releases)
- [Changelog](https://github.com/symfony/monolog-bundle/blob/master/CHANGELOG.md)
- [Commits](https://github.com/symfony/monolog-bundle/compare/v3.3.1...v3.4.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Jérémy Benoist [Thu, 20 Jun 2019 07:49:29 +0000 (09:49 +0200)]
Merge pull request #4019 from wallabag/dependabot/composer/sensio/distribution-bundle-5.0.25
Bump sensio/distribution-bundle from 5.0.24 to 5.0.25
dependabot-preview[bot] [Thu, 20 Jun 2019 04:52:35 +0000 (04:52 +0000)]
Bump sensio/distribution-bundle from 5.0.24 to 5.0.25
Bumps [sensio/distribution-bundle](https://github.com/sensiolabs/SensioDistributionBundle) from 5.0.24 to 5.0.25.
- [Release notes](https://github.com/sensiolabs/SensioDistributionBundle/releases)
- [Commits](https://github.com/sensiolabs/SensioDistributionBundle/compare/v5.0.24...v5.0.25)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Jérémy Benoist [Thu, 20 Jun 2019 04:47:19 +0000 (06:47 +0200)]
Merge pull request #4022 from wallabag/dependabot/composer/liip/theme-bundle-1.7.0
Bump liip/theme-bundle from 1.6.1 to 1.7.0
dependabot-preview[bot] [Thu, 20 Jun 2019 02:21:25 +0000 (02:21 +0000)]
Bump liip/theme-bundle from 1.6.1 to 1.7.0
Bumps [liip/theme-bundle](https://github.com/liip/LiipThemeBundle) from 1.6.1 to 1.7.0.
- [Release notes](https://github.com/liip/LiipThemeBundle/releases)
- [Commits](https://github.com/liip/LiipThemeBundle/compare/1.6.1...1.7.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Jérémy Benoist [Tue, 18 Jun 2019 08:17:51 +0000 (10:17 +0200)]
Merge pull request #4016 from wallabag/dependabot/composer/nelmio/cors-bundle-1.5.6
Bump nelmio/cors-bundle from 1.5.5 to 1.5.6
Jérémy Benoist [Tue, 18 Jun 2019 07:41:59 +0000 (09:41 +0200)]
Merge pull request #4017 from wallabag/dependabot/composer/friendsofsymfony/jsrouting-bundle-2.3.1
Bump friendsofsymfony/jsrouting-bundle from 2.3.0 to 2.3.1
dependabot-preview[bot] [Tue, 18 Jun 2019 02:25:21 +0000 (02:25 +0000)]
Bump friendsofsymfony/jsrouting-bundle from 2.3.0 to 2.3.1
Bumps [friendsofsymfony/jsrouting-bundle](https://github.com/FriendsOfSymfony/FOSJsRoutingBundle) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/releases)
- [Changelog](https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/blob/master/CHANGELOG.md)
- [Commits](https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/compare/2.3.0...2.3.1)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
dependabot-preview[bot] [Tue, 18 Jun 2019 02:17:58 +0000 (02:17 +0000)]
Bump nelmio/cors-bundle from 1.5.5 to 1.5.6
Bumps [nelmio/cors-bundle](https://github.com/nelmio/NelmioCorsBundle) from 1.5.5 to 1.5.6.
- [Release notes](https://github.com/nelmio/NelmioCorsBundle/releases)
- [Changelog](https://github.com/nelmio/NelmioCorsBundle/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nelmio/NelmioCorsBundle/compare/1.5.5...1.5.6)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Jérémy Benoist [Mon, 17 Jun 2019 06:19:16 +0000 (08:19 +0200)]
Merge pull request #4009 from wallabag/fix/check-git-directory
Check if .git directory exist before making the update
Jeremy Benoist [Fri, 14 Jun 2019 09:28:23 +0000 (11:28 +0200)]
Return a different code when git isn't installed
Jérémy Benoist [Fri, 14 Jun 2019 08:29:05 +0000 (10:29 +0200)]
Merge pull request #4010 from wallabag/dependabot/composer/doctrine/doctrine-fixtures-bundle-3.2.2
Bump doctrine/doctrine-fixtures-bundle from 3.2.0 to 3.2.2
Jeremy Benoist [Wed, 12 Jun 2019 19:33:53 +0000 (21:33 +0200)]
Check if .git directory exist
If that folder doesn’t exist, it means the udpate script won’t be able to run because it uses git to retrieve the update.
dependabot-preview[bot] [Fri, 14 Jun 2019 08:08:21 +0000 (08:08 +0000)]
Bump doctrine/doctrine-fixtures-bundle from 3.2.0 to 3.2.2
Bumps [doctrine/doctrine-fixtures-bundle](https://github.com/doctrine/DoctrineFixturesBundle) from 3.2.0 to 3.2.2.
- [Release notes](https://github.com/doctrine/DoctrineFixturesBundle/releases)
- [Changelog](https://github.com/doctrine/DoctrineFixturesBundle/blob/master/CHANGELOG-3.1.md)
- [Commits](https://github.com/doctrine/DoctrineFixturesBundle/compare/3.2.0...3.2.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Jérémy Benoist [Fri, 14 Jun 2019 08:01:36 +0000 (10:01 +0200)]
Merge pull request #4008 from wallabag/travis-xenial
Fix Travis build on Xenial dist
Jérémy Benoist [Wed, 12 Jun 2019 19:36:00 +0000 (21:36 +0200)]
Merge pull request #3995 from wallabag/feature/config-display-login
Display login in config / user
Jeremy Benoist [Wed, 12 Jun 2019 18:34:12 +0000 (20:34 +0200)]
Fix Travis build on Xenial dist
Jérémy Benoist [Wed, 12 Jun 2019 15:44:28 +0000 (17:44 +0200)]
Typo
Jérémy Benoist [Wed, 12 Jun 2019 15:43:15 +0000 (17:43 +0200)]
Update FUNDING.yml
"Some users provided are not enrolled in GitHub Sponsors."
Jérémy Benoist [Wed, 12 Jun 2019 15:42:22 +0000 (17:42 +0200)]
Merge pull request #4006 from wallabag/add-sponsor-badge
Create FUNDING.yml
Jérémy Benoist [Wed, 12 Jun 2019 08:48:46 +0000 (10:48 +0200)]
Create FUNDING.yml
Jérémy Benoist [Wed, 12 Jun 2019 05:24:36 +0000 (07:24 +0200)]
Merge pull request #4004 from wallabag/dependabot/composer/php-http/httplug-bundle-1.16.0
Bump php-http/httplug-bundle from 1.15.2 to 1.16.0
dependabot-preview[bot] [Wed, 12 Jun 2019 02:18:54 +0000 (02:18 +0000)]
Bump php-http/httplug-bundle from 1.15.2 to 1.16.0
Bumps [php-http/httplug-bundle](https://github.com/php-http/HttplugBundle) from 1.15.2 to 1.16.0.
- [Release notes](https://github.com/php-http/HttplugBundle/releases)
- [Changelog](https://github.com/php-http/HttplugBundle/blob/master/CHANGELOG.md)
- [Commits](https://github.com/php-http/HttplugBundle/compare/1.15.2...1.16.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Jérémy Benoist [Tue, 11 Jun 2019 08:47:45 +0000 (10:47 +0200)]
Merge pull request #3999 from wallabag/dependabot/composer/symfony/phpunit-bridge-4.3.1
Bump symfony/phpunit-bridge from 4.3.0 to 4.3.1
dependabot-preview[bot] [Tue, 11 Jun 2019 07:20:04 +0000 (07:20 +0000)]
Bump symfony/phpunit-bridge from 4.3.0 to 4.3.1
Bumps [symfony/phpunit-bridge](https://github.com/symfony/phpunit-bridge) from 4.3.0 to 4.3.1.
- [Release notes](https://github.com/symfony/phpunit-bridge/releases)
- [Changelog](https://github.com/symfony/phpunit-bridge/blob/master/CHANGELOG.md)
- [Commits](https://github.com/symfony/phpunit-bridge/compare/v4.3.0...v4.3.1)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Jérémy Benoist [Tue, 11 Jun 2019 07:12:54 +0000 (09:12 +0200)]
Merge pull request #3998 from wallabag/dependabot/composer/doctrine/doctrine-fixtures-bundle-3.2.0
Bump doctrine/doctrine-fixtures-bundle from 3.1.0 to 3.2.0
dependabot-preview[bot] [Tue, 11 Jun 2019 02:26:46 +0000 (02:26 +0000)]
Bump doctrine/doctrine-fixtures-bundle from 3.1.0 to 3.2.0
Bumps [doctrine/doctrine-fixtures-bundle](https://github.com/doctrine/DoctrineFixturesBundle) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/doctrine/DoctrineFixturesBundle/releases)
- [Changelog](https://github.com/doctrine/DoctrineFixturesBundle/blob/master/CHANGELOG-3.1.md)
- [Commits](https://github.com/doctrine/DoctrineFixturesBundle/compare/3.1.0...3.2.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Jeremy Benoist [Thu, 6 Jun 2019 13:14:41 +0000 (15:14 +0200)]
Update translations
Thomas Citharel [Thu, 6 Jun 2019 12:09:23 +0000 (14:09 +0200)]
Show untagged entries count on tag list (#3993)
Show untagged entries count on tag list
Jeremy Benoist [Thu, 6 Jun 2019 11:51:25 +0000 (13:51 +0200)]
Display login in config / user
Just so the user can see its login
Jeremy Benoist [Thu, 6 Jun 2019 11:34:20 +0000 (13:34 +0200)]
Remove link when there are no untagged articles
Jérémy Benoist [Thu, 6 Jun 2019 10:03:37 +0000 (12:03 +0200)]
Merge pull request #3959 from wallabag/mig-tag-collation
mysql: change collation of tag label
Kevin Decherf [Wed, 5 Jun 2019 16:32:21 +0000 (18:32 +0200)]
Merge pull request #3994 from wallabag/feature/revoke-feed-token
Add ability to revoke feed token
Jeremy Benoist [Wed, 5 Jun 2019 15:55:13 +0000 (17:55 +0200)]
Add ability to revoke feed token
Jérémy Benoist [Wed, 5 Jun 2019 15:13:21 +0000 (17:13 +0200)]
Merge pull request #3992 from wallabag/feature/menu-quickstart
Add quickstart into the menu
Jeremy Benoist [Wed, 5 Jun 2019 15:09:05 +0000 (17:09 +0200)]
Fix typo & CS
Kevin Decherf [Sun, 2 Sep 2018 14:43:49 +0000 (16:43 +0200)]
Show untagged entries count on tag list
Closes #3235
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Jeremy Benoist [Wed, 5 Jun 2019 13:51:22 +0000 (15:51 +0200)]
Add quickstart into the menu
Just in case people want to see that page again.
Jérémy Benoist [Wed, 5 Jun 2019 12:41:42 +0000 (14:41 +0200)]
Merge pull request #3990 from wallabag/feature/sentry
Add Sentry support
Jérémy Benoist [Wed, 5 Jun 2019 12:37:11 +0000 (14:37 +0200)]
Merge pull request #3991 from wallabag/fix/secret
Try to force people to update the secret
Jérémy Benoist [Wed, 5 Jun 2019 12:14:17 +0000 (14:14 +0200)]
Try to force people to update the secret
Jeremy Benoist [Wed, 5 Jun 2019 11:15:15 +0000 (13:15 +0200)]
Add Sentry support
Only enable in production
Jérémy Benoist [Wed, 5 Jun 2019 09:38:00 +0000 (11:38 +0200)]
Merge pull request #3271 from wallabag/store-resolved-url
Add `given_url` in Entry table to check if a redirected url has already added
Jeremy Benoist [Wed, 5 Jun 2019 08:54:43 +0000 (10:54 +0200)]
Typos
Jeremy Benoist [Wed, 5 Jun 2019 08:51:06 +0000 (10:51 +0200)]
Use two indexes instead of one for hashed urls
When using `OR` in a where clause, a composite index can't be used. We should use a `UNION` to take advantages of it.
Instead, create 2 indexes on each hashed urls and make 2 queries to find an url. It'll be faster than the previous solution.
Jérémy Benoist [Wed, 29 May 2019 19:00:36 +0000 (21:00 +0200)]
Merge pull request #3987 from wallabag/fix/drop-simplepie
Drop SimplePie
Jeremy Benoist [Wed, 29 May 2019 15:05:12 +0000 (17:05 +0200)]
Drop SimplePie
It was only used to make an absolute url when downloading images.
The deps is still there (in the `composer.lock`) because Graby use it (not for absolute but for encoding).
Jeremy Benoist [Wed, 29 May 2019 12:18:04 +0000 (14:18 +0200)]
Use hash given url to avoid duplicate
Using hashed url we can ensure an index on them to ensure it's fast.
Jérémy Benoist [Wed, 29 May 2019 12:40:01 +0000 (14:40 +0200)]
Merge pull request #3986 from wallabag/fix/scrutinizer-issues
Fix some Scrutinizer issues
Nicolas Lœuillet [Mon, 10 Jul 2017 19:32:25 +0000 (21:32 +0200)]
Added given_url in entry table
- Added index on entry table for given_url field
- Fix tests:
The previous `bit.ly` url redirected to doc.wallabag but that url doesn't exist in the fixtures.
I used our own internal "redirector" to create a redirect to an url which exist in the fixtures.
Also, updating current migration to use the new `WallabagMigration`.
Jeremy Benoist [Wed, 29 May 2019 10:00:23 +0000 (12:00 +0200)]
Fix some Scrutinizer issues
Jérémy Benoist [Wed, 29 May 2019 10:49:32 +0000 (12:49 +0200)]
Merge pull request #3985 from wallabag/update-composer
Keep composer.lock
Jeremy Benoist [Wed, 29 May 2019 10:02:24 +0000 (12:02 +0200)]
Typos
Jeremy Benoist [Wed, 29 May 2019 09:41:07 +0000 (11:41 +0200)]
Keep composer.lock
We initially ignored the `composer.lock` because it generated a lock of rebase on PR when someone updated it and the master updated it too.
Now we have less contributions (sadly) so I think we won't run against that problem.
Also, it'll solve issue about people cloning the master and got angry because composer eat all the available memory to determine packages to install.
It'll also be much easier to make release.
Scrutinizer & Travis will be faster too.
Jérémy Benoist [Wed, 29 May 2019 09:14:00 +0000 (11:14 +0200)]
Merge pull request #3984 from wallabag/2.4
Merge 2.4 into master
Jérémy Benoist [Tue, 28 May 2019 12:18:33 +0000 (14:18 +0200)]
Merge pull request #3944 from shtrom/always-hash-exists-url
Always hash exists url
Jérémy Benoist [Tue, 28 May 2019 12:00:22 +0000 (14:00 +0200)]
Merge pull request #3390 from
aaa2000 /httplug
Use httplug and graby 2.0
Jeremy Benoist [Tue, 28 May 2019 10:02:17 +0000 (12:02 +0200)]
Fix tests after rebase
Jeremy Benoist [Mon, 11 Feb 2019 09:59:56 +0000 (10:59 +0100)]
CS & fix tests
Jeremy Benoist [Thu, 7 Feb 2019 16:56:05 +0000 (17:56 +0100)]
Fix some tests
Jeremy Benoist [Thu, 7 Feb 2019 16:30:38 +0000 (17:30 +0100)]
CS
Jeremy Benoist [Mon, 28 Jan 2019 05:10:26 +0000 (06:10 +0100)]
CS
adev [Sun, 12 Nov 2017 11:15:02 +0000 (12:15 +0100)]
Configure timeout
adev [Sat, 11 Nov 2017 19:04:15 +0000 (20:04 +0100)]
Fix because of some breaking changes of Graby 2.0
adev [Tue, 24 Oct 2017 20:55:40 +0000 (22:55 +0200)]
Use httplug
Jeremy Benoist [Mon, 27 May 2019 08:46:01 +0000 (10:46 +0200)]
Merge remote-tracking branch 'origin/master' into 2.4
Jérémy Benoist [Mon, 27 May 2019 08:22:03 +0000 (10:22 +0200)]
Merge pull request #3982 from wallabag/fix/https-test
Fix http/https test
Jeremy Benoist [Mon, 27 May 2019 07:38:07 +0000 (09:38 +0200)]
Fix test
Kevin Decherf [Sun, 26 May 2019 15:47:44 +0000 (17:47 +0200)]
Merge pull request #3965 from nicofrand/previewPic
Preview picture: use the 1st pic retrieved if no og:image set
Jérémy Benoist [Fri, 24 May 2019 14:03:05 +0000 (16:03 +0200)]
Merge pull request #3980 from wallabag/fix/instapaper-date-import
Fix Instapaper import date order
Jeremy Benoist [Fri, 24 May 2019 13:43:30 +0000 (15:43 +0200)]
Remove useless methods
Also fix a phpdoc block
Jeremy Benoist [Fri, 24 May 2019 13:15:12 +0000 (15:15 +0200)]
Change the way to define algorithm for hashing url
Olivier Mehani [Fri, 10 May 2019 12:07:55 +0000 (22:07 +1000)]
Add Wallabag\CoreBundle\Helper\UrlHasher
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
Olivier Mehani [Fri, 3 May 2019 12:23:04 +0000 (22:23 +1000)]
Delegate findByUrlAndUserId to findByHashedUrlAndUserId
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
Olivier Mehani [Thu, 2 May 2019 11:19:20 +0000 (21:19 +1000)]
EntryRestController::getEntriesExistsAction: always find by hashed url
Simplify the logic from #3158 by hashing all the urls from the request,
and only doing a search by hash. This allows to get performance benefits
from the new indexed hash column even when using older clients that do
not hash the URL in the request.
Fixes: #3158, #3919
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
Jeremy Benoist [Fri, 24 May 2019 12:37:54 +0000 (14:37 +0200)]
Fix Instapaper import date
Jérémy Benoist [Thu, 23 May 2019 09:57:07 +0000 (11:57 +0200)]
Merge pull request #3977 from wallabag/fix/7.2-dockerfile
Force PHP version in Dockerfile
Jérémy Benoist [Thu, 23 May 2019 06:51:54 +0000 (08:51 +0200)]
Force PHP version in Dockerfile
nicofrand [Tue, 21 May 2019 18:10:57 +0000 (20:10 +0200)]
[tests] Fix pre-existing tests (preview now imported + records added)
nicofrand [Mon, 13 May 2019 19:56:52 +0000 (21:56 +0200)]
[tests] Set first picture as preview picture
nicofrand [Fri, 10 May 2019 21:01:07 +0000 (23:01 +0200)]
Set first picture as preview picture
Jérémy Benoist [Tue, 21 May 2019 09:18:19 +0000 (11:18 +0200)]
Merge pull request #3960 from wallabag/api-entries-2817
api/entries: add parameter detail to exclude or include content in response
Kevin Decherf [Sat, 11 May 2019 18:07:38 +0000 (20:07 +0200)]
mysql: change collation of tag table
utf8mb4_unicode_ci considers that 'caché' is equal to 'cache' which
can lead to attaching incorrect tags to entries. This issue is due to
some unicode normalization done by MySQL.
utf8mb4_bin makes no unicode normalization, letting wallabag to consider
'cache' and 'caché' as two different tags.
We change the collation of the whole table as Doctrine does not support
setting a collation on a column for a specific platform (it tries to
apply utf8mb4_bin even for pgsql and sqlite).
Fixes #3302
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Kevin Decherf [Sat, 11 May 2019 22:00:00 +0000 (00:00 +0200)]
api/entries: add parameter detail to exclude or include content in response
detail=metadata will nullify the content field of entries in order to
make smaller responses.
detail=full keeps the former behavior, it sends the content of entries.
It's the default, for backward compatibility.
Fixes #2817
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Jeremy Benoist [Wed, 15 May 2019 12:58:40 +0000 (14:58 +0200)]
CS
Jeremy Benoist [Wed, 15 May 2019 12:38:07 +0000 (14:38 +0200)]
Merge remote-tracking branch 'origin/master' into 2.4
Jérémy Benoist [Tue, 14 May 2019 09:14:37 +0000 (11:14 +0200)]
Merge pull request #3966 from wallabag/prepare-2.3.8
Prepare 2.3.8 release
Jeremy Benoist [Tue, 14 May 2019 08:16:46 +0000 (10:16 +0200)]
Prepare 2.3.8 release
Kevin Decherf [Tue, 14 May 2019 07:36:46 +0000 (09:36 +0200)]
Merge pull request #3964 from wallabag/fix/intl
Fix Intl Locale issue
Jeremy Benoist [Mon, 13 May 2019 11:35:43 +0000 (13:35 +0200)]
Fix Intl Locale issue
Some issue appeared after the release of PHP 7.2.17 about Intl Memory
Leak / infinite loop.
To fix it we should upgrade to Symfony 3.4 (which is done in wallabag
2.4) but for the 2.3 branch, we'll use a temporary fix for the Locale
issue.
Jérémy Benoist [Mon, 13 May 2019 04:41:16 +0000 (06:41 +0200)]
Merge pull request #3956 from wallabag/fix/delete-cascade-oauth2
Cascade delete on oauth2 table when deleting a user
Jérémy Benoist [Mon, 13 May 2019 04:40:16 +0000 (06:40 +0200)]
Merge pull request #3922 from burkemw3/patch-5
Remove preview picture from share view page for #1875
Kevin Decherf [Sun, 12 May 2019 21:44:33 +0000 (23:44 +0200)]
Merge pull request #3943 from wallabag/img-referrer
Enable no-referrer on img tags, enable strict-origin-when-cross-origin by default
Matt Burke [Thu, 18 Apr 2019 02:21:17 +0000 (22:21 -0400)]
Remove preview picture from share view page for #1875
Essentially, same as commit
038fccd for single entry views. From that commit:
> Showing the preview picture usually leads to showing a duplicate
> image, and frequently leads to showing duplicate images directly
> adjacent to each other.
Kevin Decherf [Fri, 10 May 2019 21:08:23 +0000 (23:08 +0200)]
assets: regenerate material.css
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Kevin Decherf [Wed, 1 May 2019 12:05:38 +0000 (14:05 +0200)]
Enable no-referrer on img tags, enable strict-origin-when-cross-origin by default
Fixes #3889
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>