]> git.immae.eu Git - github/wallabag/wallabag.git/log
github/wallabag/wallabag.git
7 years agoUse an alternative way to detect image 3184/head
Jeremy Benoist [Mon, 5 Jun 2017 20:54:02 +0000 (22:54 +0200)] 
Use an alternative way to detect image

When parsing content to retrieve images to save locally, we only check for the content-type of the image response.
In some case, that value is empty.
Now we’re also checking for the first few bytes of the content as an alternative to detect if it’s an image wallabag can handle.
We might get higher image supports using that alternative method.

7 years agoMerge pull request #2708 from jcharaoui/import-disablecontentupdate
Jérémy Benoist [Fri, 2 Jun 2017 09:26:37 +0000 (11:26 +0200)] 
Merge pull request #2708 from jcharaoui/import-disablecontentupdate

Import disableContentUpdate

7 years agoMerge pull request #3176 from wallabag/fix-image-download
Nicolas Lœuillet [Fri, 2 Jun 2017 07:12:11 +0000 (09:12 +0200)] 
Merge pull request #3176 from wallabag/fix-image-download

Replace images with & in url

7 years agoCS 3176/head
Jeremy Benoist [Thu, 1 Jun 2017 20:58:38 +0000 (22:58 +0200)] 
CS

7 years agoReplace images with &
Jeremy Benoist [Thu, 1 Jun 2017 20:50:33 +0000 (22:50 +0200)] 
Replace images with &

Images with `&` in the path weren’t well replaced because they might be with `&` in the html instead.

Replacing `&` with `&` fix the problem.

7 years agoFix option attributes 2708/head
Jeremy Benoist [Thu, 1 Jun 2017 13:44:36 +0000 (15:44 +0200)] 
Fix option attributes

7 years agoMerge pull request #3171 from wallabag/drop-fucking-sqlite
Nicolas Lœuillet [Thu, 1 Jun 2017 12:46:01 +0000 (14:46 +0200)] 
Merge pull request #3171 from wallabag/drop-fucking-sqlite

Defined MySQL as the default rdbms for wallabag

7 years agoWe don't need that getter
Jeremy Benoist [Thu, 1 Jun 2017 10:46:07 +0000 (12:46 +0200)] 
We don't need that getter

7 years agoNo need to catch that Exception
Jeremy Benoist [Thu, 1 Jun 2017 09:45:02 +0000 (11:45 +0200)] 
No need to catch that Exception

7 years agoRewrote code & fix tests
Jeremy Benoist [Thu, 1 Jun 2017 09:31:45 +0000 (11:31 +0200)] 
Rewrote code & fix tests

7 years agoMerge pull request #3172 from wallabag/more-scruti
Jérémy Benoist [Thu, 1 Jun 2017 08:29:32 +0000 (10:29 +0200)] 
Merge pull request #3172 from wallabag/more-scruti

More Scrutinizer issues fixed

7 years agoCS
Jeremy Benoist [Thu, 1 Jun 2017 07:52:09 +0000 (09:52 +0200)] 
CS

7 years agoFix tests
Jeremy Benoist [Tue, 30 May 2017 15:48:24 +0000 (17:48 +0200)] 
Fix tests

7 years agoCS
Jeremy Benoist [Tue, 30 May 2017 14:21:25 +0000 (16:21 +0200)] 
CS

7 years agoReplace Wallabag v1 error strings with v2 strings
Jerome Charaoui [Fri, 16 Dec 2016 14:46:21 +0000 (09:46 -0500)] 
Replace Wallabag v1 error strings with v2 strings

7 years agoAdd disableContentUpdate import option
Jerome Charaoui [Wed, 7 Dec 2016 20:16:49 +0000 (15:16 -0500)] 
Add disableContentUpdate import option

This commit also decouples the "import" and "update" functions inside
ContentProxy. If a content array is available, it must be passed to the
new importEntry method.

7 years agoPut default fetching error title in global config
Jerome Charaoui [Wed, 7 Dec 2016 03:27:08 +0000 (22:27 -0500)] 
Put default fetching error title in global config

7 years agoAvoid returning objects passed by reference.
Jerome Charaoui [Wed, 7 Dec 2016 03:17:44 +0000 (22:17 -0500)] 
Avoid returning objects passed by reference.

Objects are always passed by reference, so it doesn't make sense to
return an object which is passed by reference as it will always be the
same object. This change makes the code a bit more readable.

7 years agofixup! Set the right variable type 3172/head
Jeremy Benoist [Thu, 1 Jun 2017 07:36:01 +0000 (09:36 +0200)] 
fixup! Set the right variable type

7 years agoBoth parameter wasn't used in the function, removing them
Jeremy Benoist [Thu, 1 Jun 2017 07:30:38 +0000 (09:30 +0200)] 
Both parameter wasn't used in the function, removing them

7 years agoSet the right variable type
Jeremy Benoist [Thu, 1 Jun 2017 07:30:20 +0000 (09:30 +0200)] 
Set the right variable type

7 years agoPage parameter was never used in the function
Jeremy Benoist [Thu, 1 Jun 2017 07:29:16 +0000 (09:29 +0200)] 
Page parameter was never used in the function

It could have been used if we set the current page inside PreparePagerForEntries.
But we did that in each controller because we can have an OutOfRangeCurrentPageException

7 years agoChanged default database name 3171/head
Nicolas Lœuillet [Thu, 1 Jun 2017 07:17:05 +0000 (09:17 +0200)] 
Changed default database name

7 years agoMerge pull request #3137 from aaa2000/isolated-tests
Jérémy Benoist [Thu, 1 Jun 2017 05:58:17 +0000 (07:58 +0200)] 
Merge pull request #3137 from aaa2000/isolated-tests

Isolated tests

7 years agoFixed @tcitworld 's review
Nicolas Lœuillet [Wed, 31 May 2017 20:50:18 +0000 (22:50 +0200)] 
Fixed @tcitworld 's review

7 years agoDefined MySQL as the default rdbms for wallabag
Nicolas Lœuillet [Wed, 31 May 2017 20:36:21 +0000 (22:36 +0200)] 
Defined MySQL as the default rdbms for wallabag

7 years agoMerge pull request #3077 from wallabag/add-tags-list-view
Nicolas Lœuillet [Wed, 31 May 2017 19:18:14 +0000 (21:18 +0200)] 
Merge pull request #3077 from wallabag/add-tags-list-view

Added tags on list view

7 years agoReduced border-radius for tags 3077/head
Nicolas Lœuillet [Wed, 31 May 2017 18:31:35 +0000 (20:31 +0200)] 
Reduced border-radius for tags

7 years agoMerge pull request #3106 from wallabag/api-content
Jérémy Benoist [Wed, 31 May 2017 15:26:05 +0000 (17:26 +0200)] 
Merge pull request #3106 from wallabag/api-content

Allow other fields to be send using API

7 years agoIsolated tests 3137/head
adev [Mon, 15 May 2017 18:47:59 +0000 (20:47 +0200)] 
Isolated tests

Use https://github.com/dmaicher/doctrine-test-bundle to have test isolation.

7 years agoAdd some flex magic
Thomas Citharel [Wed, 31 May 2017 12:34:46 +0000 (14:34 +0200)] 
Add some flex magic

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
7 years agoPR has been merged in graby 3106/head
Jérémy Benoist [Tue, 30 May 2017 16:11:55 +0000 (18:11 +0200)] 
PR has been merged in graby

7 years agoFix tests following rebase
Jeremy Benoist [Tue, 30 May 2017 08:08:50 +0000 (10:08 +0200)] 
Fix tests following rebase

7 years agoCS
Jeremy Benoist [Mon, 29 May 2017 08:14:01 +0000 (10:14 +0200)] 
CS

7 years agoForced date can now be a timestamp too
Jeremy Benoist [Wed, 24 May 2017 14:44:03 +0000 (16:44 +0200)] 
Forced date can now be a timestamp too

Add adding more tests for forced content

7 years agoImprove docs
Jeremy Benoist [Wed, 24 May 2017 14:02:49 +0000 (16:02 +0200)] 
Improve docs

7 years agoRemove htmlawed and use graby instead
Jeremy Benoist [Tue, 16 May 2017 21:11:20 +0000 (23:11 +0200)] 
Remove htmlawed and use graby instead

Instead of using htmlawed (which is already used in graby) use graby directly (which require some refacto on graby side).
Still needs some tests.

7 years agoReduce imported entries
Jeremy Benoist [Tue, 16 May 2017 19:17:10 +0000 (21:17 +0200)] 
Reduce imported entries

Down from 2.2 minutes to 1.39 minutes

7 years agoUse graby ContentExtractor to clean html
Jeremy Benoist [Fri, 12 May 2017 05:53:21 +0000 (07:53 +0200)] 
Use graby ContentExtractor to clean html

It might be better to re-use some graby functionalities to clean html instead of building a new system.

7 years agoAdd support for authors
Jeremy Benoist [Thu, 11 May 2017 18:10:22 +0000 (20:10 +0200)] 
Add support for authors

7 years agoAllow other fields to be send using API
Jeremy Benoist [Thu, 11 May 2017 06:14:29 +0000 (08:14 +0200)] 
Allow other fields to be send using API

Entry API can now have these new fields:
- content
- language
- preview_picture
- published_at

Re-use the ContentProxy to be able to do the same using the web UI (in the future).
htmLawed is used to clean stuff from content, I hope it’ll be enough to avoid security breach.

Lower content validation when we want to update an entry with content already defined. Before, language & content_type were required. If there weren’t provided, we re-fetched the content using graby. I think these fields aren’t required for an entry to be created. So I removed them.
Which means some import from the v1 export won’t be re-fetched since they provide content, url & title.

Also, remove liberation link from Readability import to avoid overlaping import (from wallabag v1, which had the same link)

7 years agoFixed tags display on grid view
Nicolas Lœuillet [Mon, 29 May 2017 08:59:30 +0000 (10:59 +0200)] 
Fixed tags display on grid view

7 years agoMerge pull request #3168 from wallabag/instapaper-tags-import
Nicolas Lœuillet [Wed, 31 May 2017 10:32:09 +0000 (12:32 +0200)] 
Merge pull request #3168 from wallabag/instapaper-tags-import

Add support for tag in Instapaper import

7 years agoMerge pull request #3138 from Kdecherf/2835-tags
Nicolas Lœuillet [Wed, 31 May 2017 09:48:42 +0000 (11:48 +0200)] 
Merge pull request #3138 from Kdecherf/2835-tags

Ignore ActionMarkAsRead when removing tag from entry

7 years agoMerge pull request #3161 from wallabag/scrutinizer-2.3
Nicolas Lœuillet [Wed, 31 May 2017 09:46:41 +0000 (11:46 +0200)] 
Merge pull request #3161 from wallabag/scrutinizer-2.3

Fix some Scrutinizer issues

7 years agoEnsure retrieved data are fresh 3138/head
Jeremy Benoist [Wed, 31 May 2017 09:11:02 +0000 (11:11 +0200)] 
Ensure retrieved data are fresh

7 years agoCS & improve tags assertions 3168/head
Jeremy Benoist [Wed, 31 May 2017 08:38:15 +0000 (10:38 +0200)] 
CS & improve tags assertions

7 years agoAdd support for tag in Instapaper import
Jeremy Benoist [Wed, 31 May 2017 08:38:00 +0000 (10:38 +0200)] 
Add support for tag in Instapaper import

7 years agoMerge pull request #3143 from wallabag/fix-wllbg2-import
Nicolas Lœuillet [Wed, 31 May 2017 07:08:34 +0000 (09:08 +0200)] 
Merge pull request #3143 from wallabag/fix-wllbg2-import

Fixed is_starred for wallabag v2 import

7 years agoTagController: ignore ActionMarkAsRead when removing tag from entry
Kevin Decherf [Sun, 21 May 2017 14:35:06 +0000 (16:35 +0200)] 
TagController: ignore ActionMarkAsRead when removing tag from entry

Fixes #2835

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
7 years agoAdd tests 3143/head
Jeremy Benoist [Tue, 30 May 2017 18:15:41 +0000 (20:15 +0200)] 
Add tests

7 years agoMerge pull request #3065 from wallabag/api-creation-endpoint
Jérémy Benoist [Tue, 30 May 2017 13:26:11 +0000 (15:26 +0200)] 
Merge pull request #3065 from wallabag/api-creation-endpoint

Register through API

7 years agoCS 3161/head
Jeremy Benoist [Tue, 30 May 2017 11:01:25 +0000 (13:01 +0200)] 
CS

7 years agoUse a better way to set input for command
Jeremy Benoist [Tue, 30 May 2017 10:47:25 +0000 (12:47 +0200)] 
Use a better way to set input for command

Actually use the correct to way handle that

http://symfony.com/doc/current/components/console/helpers/questionhelper.html#testing-a-command-that-expects-input

7 years agoFix some Scrutinizer issues
Jeremy Benoist [Tue, 30 May 2017 09:39:15 +0000 (11:39 +0200)] 
Fix some Scrutinizer issues

7 years agoMerge remote-tracking branch 'origin/master' into 2.3
Jeremy Benoist [Tue, 30 May 2017 07:59:06 +0000 (09:59 +0200)] 
Merge remote-tracking branch 'origin/master' into 2.3

7 years agoAvoid side effect on other tests 3065/head
Jeremy Benoist [Tue, 30 May 2017 07:57:57 +0000 (09:57 +0200)] 
Avoid side effect on other tests

7 years agoAdded tags on list view
Nicolas Lœuillet [Wed, 3 May 2017 09:48:43 +0000 (11:48 +0200)] 
Added tags on list view

7 years agoMerge pull request #3147 from wallabag/delete-confirm
Jérémy Benoist [Tue, 30 May 2017 07:42:56 +0000 (09:42 +0200)] 
Merge pull request #3147 from wallabag/delete-confirm

Add some deletion confirmation to avoid mistake

7 years agoMerge pull request #3160 from wallabag/mruminski-patch-1 3147/head
Jérémy Benoist [Tue, 30 May 2017 07:10:54 +0000 (09:10 +0200)] 
Merge pull request #3160 from wallabag/mruminski-patch-1

Update messages.pl.yml

7 years agoRemove unknown validation_groups
Jeremy Benoist [Tue, 30 May 2017 05:56:41 +0000 (07:56 +0200)] 
Remove unknown validation_groups

The Profile validation_groups does not exist and then for validation to be skipped (like password length)

7 years agoRe-use `NewUserType` to validate registration
Jeremy Benoist [Tue, 30 May 2017 05:56:01 +0000 (07:56 +0200)] 
Re-use `NewUserType` to validate registration

The only ugly things is how we handle error by generating the view and then parse the content to retrieve all errors…

Fix exposition fields in User entity

7 years agoUpdate messages.pl.yml 3160/head
Mateusz Rumiński [Mon, 29 May 2017 21:47:00 +0000 (23:47 +0200)] 
Update messages.pl.yml

add missing translation

7 years agoupdate :de: messages.de.yml
Sven Fischer [Mon, 29 May 2017 19:10:00 +0000 (21:10 +0200)] 
update :de: messages.de.yml

7 years agoWIP
Thomas Citharel [Sat, 29 Apr 2017 17:22:50 +0000 (19:22 +0200)] 
WIP

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
7 years agoMerge pull request #3153 from wallabag/content-proxy-refactor
Thomas Citharel [Sun, 28 May 2017 19:50:23 +0000 (21:50 +0200)] 
Merge pull request #3153 from wallabag/content-proxy-refactor

Move Tags assigner to a separate file

7 years agoCS 3153/head
Thomas Citharel [Sun, 28 May 2017 10:59:48 +0000 (12:59 +0200)] 
CS

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
7 years agoCS
Thomas Citharel [Sat, 27 May 2017 23:16:01 +0000 (01:16 +0200)] 
CS

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
7 years agoMove Tags assigner to a separate file
Thomas Citharel [Sat, 27 May 2017 20:08:14 +0000 (22:08 +0200)] 
Move Tags assigner to a separate file

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
7 years agoAdd some deletion confirmation to avoid mistake
Jeremy Benoist [Wed, 24 May 2017 19:33:37 +0000 (21:33 +0200)] 
Add some deletion confirmation to avoid mistake

7 years agoFixed is_starred for wallabag v2 import
Nicolas Lœuillet [Tue, 23 May 2017 15:07:26 +0000 (17:07 +0200)] 
Fixed is_starred for wallabag v2 import

7 years agoMerge pull request #3145 from wallabag/fix-so
Jérémy Benoist [Wed, 24 May 2017 12:33:58 +0000 (14:33 +0200)] 
Merge pull request #3145 from wallabag/fix-so

Fix SO tests

7 years agoMerge pull request #3146 from DamienCassou/fix-doc-url
Jérémy Benoist [Wed, 24 May 2017 11:54:57 +0000 (13:54 +0200)] 
Merge pull request #3146 from DamienCassou/fix-doc-url

Fix documentation URL for "How can I help to fix that?"

7 years agoFix documentation URL for "How can I help to fix that?" 3146/head
Damien Cassou [Wed, 24 May 2017 10:57:46 +0000 (12:57 +0200)] 
Fix documentation URL for "How can I help to fix that?"

7 years agoFix SO tests 3145/head
Jeremy Benoist [Wed, 24 May 2017 10:13:24 +0000 (12:13 +0200)] 
Fix SO tests

SO switched to http yesterday

7 years agoSwitch back to latest guzzle-site-authenticator
Jeremy Benoist [Wed, 24 May 2017 05:29:46 +0000 (07:29 +0200)] 
Switch back to latest guzzle-site-authenticator

7 years agoMerge pull request #3133 from wallabag/testing-travis-failure
Jérémy Benoist [Fri, 19 May 2017 11:58:37 +0000 (13:58 +0200)] 
Merge pull request #3133 from wallabag/testing-travis-failure

Let's play !

7 years agoEnsure download_images_enabled is disabled 3133/head
Jeremy Benoist [Fri, 19 May 2017 10:41:31 +0000 (12:41 +0200)] 
Ensure download_images_enabled is disabled

Even if the tests fail, that config must stay disabled after the test.
Otherwise it might timeout on other test (because it'll try to save all other images)

7 years agoFold migrations & fixtures command on Travis
Jeremy Benoist [Fri, 19 May 2017 09:41:10 +0000 (11:41 +0200)] 
Fold migrations & fixtures command on Travis

7 years agoMerge remote-tracking branch 'origin/master' into 2.3
Jeremy Benoist [Fri, 19 May 2017 09:25:19 +0000 (11:25 +0200)] 
Merge remote-tracking branch 'origin/master' into 2.3

7 years agoMerge pull request #3130 from X-dark/master
Jérémy Benoist [Fri, 19 May 2017 08:07:01 +0000 (10:07 +0200)] 
Merge pull request #3130 from X-dark/master

unify Download/Export wording.

7 years agomodify key name as well 3130/head
Cedric Girard [Thu, 18 May 2017 15:17:21 +0000 (17:17 +0200)] 
modify key name as well

7 years agounify Download/Export wording.
Cedric Girard [Thu, 18 May 2017 13:23:48 +0000 (15:23 +0200)] 
unify Download/Export wording.

This fixes #2967

7 years agoUpdate of the oc version of CoreBundle
Quent-in [Thu, 18 May 2017 08:44:15 +0000 (10:44 +0200)] 
Update of the oc version of CoreBundle

I hope I didn't break everything with the ' and ".

7 years agoMerge pull request #3125 from wallabag/prepare-222
Jérémy Benoist [Wed, 17 May 2017 15:48:51 +0000 (17:48 +0200)] 
Merge pull request #3125 from wallabag/prepare-222

Prepare wallabag 2.2.3

7 years agoPrepare wallabag 2.2.3 3125/head
Nicolas Lœuillet [Wed, 17 May 2017 12:43:17 +0000 (14:43 +0200)] 
Prepare wallabag 2.2.3

7 years agoMerge pull request #3122 from wallabag/delete-doc
Thomas Citharel [Wed, 17 May 2017 09:57:28 +0000 (11:57 +0200)] 
Merge pull request #3122 from wallabag/delete-doc

Removed embedded documentation

7 years agoMerge pull request #3117 from wallabag/fix-doc
Nicolas Lœuillet [Wed, 17 May 2017 08:40:35 +0000 (10:40 +0200)] 
Merge pull request #3117 from wallabag/fix-doc

Fixed documentation URL

7 years agoFixed documentation URL 3117/head
Nicolas Lœuillet [Sat, 13 May 2017 07:33:19 +0000 (09:33 +0200)] 
Fixed documentation URL

7 years agoMerge pull request #3124 from wallabag/lock-guzzle-auth
Nicolas Lœuillet [Wed, 17 May 2017 07:02:22 +0000 (09:02 +0200)] 
Merge pull request #3124 from wallabag/lock-guzzle-auth

Lock guzzle-site-authenticator to avoid errors

7 years agoLock guzzle-site-authenticator to avoid error 3124/head
Jeremy Benoist [Tue, 16 May 2017 21:34:42 +0000 (23:34 +0200)] 
Lock guzzle-site-authenticator to avoid error

7 years agoMerge pull request #3123 from X-dark/master
Jérémy Benoist [Tue, 16 May 2017 12:50:25 +0000 (14:50 +0200)] 
Merge pull request #3123 from X-dark/master

reorder contrib strings in about page

7 years agoreorder contrib strings in about page 3123/head
Cedric Girard [Tue, 16 May 2017 12:17:13 +0000 (14:17 +0200)] 
reorder contrib strings in about page

this fixes #2891

7 years agoRemoved embedded documentation 3122/head
Nicolas Lœuillet [Tue, 16 May 2017 11:09:40 +0000 (13:09 +0200)] 
Removed embedded documentation

7 years agoMerge pull request #3120 from aaa2000/fix-delete-annotation-user
Jérémy Benoist [Mon, 15 May 2017 09:42:05 +0000 (11:42 +0200)] 
Merge pull request #3120 from aaa2000/fix-delete-annotation-user

Fix delete annotation when username is defined

7 years agoMerge pull request #3113 from wallabag/upgrade-craue
Jérémy Benoist [Mon, 15 May 2017 07:05:08 +0000 (09:05 +0200)] 
Merge pull request #3113 from wallabag/upgrade-craue

Upgraded CraueConfigBundle to 2.0

7 years agoFix delete annotation when username is defined 3120/head
adev [Sun, 14 May 2017 09:38:02 +0000 (11:38 +0200)] 
Fix delete annotation when username is defined

When an user set his name in "Config" > "User Information", he
can't delete or update an annotation

Fix #2382

7 years agoUpgraded CraueConfigBundle to 2.0 3113/head
Nicolas Lœuillet [Fri, 12 May 2017 14:33:12 +0000 (16:33 +0200)] 
Upgraded CraueConfigBundle to 2.0

7 years agoMerge pull request #3110 from wallabag/add-logger-matching-rules
Nicolas Lœuillet [Fri, 12 May 2017 14:17:48 +0000 (16:17 +0200)] 
Merge pull request #3110 from wallabag/add-logger-matching-rules

Added logger when we match Tagging rules

7 years agoAdded tests on logs records 3110/head
Nicolas Lœuillet [Fri, 12 May 2017 13:01:18 +0000 (15:01 +0200)] 
Added tests on logs records