]> git.immae.eu Git - github/Chocobozzz/PeerTube.git/log
github/Chocobozzz/PeerTube.git
3 years agoPrepare changelog
Chocobozzz [Wed, 2 Dec 2020 13:23:10 +0000 (14:23 +0100)] 
Prepare changelog

3 years agoTrigger a Gitpod dev image rebuild (in order to get upstream's Node.js 12 upgrade...
Jan Keromnes [Wed, 2 Dec 2020 10:03:03 +0000 (11:03 +0100)] 
Trigger a Gitpod dev image rebuild (in order to get upstream's Node.js 12 upgrade) (#3388)

* Trigger a Gitpod dev image rebuild (in order to get upstream's Node.js 12 upgrade)

* Update Dockerfile

3 years agoFix live replay duration glitch
Chocobozzz [Wed, 2 Dec 2020 09:07:26 +0000 (10:07 +0100)] 
Fix live replay duration glitch

3 years agoFix duplicate ids in admin config form
Chocobozzz [Tue, 1 Dec 2020 14:11:23 +0000 (15:11 +0100)] 
Fix duplicate ids in admin config form

3 years agoKeep displayName as valid playlist sort
Chocobozzz [Tue, 1 Dec 2020 14:08:59 +0000 (15:08 +0100)] 
Keep displayName as valid playlist sort

3 years agoFix socket io messages angular changes
Chocobozzz [Tue, 1 Dec 2020 14:02:31 +0000 (15:02 +0100)] 
Fix socket io messages angular changes

3 years agoFix 401 error in embeds
Chocobozzz [Tue, 1 Dec 2020 09:43:13 +0000 (10:43 +0100)] 
Fix 401 error in embeds

3 years agoEnable live transcoding by default
Chocobozzz [Tue, 1 Dec 2020 09:29:03 +0000 (10:29 +0100)] 
Enable live transcoding by default

Direct muxing is not robust enough

3 years agoAdd local actor follow url migration
Chocobozzz [Tue, 1 Dec 2020 09:25:11 +0000 (10:25 +0100)] 
Add local actor follow url migration

3 years agoAdd logs to fixture generations
Chocobozzz [Tue, 1 Dec 2020 08:31:45 +0000 (09:31 +0100)] 
Add logs to fixture generations

3 years agoSelect first available channel when accepting ownership change (#3382)
Florian CUNY [Tue, 1 Dec 2020 14:04:29 +0000 (15:04 +0100)] 
Select first available channel when accepting ownership change (#3382)

* Select first available channel when accepting ownership change

Implements https://github.com/Chocobozzz/PeerTube/issues/2240

* Made use of #patchValue() to set the default selected value

And removed the disabled state for the Accept button

3 years agoFix sort fields on Video Playlists
Arman [Tue, 1 Dec 2020 12:56:37 +0000 (16:26 +0330)] 
Fix sort fields  on Video Playlists

displayName does not exist in VideoPlaylistModel, the correct field is `name`

3 years agoFix live saving after a server restart
Chocobozzz [Mon, 30 Nov 2020 16:03:13 +0000 (17:03 +0100)] 
Fix live saving after a server restart

3 years agoFix themes colors by using SCSS variables (#3376)
Mathieu Brunot [Mon, 30 Nov 2020 15:45:22 +0000 (16:45 +0100)] 
Fix themes colors by using SCSS variables (#3376)

* :lipstick: Use foreground var for code

* :lipstick: Use submenu var color

* :lipstick: Use foreground var color for menu

* :bug: Fix var used in menu

3 years agoFix scroll check in infinite scroller directive
Chocobozzz [Mon, 30 Nov 2020 15:33:48 +0000 (16:33 +0100)] 
Fix scroll check in infinite scroller directive

3 years agoFix lint
Chocobozzz [Mon, 30 Nov 2020 15:02:34 +0000 (16:02 +0100)] 
Fix lint

3 years agoFix high CPU with long live when save replay is true
Chocobozzz [Mon, 30 Nov 2020 14:59:22 +0000 (15:59 +0100)] 
Fix high CPU with long live when save replay is true

3 years agoAdd missing "supports markdown" config comments
Chocobozzz [Mon, 30 Nov 2020 14:08:01 +0000 (15:08 +0100)] 
Add missing "supports markdown" config comments

3 years agoAdd inspect to test script
Chocobozzz [Mon, 30 Nov 2020 13:47:54 +0000 (14:47 +0100)] 
Add inspect to test script

3 years agoAdded Markdown formatting in all the fields of the "About" page (#3371)
Florian CUNY [Mon, 30 Nov 2020 14:05:57 +0000 (15:05 +0100)] 
Added Markdown formatting in all the fields of the "About" page (#3371)

* Added Markdown formatting in all the fields of the "About" page

Fixes https://github.com/Chocobozzz/PeerTube/issues/3368

* Fixed compilation error in AboutInstanceComponent

Moved creationReason, maintenanceLifetime and businessModel into the html dict

* Removed textareaHeight for all md textareas in EditCustomConfig HTML

* Fixed failing bundlewatch

3 years ago:sparkles: Add input-password #3375
madmath03 [Fri, 27 Nov 2020 19:51:25 +0000 (19:51 +0000)] 
:sparkles: Add input-password #3375

3 years agoFix browser stack badge
Chocobozzz [Mon, 30 Nov 2020 08:33:20 +0000 (09:33 +0100)] 
Fix browser stack badge

3 years agoTry to fix live tests
Chocobozzz [Mon, 30 Nov 2020 08:16:41 +0000 (09:16 +0100)] 
Try to fix live tests

3 years agoFix local e2e tests
Chocobozzz [Mon, 30 Nov 2020 08:11:12 +0000 (09:11 +0100)] 
Fix local e2e tests

3 years agoFix cors on sha segment endpoint
Chocobozzz [Fri, 27 Nov 2020 16:09:36 +0000 (17:09 +0100)] 
Fix cors on sha segment endpoint

3 years agoFix weblate conflicts
Chocobozzz [Fri, 27 Nov 2020 15:20:05 +0000 (16:20 +0100)] 
Fix weblate conflicts

3 years agoMerge remote-tracking branch 'weblate/develop' into develop
Chocobozzz [Fri, 27 Nov 2020 15:18:50 +0000 (16:18 +0100)] 
Merge remote-tracking branch 'weblate/develop' into develop

3 years agoTranslated using Weblate (Chinese (Traditional))
Jeff Huang [Thu, 26 Nov 2020 02:11:27 +0000 (02:11 +0000)] 
Translated using Weblate (Chinese (Traditional))

Currently translated at 100.0% (1694 of 1694 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/zh_Hant/

3 years agoTranslated using Weblate (Dutch)
Mark Van den Borre [Wed, 25 Nov 2020 22:53:41 +0000 (22:53 +0000)] 
Translated using Weblate (Dutch)

Currently translated at 99.5% (1687 of 1694 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/nl/

3 years agoTranslated using Weblate (Galician)
josé m [Thu, 26 Nov 2020 06:35:13 +0000 (06:35 +0000)] 
Translated using Weblate (Galician)

Currently translated at 100.0% (1694 of 1694 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/gl/

3 years agoTranslated using Weblate (Spanish)
Berto Te [Thu, 26 Nov 2020 23:40:28 +0000 (23:40 +0000)] 
Translated using Weblate (Spanish)

Currently translated at 100.0% (1694 of 1694 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/es/

3 years agoTranslated using Weblate (French (France))
Cedric F [Thu, 26 Nov 2020 11:22:52 +0000 (11:22 +0000)] 
Translated using Weblate (French (France))

Currently translated at 99.3% (1683 of 1694 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/fr_FR/

3 years agoUpdate translations
Chocobozzz [Fri, 27 Nov 2020 15:13:24 +0000 (16:13 +0100)] 
Update translations

3 years agoRefactor last PR
Chocobozzz [Fri, 27 Nov 2020 14:57:38 +0000 (15:57 +0100)] 
Refactor last PR

3 years agoDisable views cleaner on test instances
Chocobozzz [Fri, 27 Nov 2020 14:46:35 +0000 (15:46 +0100)] 
Disable views cleaner on test instances

3 years agoVarious front optimizations
Chocobozzz [Fri, 27 Nov 2020 14:31:09 +0000 (15:31 +0100)] 
Various front optimizations

3 years agoRemove old video views by default
Chocobozzz [Fri, 27 Nov 2020 13:02:25 +0000 (14:02 +0100)] 
Remove old video views by default

3 years agoMore robust live test
Chocobozzz [Fri, 27 Nov 2020 12:47:43 +0000 (13:47 +0100)] 
More robust live test

3 years agoadd title attribute for exact view counters (#3365)
Tanguy BERNARD [Fri, 27 Nov 2020 13:27:14 +0000 (14:27 +0100)] 
add title attribute for exact view counters (#3365)

3 years agoFix notification width
Chocobozzz [Fri, 27 Nov 2020 10:52:18 +0000 (11:52 +0100)] 
Fix notification width

3 years agoFix 500 on unknown thread
Chocobozzz [Fri, 27 Nov 2020 10:48:20 +0000 (11:48 +0100)] 
Fix 500 on unknown thread

3 years agoAdd registered setting CLI plugin install test
Chocobozzz [Fri, 27 Nov 2020 10:41:38 +0000 (11:41 +0100)] 
Add registered setting CLI plugin install test

3 years agoProfile settings title consistency
Chocobozzz [Thu, 26 Nov 2020 15:39:43 +0000 (16:39 +0100)] 
Profile settings title consistency

3 years agoTry to fix live test
Chocobozzz [Thu, 26 Nov 2020 14:16:30 +0000 (15:16 +0100)] 
Try to fix live test

3 years agoCreate a dedicated transcoding tab in admin config
Chocobozzz [Thu, 26 Nov 2020 14:09:57 +0000 (15:09 +0100)] 
Create a dedicated transcoding tab in admin config

3 years agoFix "Too many packets buffered for output stream"
Chocobozzz [Thu, 26 Nov 2020 13:45:48 +0000 (14:45 +0100)] 
Fix "Too many packets buffered for output stream"

And move encoder global options in a global wrapper

3 years agoCount only active lives for account limit
Chocobozzz [Thu, 26 Nov 2020 13:08:31 +0000 (14:08 +0100)] 
Count only active lives for account limit

3 years agoFix live FPS limit
Chocobozzz [Thu, 26 Nov 2020 10:29:50 +0000 (11:29 +0100)] 
Fix live FPS limit

3 years agoDo not display wait transcoding checkbox
Chocobozzz [Thu, 26 Nov 2020 08:30:26 +0000 (09:30 +0100)] 
Do not display wait transcoding checkbox

If this is a live and save replay is not enabled

3 years agoRemove unused i18n build
Chocobozzz [Thu, 26 Nov 2020 07:52:43 +0000 (08:52 +0100)] 
Remove unused i18n build

3 years agoadd My History API to openapi (#3363)
Arman [Wed, 25 Nov 2020 23:27:59 +0000 (02:57 +0330)] 
add My History API to openapi (#3363)

Co-authored-by: Rigel Kent <sendmemail@rigelk.eu>
Co-authored-by: Rigel Kent <par@rigelk.eu>
3 years agoMerge remote-tracking branch 'weblate/develop' into develop
Chocobozzz [Wed, 25 Nov 2020 16:22:36 +0000 (17:22 +0100)] 
Merge remote-tracking branch 'weblate/develop' into develop

3 years agoTranslated using Weblate (Italian)
x [Wed, 25 Nov 2020 15:56:14 +0000 (15:56 +0000)] 
Translated using Weblate (Italian)

Currently translated at 100.0% (1670 of 1670 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/it/

3 years agoTranslated using Weblate (Italian)
x [Wed, 25 Nov 2020 15:54:26 +0000 (15:54 +0000)] 
Translated using Weblate (Italian)

Currently translated at 97.5% (1629 of 1670 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/it/

3 years agoRegen translations
Chocobozzz [Wed, 25 Nov 2020 15:54:59 +0000 (16:54 +0100)] 
Regen translations

3 years agoMerge remote-tracking branch 'weblate/develop' into develop
Chocobozzz [Wed, 25 Nov 2020 15:52:11 +0000 (16:52 +0100)] 
Merge remote-tracking branch 'weblate/develop' into develop

3 years agoUpdate scripts to update translations
Chocobozzz [Wed, 25 Nov 2020 15:52:02 +0000 (16:52 +0100)] 
Update scripts to update translations

3 years agoTranslated using Weblate (Galician)
josé m [Wed, 25 Nov 2020 06:01:03 +0000 (06:01 +0000)] 
Translated using Weblate (Galician)

Currently translated at 100.0% (1670 of 1670 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/gl/

3 years agoTranslated using Weblate (Basque)
Porrumentzio [Mon, 23 Nov 2020 12:48:38 +0000 (12:48 +0000)] 
Translated using Weblate (Basque)

Currently translated at 46.0% (769 of 1670 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/eu/

3 years agoTranslated using Weblate (Korean)
Ch [Mon, 23 Nov 2020 00:13:46 +0000 (00:13 +0000)] 
Translated using Weblate (Korean)

Currently translated at 100.0% (234 of 234 strings)

Translation: PeerTube/server
Translate-URL: https://weblate.framasoft.org/projects/peertube/server/ko/

3 years agoTranslated using Weblate (Thai)
Phongpanot [Mon, 23 Nov 2020 06:58:37 +0000 (06:58 +0000)] 
Translated using Weblate (Thai)

Currently translated at 50.2% (840 of 1670 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/th/

3 years agoTranslated using Weblate (Dutch)
Mark Van den Borre [Sat, 21 Nov 2020 23:48:11 +0000 (23:48 +0000)] 
Translated using Weblate (Dutch)

Currently translated at 100.0% (1670 of 1670 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/nl/

3 years agoTranslated using Weblate (Sardinian)
Ajeje Brazorf [Sat, 21 Nov 2020 14:51:05 +0000 (14:51 +0000)] 
Translated using Weblate (Sardinian)

Currently translated at 3.1% (53 of 1668 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/sc/

3 years agoTranslated using Weblate (Sardinian)
Ajeje Brazorf [Fri, 20 Nov 2020 22:15:07 +0000 (22:15 +0000)] 
Translated using Weblate (Sardinian)

Currently translated at 3.1% (52 of 1668 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/sc/

3 years agoTranslated using Weblate (Sardinian)
Ajeje Brazorf [Fri, 20 Nov 2020 22:14:17 +0000 (22:14 +0000)] 
Translated using Weblate (Sardinian)

Currently translated at 2.8% (47 of 1668 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/sc/

3 years agoTranslated using Weblate (Sardinian)
Adrià Martín [Fri, 20 Nov 2020 17:58:51 +0000 (17:58 +0000)] 
Translated using Weblate (Sardinian)

Currently translated at 2.8% (47 of 1668 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/sc/

3 years agoAdded translation using Weblate (Sardinian)
Adrià Martín [Fri, 20 Nov 2020 17:58:27 +0000 (17:58 +0000)] 
Added translation using Weblate (Sardinian)

3 years agoTranslated using Weblate (Galician)
josé m [Fri, 20 Nov 2020 10:35:49 +0000 (10:35 +0000)] 
Translated using Weblate (Galician)

Currently translated at 100.0% (1670 of 1670 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/gl/

3 years agoTranslated using Weblate (Galician)
josé m [Fri, 20 Nov 2020 10:33:28 +0000 (10:33 +0000)] 
Translated using Weblate (Galician)

Currently translated at 97.9% (1636 of 1670 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/gl/

3 years agoTranslated using Weblate (Thai)
Phongpanot [Fri, 20 Nov 2020 04:12:50 +0000 (04:12 +0000)] 
Translated using Weblate (Thai)

Currently translated at 49.5% (828 of 1670 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/th/

3 years agoTranslated using Weblate (Chinese (Traditional))
Jeff Huang [Thu, 19 Nov 2020 02:56:24 +0000 (02:56 +0000)] 
Translated using Weblate (Chinese (Traditional))

Currently translated at 100.0% (1670 of 1670 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/zh_Hant/

3 years agoTranslated using Weblate (French (France))
Laurent Ettouati [Wed, 18 Nov 2020 20:19:24 +0000 (20:19 +0000)] 
Translated using Weblate (French (France))

Currently translated at 100.0% (101 of 101 strings)

Translation: PeerTube/player
Translate-URL: https://weblate.framasoft.org/projects/peertube/player/fr_FR/

3 years agoTranslated using Weblate (French (France))
Laurent Ettouati [Wed, 18 Nov 2020 20:17:19 +0000 (20:17 +0000)] 
Translated using Weblate (French (France))

Currently translated at 100.0% (246 of 246 strings)

Translation: PeerTube/server
Translate-URL: https://weblate.framasoft.org/projects/peertube/server/fr_FR/

3 years agoTranslated using Weblate (Dutch)
Mark Van den Borre [Wed, 18 Nov 2020 23:29:26 +0000 (23:29 +0000)] 
Translated using Weblate (Dutch)

Currently translated at 100.0% (1670 of 1670 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/nl/

3 years agoTranslated using Weblate (Spanish)
Berto Te [Thu, 19 Nov 2020 03:21:32 +0000 (03:21 +0000)] 
Translated using Weblate (Spanish)

Currently translated at 100.0% (1670 of 1670 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/es/

3 years agoTranslated using Weblate (French (France))
Laurent Ettouati [Wed, 18 Nov 2020 20:20:56 +0000 (20:20 +0000)] 
Translated using Weblate (French (France))

Currently translated at 100.0% (1670 of 1670 strings)

Translation: PeerTube/angular
Translate-URL: https://weblate.framasoft.org/projects/peertube/angular/fr_FR/

3 years agoadjust registration form width on mobile (#3274)
test2a [Wed, 25 Nov 2020 14:57:10 +0000 (20:27 +0530)] 
adjust registration form width on mobile (#3274)

Co-authored-by: Rigel Kent <sendmemail@rigelk.eu>
3 years agoFix comment account external URL
Chocobozzz [Wed, 25 Nov 2020 14:11:57 +0000 (15:11 +0100)] 
Fix comment account external URL

It did not work, and I think it's better to target the local account
page anyway

3 years agoAvoid too large cert error messages
Chocobozzz [Wed, 25 Nov 2020 13:43:18 +0000 (14:43 +0100)] 
Avoid too large cert error messages

3 years agoFix 00:00 player timestamp
Chocobozzz [Wed, 25 Nov 2020 10:56:19 +0000 (11:56 +0100)] 
Fix 00:00 player timestamp

3 years agoFix circular dep issue
Chocobozzz [Wed, 25 Nov 2020 10:44:31 +0000 (11:44 +0100)] 
Fix circular dep issue

3 years agoAdd new default different avatar for channel and account
kimsible [Wed, 18 Nov 2020 18:20:05 +0000 (19:20 +0100)] 
Add new default different avatar for channel and account

3 years agoFix migration and test
Chocobozzz [Wed, 25 Nov 2020 10:04:18 +0000 (11:04 +0100)] 
Fix migration and test

3 years agorefactor scoped token service
Rigel Kent [Mon, 9 Nov 2020 15:25:27 +0000 (16:25 +0100)] 
refactor scoped token service

3 years agoallow private syndication feeds via a user feedToken
Rigel Kent [Thu, 13 Aug 2020 13:07:23 +0000 (15:07 +0200)] 
allow private syndication feeds via a user feedToken

3 years agoAdd tests to gif resizer
Chocobozzz [Wed, 25 Nov 2020 08:50:12 +0000 (09:50 +0100)] 
Add tests to gif resizer

3 years agoAdd transcoding module comments
Chocobozzz [Tue, 24 Nov 2020 15:29:39 +0000 (16:29 +0100)] 
Add transcoding module comments

3 years agoFix audio encoding params
Chocobozzz [Tue, 24 Nov 2020 15:24:50 +0000 (16:24 +0100)] 
Fix audio encoding params

3 years agoAdd live transcoding bit rate tests
Chocobozzz [Tue, 24 Nov 2020 14:22:56 +0000 (15:22 +0100)] 
Add live transcoding bit rate tests

3 years agoSupport encoding profiles
Chocobozzz [Tue, 24 Nov 2020 13:08:23 +0000 (14:08 +0100)] 
Support encoding profiles

3 years agoExport encoders options in a dedicated struct
Chocobozzz [Mon, 23 Nov 2020 15:23:52 +0000 (16:23 +0100)] 
Export encoders options in a dedicated struct

3 years agoSplit ffmpeg utils with ffprobe utils
Chocobozzz [Fri, 20 Nov 2020 16:16:55 +0000 (17:16 +0100)] 
Split ffmpeg utils with ffprobe utils

3 years agoAdd pixel size to tooltip and gif support with FFmpeg for avatar upload (#3329)
Kimsible [Wed, 25 Nov 2020 08:26:31 +0000 (09:26 +0100)] 
Add pixel size to tooltip and gif support with FFmpeg for avatar upload (#3329)

* Add avatar pixel size upload in tooltip

* Add gif support for avatar

* Add ffmpeg GIF process

Co-authored-by: kimsible <kimsible@users.noreply.github.com>
3 years agofix user preferences column width for notifications table (#3352)
Kimsible [Tue, 24 Nov 2020 13:54:08 +0000 (14:54 +0100)] 
fix user preferences column width for notifications table (#3352)

Co-authored-by: kimsible <kimsible@users.noreply.github.com>
3 years agofix forgotten/reset password UI (#3351)
Kimsible [Tue, 24 Nov 2020 12:47:24 +0000 (13:47 +0100)] 
fix forgotten/reset password UI (#3351)

Co-authored-by: kimsible <kimsible@users.noreply.github.com>
Co-authored-by: Rigel Kent <par@rigelk.eu>
3 years agofactorize nginx websocket and per route limits
Rigel Kent [Sun, 22 Nov 2020 15:10:09 +0000 (16:10 +0100)] 
factorize nginx websocket and per route limits

3 years agofix lint for credits generation
Rigel Kent [Sun, 22 Nov 2020 13:17:32 +0000 (14:17 +0100)] 
fix lint for credits generation

3 years agoAdd tooltip to maximize button and remove grey background
kimsible [Sat, 21 Nov 2020 22:35:58 +0000 (23:35 +0100)] 
Add tooltip to maximize button and remove grey background

3 years agomove crowdfunding information to CREDITS.md
Rigel Kent [Sat, 21 Nov 2020 16:39:44 +0000 (17:39 +0100)] 
move crowdfunding information to CREDITS.md

moving that information to properly group contributions and crediting
in preparation of the v3 crowdfunding end

3 years agoexport rtmp port in dockerfiles
Rigel Kent [Sat, 21 Nov 2020 16:32:42 +0000 (17:32 +0100)] 
export rtmp port in dockerfiles

follows #3341