From: Kevin Decherf Date: Sun, 10 Dec 2017 18:31:30 +0000 (+0100) Subject: migrations: fix duplicate violation during lowercase tag migration X-Git-Tag: 2.3.0~2^2 X-Git-Url: https://git.immae.eu/?a=commitdiff_plain;h=refs%2Fpull%2F3468%2Fhead;p=github%2Fwallabag%2Fwallabag.git migrations: fix duplicate violation during lowercase tag migration Signed-off-by: Kevin Decherf --- diff --git a/app/DoctrineMigrations/Version20170719231144.php b/app/DoctrineMigrations/Version20170719231144.php index 265b539a..9a6f3e93 100644 --- a/app/DoctrineMigrations/Version20170719231144.php +++ b/app/DoctrineMigrations/Version20170719231144.php @@ -31,7 +31,7 @@ class Version20170719231144 extends AbstractMigration implements ContainerAwareI // Find tags which need to be merged $dupTags = $this->connection->query(' - SELECT LOWER(label) + SELECT LOWER(label) AS lower_label FROM ' . $this->getTable('tag') . ' GROUP BY LOWER(label) HAVING COUNT(*) > 1' @@ -39,17 +39,18 @@ class Version20170719231144 extends AbstractMigration implements ContainerAwareI $dupTags->execute(); foreach ($dupTags->fetchAll() as $duplicates) { - $label = $duplicates['LOWER(label)']; + $label = $duplicates['lower_label']; // Retrieve all duplicate tags for a given tag - $tags = $this->connection->createQuery(' + $tags = $this->connection->executeQuery(' SELECT id - FROM ' . $this->getTable('tag') . " + FROM ' . $this->getTable('tag') . ' WHERE LOWER(label) = :label - ORDER BY id ASC" + ORDER BY id ASC', + [ + 'label' => $label, + ] ); - $tags->setParameter('label', $label); - $tags->execute(); $first = true; $newId = null; @@ -71,7 +72,18 @@ class Version20170719231144 extends AbstractMigration implements ContainerAwareI $this->addSql(' UPDATE ' . $this->getTable('entry_tag') . ' SET tag_id = ' . $newId . ' - WHERE tag_id IN (' . implode(',', $ids) . ')' + WHERE tag_id IN (' . implode(',', $ids) . ') + AND entry_id NOT IN ( + SELECT entry_id + FROM ' . $this->getTable('entry_tag') . ' + WHERE tag_id = ' . $newId . ' + )' + ); + + // Delete links to unused tags + $this->addSql(' + DELETE FROM ' . $this->getTable('entry_tag') . ' + WHERE tag_id IN (' . implode(',', $ids) . ')' ); // Delete unused tags