From: ArthurHoaro <arthur@hoa.ro>
Date: Fri, 23 Oct 2020 11:28:02 +0000 (+0200)
Subject: Bulk creation: ignore blank lines
X-Git-Tag: v0.12.1^2~23^2
X-Git-Url: https://git.immae.eu/?a=commitdiff_plain;h=refs%2Fpull%2F1587%2Fhead;p=github%2Fshaarli%2FShaarli.git

Bulk creation: ignore blank lines
---

diff --git a/application/front/controller/admin/ShaarePublishController.php b/application/front/controller/admin/ShaarePublishController.php
index 65fdcdee..ddcffdc7 100644
--- a/application/front/controller/admin/ShaarePublishController.php
+++ b/application/front/controller/admin/ShaarePublishController.php
@@ -46,6 +46,9 @@ class ShaarePublishController extends ShaarliAdminController
 
         $links = [];
         foreach ($urls as $url) {
+            if (empty($url)) {
+                continue;
+            }
             $link = $this->buildLinkDataFromUrl($request, $url);
             $data = $this->buildFormData($link, $link['linkIsNew'], $request);
             $data['token'] = $this->container->sessionManager->generateToken();
diff --git a/tests/front/controller/admin/ShaarePublishControllerTest/DisplayCreateBatchFormTest.php b/tests/front/controller/admin/ShaarePublishControllerTest/DisplayCreateBatchFormTest.php
index 34547120..ce8e112b 100644
--- a/tests/front/controller/admin/ShaarePublishControllerTest/DisplayCreateBatchFormTest.php
+++ b/tests/front/controller/admin/ShaarePublishControllerTest/DisplayCreateBatchFormTest.php
@@ -36,6 +36,7 @@ class DisplayCreateBatchFormTest extends TestCase
         $urls = [
             'https://domain1.tld/url1',
             'https://domain2.tld/url2',
+            ' ',
             'https://domain3.tld/url3',
         ];
 
@@ -57,6 +58,6 @@ class DisplayCreateBatchFormTest extends TestCase
         static::assertCount(3, $assignedVariables['links']);
         static::assertSame($urls[0], $assignedVariables['links'][0]['link']['url']);
         static::assertSame($urls[1], $assignedVariables['links'][1]['link']['url']);
-        static::assertSame($urls[2], $assignedVariables['links'][2]['link']['url']);
+        static::assertSame($urls[3], $assignedVariables['links'][2]['link']['url']);
     }
 }