From: Felix Ableitner <me@nutomic.com>
Date: Tue, 9 Oct 2018 23:22:35 +0000 (-0500)
Subject: better documentation
X-Git-Tag: v1.1.0-alpha.2~30
X-Git-Url: https://git.immae.eu/?a=commitdiff_plain;h=e243c38c356b5cfd8ba1783f19389a99dc5cf527;hp=7f196c9320ab010fcf659dbf819d83dded5eeb7f;p=github%2FChocobozzz%2FPeerTube.git

better documentation
---

diff --git a/shared/models/videos/video-resolution.enum.ts b/shared/models/videos/video-resolution.enum.ts
index 13c0fe9a7..4d2644cc0 100644
--- a/shared/models/videos/video-resolution.enum.ts
+++ b/shared/models/videos/video-resolution.enum.ts
@@ -49,14 +49,16 @@ export function getTargetBitrate (resolution: VideoResolution, fps: number,
   const baseBitrate = getBaseBitrate(resolution)
   // The maximum bitrate, used when fps === VideoTranscodingFPS.MAX
   // Based on numbers from Youtube, 60 fps bitrate divided by 30 fps bitrate:
-  // 2600 / 1750 = 1.48571428571
-  // 4400 / 3300 = 1.33333333333
+  //  720p: 2600 / 1750 = 1.48571428571
+  // 1080p: 4400 / 3300 = 1.33333333333
   const maxBitrate = baseBitrate * 1.4
   const maxBitrateDifference = maxBitrate - baseBitrate
   const maxFpsDifference = fpsTranscodingConstants.MAX - fpsTranscodingConstants.AVERAGE
   // For 1080p video with default settings, this results in the following formula:
   // 3300 + (x - 30) * (1320/30)
-  // Example outputs: 1080p30: 3300 kbps, 1080p60: 4620 kbps, 720p30: 1750, 720p60: 2450
+  // Example outputs:
+  // 1080p10: 2420 kbps, 1080p30: 3300 kbps, 1080p60: 4620 kbps
+  //  720p10: 1283 kbps,  720p30: 1750 kbps,  720p60: 2450
   return baseBitrate + (fps - fpsTranscodingConstants.AVERAGE) * (maxBitrateDifference / maxFpsDifference)
 }