From: ArthurHoaro Date: Tue, 19 Jan 2021 13:31:15 +0000 (+0100) Subject: Merge pull request #1693 from ArthurHoaro/fix/bulk-add-delete X-Git-Url: https://git.immae.eu/?a=commitdiff_plain;h=baac4388b1696fb39f1b0bd621d215bba2da2ca8;hp=-c;p=github%2Fshaarli%2FShaarli.git Merge pull request #1693 from ArthurHoaro/fix/bulk-add-delete Fix: bulk add - delete existing link --- baac4388b1696fb39f1b0bd621d215bba2da2ca8 diff --combined assets/common/js/shaare-batch.js index 9753137d,2b438045..4a1fdb2e --- a/assets/common/js/shaare-batch.js +++ b/assets/common/js/shaare-batch.js @@@ -4,11 -4,7 +4,11 @@@ const sendBookmarkForm = (basePath, for const formData = new FormData(); [...inputs].forEach((input) => { - formData.append(input.getAttribute('name'), input.value); + if (input.getAttribute('type') === 'checkbox') { + formData.append(input.getAttribute('name'), input.checked); + } else { + formData.append(input.getAttribute('name'), input.value); + } }); return new Promise((resolve, reject) => { @@@ -30,9 -26,9 +30,9 @@@ const sendBookmarkDelete = (buttonElement, formElement) => ( new Promise((resolve, reject) => { const xhr = new XMLHttpRequest(); - xhr.open('GET', buttonElement.href); + xhr.open('GET', `${buttonElement.href}&source=batch`); xhr.onload = () => { - if (xhr.status !== 200) { + if (xhr.status !== 204) { alert(`An error occurred. Return code: ${xhr.status}`); reject(); } else {