From: ArthurHoaro <arthur@hoa.ro>
Date: Sun, 26 Jan 2020 13:52:10 +0000 (+0100)
Subject: Fix division by zero in tagcloud
X-Git-Tag: v0.12.0-beta~15^2
X-Git-Url: https://git.immae.eu/?a=commitdiff_plain;h=b495d5c92ad453baddb05c7a7763ae434f0c50ae;p=github%2Fshaarli%2FShaarli.git

Fix division by zero in tagcloud

It happens if we have a maximum of 1 occurrence in tags (log(1) = 0)
---

diff --git a/index.php b/index.php
index 474d9af5..b53b16fe 100644
--- a/index.php
+++ b/index.php
@@ -659,6 +659,7 @@ function renderPage($conf, $pluginManager, $bookmarkService, $history, $sessionM
 
         alphabetical_sort($tags, false, true);
 
+        $logMaxCount = $maxcount > 1 ? log($maxcount, 30) : 1;
         $tagList = array();
         foreach ($tags as $key => $value) {
             if (in_array($key, $filteringTags)) {
@@ -666,8 +667,8 @@ function renderPage($conf, $pluginManager, $bookmarkService, $history, $sessionM
             }
             // Tag font size scaling:
             //   default 15 and 30 logarithm bases affect scaling,
-            //   22 and 6 are arbitrary font sizes for max and min sizes.
-            $size = log($value, 15) / log($maxcount, 30) * 2.2 + 0.8;
+            //   2.2 and 0.8 are arbitrary font sizes in em.
+            $size = log($value, 15) / $logMaxCount * 2.2 + 0.8;
             $tagList[$key] = array(
                 'count' => $value,
                 'size' => number_format($size, 2, '.', ''),