From: ArthurHoaro <arthur@hoa.ro>
Date: Sat, 13 Jul 2019 13:09:20 +0000 (+0200)
Subject: Merge pull request #1321 from llune/patch-3
X-Git-Tag: v0.11.0~6
X-Git-Url: https://git.immae.eu/?a=commitdiff_plain;h=b15d06590548ac2d182373efab711485a897152f;hp=d91719ab978b145332f42f6c97b5041bc859df92;p=github%2Fshaarli%2FShaarli.git

Merge pull request #1321 from llune/patch-3

a11y fix img without alt
---

diff --git a/tpl/default/changepassword.html b/tpl/default/changepassword.html
index 3867e3ca..ab579433 100644
--- a/tpl/default/changepassword.html
+++ b/tpl/default/changepassword.html
@@ -11,10 +11,10 @@
     <h2 class="window-title">{"Change password"|t}</h2>
     <form method="POST" action="#" name="changepasswordform" id="changepasswordform">
       <div>
-        <input type="password" name="oldpassword" placeholder="{'Current password'|t}" class="autofocus">
+        <input type="password" name="oldpassword" aria-label="{'Current password'|t}" placeholder="{'Current password'|t}" class="autofocus">
       </div>
       <div>
-        <input type="password" name="setpassword" placeholder="{'New password'|t}">
+        <input type="password" name="setpassword" aria-label="{'New password'|t}" placeholder="{'New password'|t}">
       </div>
       <input type="hidden" name="token" value="{$token}">
       <div>
diff --git a/tpl/default/loginform.html b/tpl/default/loginform.html
index bfc54815..761aec0c 100644
--- a/tpl/default/loginform.html
+++ b/tpl/default/loginform.html
@@ -9,7 +9,7 @@
 <div class="pure-g pure-alert pure-alert-error pure-alert-closable center">
   <div class="pure-u-2-24"></div>
   <div class="pure-u-20-24">
-    {'You have been banned after too many failed login attempts. Try again later.'|t}
+    <p>{'You have been banned after too many failed login attempts. Try again later.'|t}</p>
   </div>
   <div class="pure-u-2-24">
     <i class="fa fa-times pure-alert-close"></i>
@@ -22,20 +22,19 @@
       <form method="post" name="loginform">
         <h2 class="window-title">{'Login'|t}</h2>
         <div>
-          <input type="text" name="login" placeholder="{'Username'|t}"
-             {if="!empty($username)"}value="{$username}"{/if} class="autofocus" tabindex="20">
+          <input type="text" name="login" aria-label="{'Username'|t}" placeholder="{'Username'|t}"
+             {if="!empty($username)"}value="{$username}"{/if} class="autofocus">
         </div>
         <div>
-          <input type="password" name="password" placeholder="{'Password'|t}" class="autofocus" tabindex="21">
+          <input type="password" name="password" aria-label="{'Password'|t}" placeholder="{'Password'|t}" class="autofocus">
         </div>
         <div class="remember-me">
           <input type="checkbox" name="longlastingsession" id="longlastingsessionform"
-             {if="$remember_user_default"}checked="checked"{/if}
-             tabindex="22">
+             {if="$remember_user_default"}checked="checked"{/if}>
           <label for="longlastingsessionform">{'Remember me'|t}</label>
         </div>
         <div>
-          <input type="submit" value="{'Login'|t}" class="bigbutton" tabindex="23">
+          <input type="submit" value="{'Login'|t}" class="bigbutton">
         </div>
         <input type="hidden" name="token" value="{$token}">
         {if="$returnurl"}<input type="hidden" name="returnurl" value="{$returnurl}">{/if}
@@ -48,4 +47,3 @@
 {include="page.footer"}
 </body>
 </html>
-
diff --git a/tpl/default/page.header.html b/tpl/default/page.header.html
index 9ce9873c..0ba1993f 100644
--- a/tpl/default/page.header.html
+++ b/tpl/default/page.header.html
@@ -1,11 +1,13 @@
 <div class="shaarli-menu pure-g" id="shaarli-menu">
   <div class="pure-u-lg-0 pure-u-1">
     <div class="pure-menu">
+     <header role="banner">
       <a href="{$titleLink}" class="pure-menu-link shaarli-title" id="shaarli-title-mobile">
         <i class="fa fa-shaarli" aria-hidden="true"></i>
         {$shaarlititle}
       </a>
-      <a href="#" class="menu-toggle" id="menu-toggle"><s class="bar"></s><s class="bar"></s></a>
+      </header>
+      <a href="#" class="menu-toggle" id="menu-toggle" aria-label="Menu"><s class="bar" aria-hidden="true"></s><s class="bar" aria-hidden="true"></s></a>
     </div>
   </div>
   <div class="pure-u-1">