From: Kevin Decherf Date: Fri, 7 Sep 2018 15:02:39 +0000 (+0200) Subject: Merge pull request #3719 from wallabag/fix-sort-parameters X-Git-Tag: 2.3.4~17 X-Git-Url: https://git.immae.eu/?a=commitdiff_plain;h=8013f35d96c42b15c1da28cdff40e97289ad4e25;hp=495f83c92539444bff7dfd6cd647b7d65a74f949;p=github%2Fwallabag%2Fwallabag.git Merge pull request #3719 from wallabag/fix-sort-parameters Fix sort parameters --- diff --git a/.scrutinizer.yml b/.scrutinizer.yml index dee92922..194297f6 100644 --- a/.scrutinizer.yml +++ b/.scrutinizer.yml @@ -26,3 +26,18 @@ tools: checks: php: code_rating: true + +# use the new PHP analysis engine +# https://scrutinizer-ci.com/docs/tools/php/php-analyzer/guides/migrate_to_new_php_analysis +build: + nodes: + analysis: + tests: + override: + - php-scrutinizer-run + + dependencies: + override: + - npm install -g 'yarn' + - yarn install --force + - COMPOSER_MEMORY_LIMIT=-1 composer install -o --no-interaction --no-progress --prefer-dist diff --git a/package.json b/package.json index 8d856bbb..ac894e79 100644 --- a/package.json +++ b/package.json @@ -1,13 +1,13 @@ { "name": "wallabag", - "version": "2.2.2", + "version": "2.3.3", "description": "wallabag is a self hostable application for saving web pages", "private": true, "directories": { "doc": "docs" }, "engines": { - "node": ">4.8" + "node": ">=6.10" }, "repository": { "type": "git", diff --git a/src/Wallabag/CoreBundle/Repository/EntryRepository.php b/src/Wallabag/CoreBundle/Repository/EntryRepository.php index 34123eea..83379998 100644 --- a/src/Wallabag/CoreBundle/Repository/EntryRepository.php +++ b/src/Wallabag/CoreBundle/Repository/EntryRepository.php @@ -450,7 +450,7 @@ class EntryRepository extends EntityRepository */ private function getSortedQueryBuilderByUser($userId, $sortBy = 'createdAt', $direction = 'desc') { - return $this->sortQueryBuilder($this->getQueryBuilderByUser($userId)); + return $this->sortQueryBuilder($this->getQueryBuilderByUser($userId), $sortBy, $direction); } /** diff --git a/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php b/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php index 6a4c775b..3d599ec8 100644 --- a/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php +++ b/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php @@ -1325,12 +1325,12 @@ class EntryControllerTest extends WallabagCoreTestCase 'http://www.hao123.com/shequ?__noscript__-=1', 'zh_CN', ], - 'ru_RU' => [ - 'http://netler.ru/ikt/windows-error-reporting.htm', - 'ru_RU', + 'ru' => [ + 'https://www.kp.ru/daily/26879.7/3921982/', + 'ru', ], 'pt_BR' => [ - 'http://precodoscombustiveis.com.br/postos/cidade/4121/pr/maringa', + 'https://politica.estadao.com.br/noticias/eleicoes,campanha-catatonica,70002491983', 'pt_BR', ], 'fucked_list_of_languages' => [ diff --git a/yarn.lock b/yarn.lock index 1dd45be4..7b62e0f9 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2178,6 +2178,10 @@ hawk@~3.1.3: hoek "2.x.x" sntp "1.x.x" +highlight.js@^9.12.0: + version "9.12.0" + resolved "https://registry.yarnpkg.com/highlight.js/-/highlight.js-9.12.0.tgz#e6d9dbe57cbefe60751f02af336195870c90c01e" + hmac-drbg@^1.0.0: version "1.0.1" resolved "https://registry.yarnpkg.com/hmac-drbg/-/hmac-drbg-1.0.1.tgz#d2745701025a6c775a6c545793ed502fc0c649a1"