From: Nicolas Lœuillet <nicolas@loeuillet.org>
Date: Wed, 30 Nov 2016 10:27:07 +0000 (+0100)
Subject: Code review
X-Git-Tag: 2.2.0~3^2~39^2~1
X-Git-Url: https://git.immae.eu/?a=commitdiff_plain;h=65a8c6e135e75bbcb37c286ce26b686f5af409c7;p=github%2Fwallabag%2Fwallabag.git

Code review
---

diff --git a/app/DoctrineMigrations/Version20161024212538.php b/app/DoctrineMigrations/Version20161024212538.php
index 7e79cbde..75ff86f1 100644
--- a/app/DoctrineMigrations/Version20161024212538.php
+++ b/app/DoctrineMigrations/Version20161024212538.php
@@ -37,9 +37,9 @@ class Version20161024212538 extends AbstractMigration implements ContainerAwareI
 
         $clientsTable->addForeignKeyConstraint(
             $this->getTable('user'),
-            array('user_id'),
-            array('id'),
-            array('onDelete' => 'CASCADE')
+            ['user_id'],
+            ['id'],
+            ['onDelete' => 'CASCADE']
         );
     }
 
diff --git a/app/DoctrineMigrations/Version20161122203647.php b/app/DoctrineMigrations/Version20161122203647.php
index 9c1557eb..94197193 100644
--- a/app/DoctrineMigrations/Version20161122203647.php
+++ b/app/DoctrineMigrations/Version20161122203647.php
@@ -42,12 +42,9 @@ class Version20161122203647 extends AbstractMigration implements ContainerAwareI
     {
         $userTable = $schema->getTable($this->getTable('user'));
 
-        $this->skipIf(false === $userTable->hasColumn('expired'), 'It seems that you already played this migration.');
+        $this->skipIf(false === $userTable->hasColumn('expired') || false === $userTable->hasColumn('credentials_expired'), 'It seems that you already played this migration.');
 
         $userTable->dropColumn('expired');
-
-        $this->skipIf(false === $userTable->hasColumn('credentials_expired'), 'It seems that you already played this migration.');
-
         $userTable->dropColumn('credentials_expired');
     }